On Mon, 19 Aug 2019 16:17:08 +0200
Simon Horman wrote:
> Rename the bindings documentation file for Renesas ISL29501 Time-of-flight
> sensor from isl29501.txt to renesas,isl29501.txt.
>
> This is part of an ongoing effort to name bindings documentation files for
> Renesas IP blocks consistently,
On Mon, 29 Apr 2019 17:24:09 +0200
Geert Uytterhoeven wrote:
> devm_iio_device_alloc() can only fail due to a memory or IDA allocation
> failure. Hence there is no need to print a message, as the memory
> allocation or IIO core code already takes care of that.
>
> Signed-off-by: Geert Uytterhoe
Marek Vasut
> > Cc: Geert Uytterhoeven
> > Cc: Joe Perches
> > Cc: Jonathan Cameron
> > Cc: Simon Horman
> > Cc: Wolfram Sang
> > Cc: linux-renesas-soc@vger.kernel.org
> > ---
> > V2: Add DT binding doc F: entry
>
> Reviewed-by: Simon
On Mon, 1 Oct 2018 14:17:40 +0200
Wolfram Sang wrote:
> On Mon, Oct 01, 2018 at 01:58:26PM +0200, Marek Vasut wrote:
> > On 10/01/2018 01:55 PM, Wolfram Sang wrote:
> > > On Mon, Oct 01, 2018 at 12:58:04PM +0200, Marek Vasut wrote:
> > >> Fix the F: entry in MAINTAINERS file, point it to the
On Thu, 19 Apr 2018 16:05:48 +0200
Wolfram Sang wrote:
> We should get drvdata from struct device directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang
Applied, thanks.
Jonathan
> ---
>
> Build tested only. buildbot is happy. Please apply i
On Thu, 19 Apr 2018 16:06:18 +0200
Wolfram Sang wrote:
> We should get drvdata from struct device directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang
Applied, thanks,
Jonathan
> ---
>
> Build tested only. buildbot is happy. Please apply i
On Thu, 19 Apr 2018 16:05:49 +0200
Wolfram Sang wrote:
> We should get drvdata from struct device directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang
Applied, thanks,
Jonathan
> ---
>
> Build tested only. buildbot is happy. Please apply i
On Mon, 4 Dec 2017 22:05:41 +
Mark Brown wrote:
> On Sun, Dec 03, 2017 at 08:43:47PM +0100, Wolfram Sang wrote:
>
> > > It's a bit different in that it's much more likely that a SPI controller
> > > will actually do DMA than an I2C one since the speeds are higher and
> > > there's frequent a
ons to paths where the i2c
master can't take advantage. Not ideal, but perhaps not worth the hassle
of working around it?
It's only for the block calls I guess so not that major an issue.
Reviewed-by: Jonathan Cameron
> ---
> drive
On Sat, 4 Nov 2017 21:20:05 +0100
Wolfram Sang wrote:
> Use the new helper to create variants of i2c_master_{send|recv} which
> mark their buffers as DMA safe.
>
> Signed-off-by: Wolfram Sang
Can't really argue with such a simple patch ;)
Acked-by: Jonathan Cameron
>
way.
>
> Signed-off-by: Wolfram Sang
Reviewed-by: Jonathan Cameron
> ---
> drivers/i2c/i2c-core-base.c | 64
> +
> include/linux/i2c.h | 34 +---
> 2 files changed, 48 insertions(+), 50 deletions(-)
>
On Thu, 5 Oct 2017 11:12:59 +0200
Simon Horman wrote:
> On Wed, Oct 04, 2017 at 02:08:26PM +0200, Geert Uytterhoeven wrote:
> > Use the of_device_get_match_data() helper instead of open coding.
> > Note that the rcar-gyroadc driver is used with DT only, so there's
> > always a valid match.
> >
>
On Thu, 5 Oct 2017 11:12:21 +0200
Simon Horman wrote:
> On Wed, Oct 04, 2017 at 02:08:25PM +0200, Geert Uytterhoeven wrote:
> > The rcar-gyroadc driver compiles fine on other platforms, hence increase
> > compile coverage.
> >
> > Signed-off-by: Geert Uytterhoeven
>
> Reviewed-by: Simon Horm
On Thu, 5 Oct 2017 11:11:51 +0200
Simon Horman wrote:
> On Wed, Oct 04, 2017 at 02:08:24PM +0200, Geert Uytterhoeven wrote:
> > On 64-bit:
> >
> > drivers/iio/adc/rcar-gyroadc.c: In function
> > 'rcar_gyroadc_parse_subdevs':
> > drivers/iio/adc/rcar-gyroadc.c:352:15: warning: cast from
On Thu, 21 Sep 2017 16:15:28 +0200
Wolfram Sang wrote:
> > > > +/**
> > > > + * i2c_release_dma_safe_msg_buf - release DMA safe buffer and sync
> > > > with i2c_msg
> > > > + * @msg: the message to be synced with
> > > > + * @buf: the buffer obtained from i2c_get_dma_safe_msg_buf(). May be
> >
On Wed, 20 Sep 2017 20:59:56 +0200
Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang
Makes sense as do the other drivers.
Feel free to add
Reviewed-by: Jonathan Cameron
to all of them (though they hardly took a lot of reviewing given how simple
the patches were :)
> ---
> driver
suggestion inline. I don't really care either way as
what you had is perfectly comprehensible.
Reviewed-by: Jonathan Cameron
>
> > ---
> > Documentation/i2c/DMA-considerations | 58
> >
> > 1 file changed, 58 insertions(+)
&
On Thu, 21 Sep 2017 14:59:22 +0100
Jonathan Cameron wrote:
> On Wed, 20 Sep 2017 20:59:52 +0200
> Wolfram Sang wrote:
>
> > One helper checks if DMA is suitable and optionally creates a bounce
> > buffer, if not. The other function returns the bounce buffer and makes
fram Sang
One minor suggestion for wording. Otherwise looks good to me.
Reviewed-by: Jonathan Cameron
> ---
> drivers/i2c/i2c-core-base.c | 45
> +
> include/linux/i2c.h | 3 +++
> 2 files changed, 48 insertions(+)
>
&g
On Thu, 17 Aug 2017 16:14:43 +0200
Wolfram Sang wrote:
> So, after revisiting old mail threads, taking part in a similar discussion on
> the USB list, and implementing a not-convincing solution before, here is what
> I
> cooked up to document and ease DMA handling for I2C within Linux. Please ha
On Tue, 18 Jul 2017 12:23:37 +0200
Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang
Is this material not perhaps better placed in the sphinx docs?
Up to you of course as your subsystem ;)
Text is good though.
Acked-by: Jonathan Cameron
> ---
> Changes since v2:
>
> * docume
On Tue, 18 Jul 2017 12:23:36 +0200
Wolfram Sang wrote:
> One helper checks if DMA is suitable and optionally creates a bounce
> buffer, if not. The other function returns the bounce buffer and makes
> sure the data is properly copied back to the message.
>
> Signed-off-by: Wolfram Sang
My knowl
On 09/05/17 12:53, Geert Uytterhoeven wrote:
Hi Jacopo,
On Tue, May 9, 2017 at 9:57 AM, Jacopo Mondi wrote:
The power and current "shunt-resistor" attribute's 'show' function
displays the resistor value in milli-Ohms, while the ABI description
specifies it should be displayed in Ohms. Fix it.
econd "if" clock and retain only the "fck" clock.
>>
>> Signed-off-by: Marek Vasut
>> Cc: Geert Uytterhoeven
>> Cc: Jonathan Cameron
>> Cc: Rob Herring
>> Cc: linux-renesas-soc@vger.kernel.org
>> To: devicet...@vger.kernel.org
>
&g
d "if" clock and get the clock speed from "fck".
>>
>> Signed-off-by: Marek Vasut
>> Cc: Geert Uytterhoeven
>> Cc: Jonathan Cameron
>> Cc: linux-renesas-soc@vger.kernel.orgPlease include the name of the driver
>> in the patch title.
I'v
On 06/04/17 15:20, Jacopo Mondi wrote:
> Add device nodes for two Maxim max961x current sense amplifiers
> sensing VDD_08 and DVFS_08 lines.
>
> Signed-off-by: Jacopo Mondi
> Reviewed-by: Geert Uytterhoeven
Driver now applied and should make the coming merge window easily,
so I'll assume this wi
On 06/04/17 15:20, Jacopo Mondi wrote:
> Add iio driver for Maxim max9611 and max9612 current-sense amplifiers
> with 12-bits ADC interface.
>
> Datasheet publicly available at:
> https://datasheets.maximintegrated.com/en/ds/MAX9611-MAX9612.pdf
>
> Signed-off-by: Jacopo Mondi
Applied to the togr
On 06/04/17 15:20, Jacopo Mondi wrote:
> Add documentation for max9611 driver.
> Document attributes describing value of shunt resistor installed between
> RS+ and RS- voltage sense inputs.
>
> Signed-off-by: Jacopo Mondi
Looks good to me. There is the small matter that when we generalize this
w
On 06/04/17 15:43, Geert Uytterhoeven wrote:
> On Thu, Apr 6, 2017 at 4:20 PM, Jacopo Mondi
> wrote:
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/adc/max9611.txt
>> @@ -0,0 +1,27 @@
>> +* Maxim max9611/max9612 current sense amplifier with 12-bits ADC interface
>> +
>> +Maxim m
On 02/04/17 10:36, Jonathan Cameron wrote:
> On 27/03/17 16:12, Jacopo Mondi wrote:
>> Add documentation for max9611 driver.
>> Document attributes describing value of shunt resistor installed between
>> RS+ and RS- voltage sense inputs.
>>
>> Signed-off-by: Ja
On 27/03/17 16:12, Jacopo Mondi wrote:
> Add iio driver for Maxim max9611 and max9612 current-sense amplifiers
> with 12-bits ADC interface.
>
> Datasheet publicly available at:
> https://datasheets.maximintegrated.com/en/ds/MAX9611-MAX9612.pdf
>
> Signed-off-by: Jacopo Mondi
>
couple of bits in
On 27/03/17 16:12, Jacopo Mondi wrote:
> Add documentation for max9611 driver.
> Document attributes describing value of shunt resistor installed between
> RS+ and RS- voltage sense inputs.
>
> Signed-off-by: Jacopo Mondi
Good. Will pick up once the binding is sorted.
Kick me if I don't!
> ---
On 27/03/17 16:12, Jacopo Mondi wrote:
> Add device tree bindings documentation for Maxim max9611/max9612 current
> sense amplifier.
>
> Signed-off-by: Jacopo Mondi
> ---
> .../devicetree/bindings/iio/adc/max9611.txt| 26
> ++
> 1 file changed, 26 insertions(+)
> cr
On 26/03/17 11:02, jacopo wrote:
> Hi Jonathan,
>
> On Sat, Mar 25, 2017 at 05:37:52PM +, Jonathan Cameron wrote:
>> On 25/03/17 17:21, jacopo wrote:
>>> Hi Jonathan,
>>> thanks for review
>
> [snip]
>
>>>>> +
>>
On 26 March 2017 10:07:58 BST, Geert Uytterhoeven wrote:
>Hi Jacopo, Jonathan,
>
>On Fri, Mar 24, 2017 at 4:28 PM, Jacopo Mondi
> wrote:
>> Third round for Maxim max9611/max9612 high-side current sense
>amplifier driver.
>>
>> For reference, a simplified integration schematic drawing is here
>re
On 25/03/17 17:21, jacopo wrote:
> Hi Jonathan,
> thanks for review
>
> On Sat, Mar 25, 2017 at 03:45:05PM +0000, Jonathan Cameron wrote:
>> On 24/03/17 15:28, Jacopo Mondi wrote:
>>> Add iio driver for Maxim max9611 and max9612 current-sense amplifiers
>
On 24/03/17 15:28, Jacopo Mondi wrote:
> Add documentation for max9611 driver.
> Document attributes describing value of shunt resistor installed between
> RS+ and RS- voltage sense inputs.
>
> Signed-off-by: Jacopo Mondi
> ---
> Documentation/ABI/testing/sysfs-bus-iio-adc-max9611 | 16 +
On 24/03/17 15:28, Jacopo Mondi wrote:
> Add iio driver for Maxim max9611 and max9612 current-sense amplifiers
> with 12-bits ADC interface.
>
> Datasheet publicly available at:
> https://datasheets.maximintegrated.com/en/ds/MAX9611-MAX9612.pdf
>
> Signed-off-by: Jacopo Mondi
A few more little t
On 24/03/17 15:28, Jacopo Mondi wrote:
> Add device tree bindings documentation for Maxim max9611/max9612 current
> sense amplifier.
>
> Signed-off-by: Jacopo Mondi
Fine with me, waiting for Mark or Rob to take a look though
> ---
> .../devicetree/bindings/iio/adc/max9611.txt| 26
>
On 21/03/17 16:09, jacopo wrote:
> Hi Jonathan,
>
> On Sat, Feb 25, 2017 at 03:54:45PM +, Jonathan Cameron wrote:
>> On 24/02/17 15:05, Jacopo Mondi wrote:
>>> Add documentation for max961x driver.
>>> The only attribute to document is the curre
On 07/03/17 19:12, jacopo mondi wrote:
> Hi Jonathan,
>
>+ Neil Amstrong from Baylibre
>
> On 05/03/2017 11:49, Jonathan Cameron wrote:
>> On 27/02/17 09:09, jacopo mondi wrote:
>>> Hi Jonathan,
>>> On 25/02/2017 17:09, Jonathan Cameron wrote:
>
On 27/02/17 09:09, jacopo mondi wrote:
> Hi Jonathan,
> On 25/02/2017 17:09, Jonathan Cameron wrote:
>> On 24/02/17 15:05, Jacopo Mondi wrote:
>>> Hello!
>>>
>>> This series adds driver and documentation for Maxim max9611/max9612
>>> high-side
On 27/02/17 07:45, jacopo mondi wrote:
> Hi Jonathan,
>thanks for review
>
> On 25/02/2017 16:53, Jonathan Cameron wrote:
>> On 24/02/17 15:05, Jacopo Mondi wrote:
>>> Add iio driver for Maxim max9611/9612 current-sense amplifiers with
>>> 12-bits
On 24/02/17 15:05, Jacopo Mondi wrote:
> Hello!
>
> This series adds driver and documentation for Maxim max9611/max9612
> high-side current sense amplifier with 12-bit ADC and I2c interface.
> It also registers two devices installed on VDD_0.8V and DVFS_0.8V lines
> in Renesas r87796 Salvator-X bo
On 24/02/17 15:05, Jacopo Mondi wrote:
> Add documentation for max961x driver.
> The only attribute to document is the current sense shunt resistor
> value.
>
> Signed-off-by: Jacopo Mondi
Interestingly generic as it only applies to some of the channels.
We might need to have the channel where it
On 25/02/17 15:34, Geert Uytterhoeven wrote:
> Hi Jonathan,
>
> On Sat, Feb 25, 2017 at 4:19 PM, Jonathan Cameron wrote:
>> On 24/02/17 15:48, jacopo mondi wrote:
>>> On 24/02/2017 16:33, Lars-Peter Clausen wrote:
>>>> On 02/24/2017 04:22 PM, Geert Uytterhoev
On 24/02/17 15:05, Jacopo Mondi wrote:
> Add iio driver for Maxim max9611/9612 current-sense amplifiers with
> 12-bits ADC.
Data sheet link always good
>
> Signed-off-by: Jacopo Mondi
I'm going to respond to the cover letter wrt to providing dynamic scales
and offsets in a moment as you raised th
On 24/02/17 15:48, jacopo mondi wrote:
> Hi Lars-Peter,
>
> On 24/02/2017 16:33, Lars-Peter Clausen wrote:
>> On 02/24/2017 04:22 PM, Geert Uytterhoeven wrote:
>>> On Fri, Feb 24, 2017 at 4:05 PM, Jacopo Mondi
>>> wrote:
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/max
ytterhoeven
> Cc: Simon Horman
> Cc: Jonathan Cameron
> Cc: linux-renesas-soc@vger.kernel.org
> Cc: Wolfram Sang
> Cc: Rob Herring
> Acked-by: Rob Herring
> Cc: devicet...@vger.kernel.org
Applied to the togreg branch of iio.git and pushed out as testing for
the aut
ytterhoeven
> Cc: Simon Horman
> Cc: Jonathan Cameron
> Cc: linux-renesas-soc@vger.kernel.org
> Cc: Wolfram Sang
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.
Thanks,
Jonathan
> ---
> V2: - Spelling fixes
> -
On 21/01/17 20:33, Rob Herring wrote:
> On Wed, Jan 18, 2017 at 05:30:53PM +0100, Jacopo Mondi wrote:
>> Add device tree bindings documentation for Maxim MAX11100 single-channel
>> ADC
>>
>> Signed-off-by: Jacopo Mondi
>> Reviewed-by: Geert Uytterhoeven
>> Acked-by: Wolfram Sang
>> ---
>> .../d
On 21/01/17 13:22, Jonathan Cameron wrote:
> On 18/01/17 16:30, Jacopo Mondi wrote:
>> Add device tree bindings documentation for Maxim MAX11100 single-channel
>> ADC
>>
>> Signed-off-by: Jacopo Mondi
>> Reviewed-by: Geert Uytterhoeven
>> Acked-by: Wolfram
On 19/01/17 21:47, jacopo mondi wrote:
> Hi Peter,
>
> On 19/01/2017 19:15, Peter Meerwald-Stadler wrote:
>>
>>> Add iio driver for Maxim MAX11100 single-channel ADC.
>>
>> minor comments, maybe Jonathan can fix it up when taking this...
>>
>>> +struct max11100_state {
>>> +const struct max111
On 18/01/17 16:30, Jacopo Mondi wrote:
> Add device tree bindings documentation for Maxim MAX11100 single-channel
> ADC
>
> Signed-off-by: Jacopo Mondi
> Reviewed-by: Geert Uytterhoeven
> Acked-by: Wolfram Sang
Simple enough I'm happy to take it without bothering Rob or Mark.
However, any devi
On 15/01/17 17:05, Marek Vasut wrote:
> Add IIO driver for the Renesas RCar GyroADC block. This block is a
> simple 4/8-channel ADC which samples 12/15/24 bits of data every
> cycle from all channels.
>
> Signed-off-by: Marek Vasut
> Cc: Geert Uytterhoeven
> Cc: Simon H
On 15/01/17 17:06, Marek Vasut wrote:
> On 01/15/2017 05:28 PM, Jonathan Cameron wrote:
>>
>>
>> On 15 January 2017 15:47:31 GMT+00:00, Marek Vasut
>> wrote:
>>> On 01/15/2017 03:05 PM, Jonathan Cameron wrote:
>>>> On 15/01/17 00:14, Marek Vasut
On 15 January 2017 15:47:31 GMT+00:00, Marek Vasut
wrote:
>On 01/15/2017 03:05 PM, Jonathan Cameron wrote:
>> On 15/01/17 00:14, Marek Vasut wrote:
>>> Add IIO driver for the Renesas RCar GyroADC block. This block is a
>>> simple 4/8-channel ADC which samples
On 15/01/17 14:41, jacopo mondi wrote:
> Hi Jonathan,
>
> On 15/01/2017 15:31, Jonathan Cameron wrote:
>> On 15/01/17 14:13, jacopo mondi wrote:
>>> Hi Jonathan,
>>>thanks for review,
>>>
>>> On 13/01/2017 10:50, Jacopo Mondi wrote:
>&
On 15/01/17 14:13, jacopo mondi wrote:
> Hi Jonathan,
>thanks for review,
>
> On 13/01/2017 10:50, Jacopo Mondi wrote:
>> Hello,
>>sending out v4 splitting device tree bindings documentation and actual ADC
>> driver.
>> No changes in driver code since v3.
>>
>> Same question for iio mainta
On 15/01/17 00:14, Marek Vasut wrote:
> Add IIO driver for the Renesas RCar GyroADC block. This block is a
> simple 4/8-channel ADC which samples 12/15/24 bits of data every
> cycle from all channels.
>
> Signed-off-by: Marek Vasut
> Cc: Geert Uytterhoeven
> Cc: Simon H
On 13/01/17 09:50, Jacopo Mondi wrote:
> From: Jacopo Mondi
>
> Add iio driver for Maxim MAX11100 single-channel ADC.
>
> Signed-off-by: Jacopo Mondi
> Tested-by: Marek Vasut
>
Small issue with DMA using SPI controllers and the location of buffer
in your read.
Otherwise looks good to me.
Jon
On 02/01/17 09:19, jacopo mondi wrote:
> Hi Jonathan,
>thanks for review
>
> On 30/12/2016 17:31, Jonathan Cameron wrote:
>> On 14/12/16 12:00, jac...@jmondi.org wrote:
>>> Hello Peter,
>>>thanks for review
>>>
>>> On 13/12/2016 2
On 13/12/16 12:37, Jacopo Mondi wrote:
> Add IIO driver for Maxim MAX11100 single-channel ADC.
> Add DT bindings documentation.
>
> Signed-off-by: Jacopo Mondi
Nothing significant to add, but a few comments inline.
Jonathan
> ---
>
> v1 -> v2:
> - incorporated pmeerw's review comments
>
On 14/12/16 12:00, jac...@jmondi.org wrote:
> Hello Peter,
>thanks for review
>
> On 13/12/2016 21:33, Peter Meerwald-Stadler wrote:
>>
>>> Add IIO driver for Maxim MAX11100 single-channel ADC.
>>> Add DT bindings documentation.
>>
>> some more comments
>>
>>> Signed-off-by: Jacopo Mondi
>>>
On 13/12/16 15:53, Wolfram Sang wrote:
>
>>> +struct max11100_state {
>>> + const struct max11100_chip_desc *desc;
>>> + struct spi_device *spi;
>>> + int vref_uv;
>>
>> unsi
>> It's good practice to move the smaller members to the end of the structure,
>> to avoid gaps due to al
On 13/12/16 12:37, Jacopo Mondi wrote:
> Add IIO driver for Maxim MAX11100 single-channel ADC.
> Add DT bindings documentation.
>
> Signed-off-by: Jacopo Mondi
A quick process related thing. Please don't post a new
version of a driver as a reply to an old version. It very rapidly
leads to deep a
On 07/12/16 08:29, jac...@jmondi.org wrote:
> Hi Peter,
>thanks for review
>
> On 06/12/2016 22:00, Peter Meerwald-Stadler wrote:
>> On Tue, 6 Dec 2016, Jacopo Mondi wrote:
>>
>>> Add IIO driver for Maxim MAX11100 single-channel ADC.
>>> Support raw_read mode only.
>>
>> comments below; very m
On 07/12/16 12:22, Geert Uytterhoeven wrote:
> Hi Jacopo,
>
> On Wed, Dec 7, 2016 at 9:29 AM, jac...@jmondi.org wrote:
>> On 06/12/2016 22:00, Peter Meerwald-Stadler wrote:
>>> On Tue, 6 Dec 2016, Jacopo Mondi wrote:
Add IIO driver for Maxim MAX11100 single-channel ADC.
Support raw_read
68 matches
Mail list logo
