xes: cad160ed0a94927e ("ARM: shmobile: Convert file to use cntvoff")
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Maxime Ripard
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
r is based on a prototype by Koji Matsuoka in the Renesas BSP.
>
> Signed-off-by: Niklas Söderlund
Reviewed-by: Maxime Ripard
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
Hi!
On Tue, May 08, 2018 at 10:11:07AM -0700, Florian Fainelli wrote:
> On 05/08/2018 06:19 AM, Maxime Ripard wrote:
> > Hi,
> >
> > On Fri, May 04, 2018 at 09:05:33PM +0200, Mylène Josserand wrote:
> >> Hello everyone,
> >>
> >> This is a V9
-a83t
> (see patch 07), according to Maxime's review.
The machine name hasn't changed, and the name sun8i-a83t still doesn't
make much sense. I've fixed it as well.
Thanks,
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
stead.
>
> Signed-off-by: Mylène Josserand
Acked-by: Maxime Ripard
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
s function.
> >
> > Signed-off-by: Mylène Josserand
> > Reviewed-by: Geert Uytterhoeven
> > Tested-by: Geert Uytterhoeven
>
> Acked-by: Simon Horman
For the sake of bisectability (and to ease the merge), is it ok if we
take it through the sunxi (and then arm-soc
erence is the Power Off Gating register for clusters
> which is BIT(4) in case of SUN9I-A80 and BIT(0) in case of SUN8I-A83T.
> There is also a bit swap between sun8i-a83t and sun9i-a80 that must be
> handled.
>
> Signed-off-by: Mylène Josserand
Acked-by: Maxime Ripard
Maxime
Signed-off-by: Mylène Josserand
Acked-by: Maxime Ripard
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
ction into secondary_startup
> assembly entry.
>
> Signed-off-by: Mylène Josserand
> Acked-by: Maxime Ripard
> ---
> arch/arm/mach-sunxi/headsmp.S | 1 +
> arch/arm/mach-sunxi/sunxi.c | 20 +++-
> 2 files changed, 20 insertions(+), 1 deletion(-)
>
>
+#endif
> +}
> +
> +static const char * const sun8i_cntvoff_board_dt_compat[] = {
> + "allwinner,sun8i-a83t",
> + NULL,
> +};
> +
> +DT_MACHINE_START(SUN8I_CNTVOFF_DT, "Allwinner sun8i-a83t board")
This name still doesn't really make much sense. It's an A83t, that's
it.
Apart from the other minor comment I had, and once that name has been
fixed:
Acked-by: Maxime Ripard
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
int core, unsigned int cluster)
> {
> @@ -624,6 +625,7 @@ struct sunxi_mc_smp_nodes {
> struct sunxi_mc_smp_data {
> const char *enable_method;
> int (*get_smp_nodes)(struct sunxi_mc_smp_nodes *nodes);
> + int is_a83t;
This can be made a boolean.
Maxime
--
Maxime R
On Tue, Apr 17, 2018 at 07:25:15PM +0800, Chen-Yu Tsai wrote:
> On Tue, Apr 17, 2018 at 7:17 PM, Maxime Ripard
> wrote:
> > On Tue, Apr 17, 2018 at 11:12:41AM +0800, Chen-Yu Tsai wrote:
> >> On Tue, Apr 17, 2018 at 5:50 AM, Mylène Josserand
> >> wrote:
> >&g
id you have time to test it?
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
; >
> > Do we really need to cache it? Can't we just have a pointer to the SMP
> > data structure and use that instead?
>
> I recommended that. We don't need any of the other fields in the SMP
> data structure once we're past the init phase. This saves a
SM to separate
> file" thing, especially now that you aren't actually adding any
> sunxi-specific ASM code beyond a simple function call.
>
> Could you drop this for now?
I'd really like to have this merged actually. There's a significant
readibility improvement
_sun8i = sunxi_mc_smp_data[i].is_sun8i;
> +
Do we really need to cache it? Can't we just have a pointer to the SMP
data structure and use that instead?
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
t;subdev.entity, NR_OF_RCAR_CSI2_PAD,
> + priv->pads);
> + if (ret)
> + goto error;
> +
> + pm_runtime_enable(&pdev->dev);
Is CONFIG_PM mandatory on Renesas SoCs? If not, you end up with the
device uninitialised at
> Cc: Manfred Schlaegl
> Cc: Marek Vasut
> Cc: Archit Taneja
> Cc: Andrzej Hajda
> Cc: Alison Wang
> Cc: Eric Anholt
> Cc: Linus Walleij
> Cc: linux-renesas-soc@vger.kernel.org
> Cc: Maxime Ripard
For sun4i,
Acked-by: Maxime Ripard
Thanks!
Maxime
--
Maxime Rip
Y_SIZE(colorkey_modes),
> + true);
You seem to define the same list in your enumeration between your
patch 2 and this one. Can this be something made generic too?
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
operties
> related to color keying named colorkey.min, colorkey.max, colorkey.alpha
> and colorkey.mode. Additional properties can be defined by drivers to
> expose device-specific features.
>
> Signed-off-by: Laurent Pinchart
Sorry for the delay,
Reviewed-by: Maxime Ripard
Since the stream is multiplexed both using the virtual channels and
the data-types, I'm not sure representing it using only muxed pads
like you did would work.
And I don't really know what a good stop gap measure would be either.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
Hi Daniel,
On Tue, Jul 18, 2017 at 09:35:03AM +0200, Daniel Vetter wrote:
> On Tue, Jul 18, 2017 at 9:07 AM, Maxime Ripard
> wrote:
> > On Mon, Jul 17, 2017 at 02:57:19PM +0800, Chen-Yu Tsai wrote:
> >> On Mon, Jul 17, 2017 at 2:55 PM, Maxime Ripard
> >> wrote:
>
while everything else happens
>in the v4l2-async framework. This leaves the interface in a good
>position for possible changes in v4l2-async.
>
> This is tested on Renesas H3 and M3-W together with the Renesas CSI-2
> and VIN Gen3 driver (posted separately). It is based on top
liang Liu
> Cc: Rongrong Zou
> Cc: Xinwei Kong
> Cc: Chen Feng
> Cc: CK Hu
> Cc: Philipp Zabel
> Cc: Matthias Brugger
> Cc: Neil Armstrong
> Cc: Carlo Caione
> Cc: Kevin Hilman
> Cc: Thierry Reding
> Cc: Laurent Pinchart
> Cc: Mark Yao
> Cc: Heiko St
> Cc: Michael Turquette
> Cc: Stephen Boyd
> Cc: Maxime Coquelin
> Cc: Alexandre Torgue
> Cc: Russell King
> Cc: Matthias Brugger
> Cc: Geert Uytterhoeven
> Cc: Maxime Ripard
> Cc: Chen-Yu Tsai
> Cc: "Emilio López"
> Cc: Peter De Schrijver
> Cc:
On Mon, Jul 17, 2017 at 02:57:19PM +0800, Chen-Yu Tsai wrote:
> On Mon, Jul 17, 2017 at 2:55 PM, Maxime Ripard
> wrote:
> > On Fri, Jul 14, 2017 at 04:56:01PM +0800, Chen-Yu Tsai wrote:
> >> Hi,
> >>
> >> On Thu, Jul 13, 2017 at 10:41 PM, Maxime Ripard
>
Hi Laurent,
On Fri, Jul 14, 2017 at 02:43:12AM +0300, Laurent Pinchart wrote:
> Hi Maxime,
>
> Thank you for the patch.
>
> On Thursday 13 Jul 2017 16:41:13 Maxime Ripard wrote:
> > The current drm_atomic_helper_commit_tail helper works only if the CRTC is
> > a
On Fri, Jul 14, 2017 at 04:56:01PM +0800, Chen-Yu Tsai wrote:
> Hi,
>
> On Thu, Jul 13, 2017 at 10:41 PM, Maxime Ripard
> wrote:
> > In the earlier display engine designs, any register access while a commit
> > is pending is forbidden.
> >
> > One of the symp
; > [PATCH 1/4] drm/atomic: implement drm_atomic_helper_commit_tail for
> > runtime_pm users
>
> Never mind - I've just looked again, and seen that this new helper function is
> the ordering previous to *this* patch, and therefore isn't the same.
>
> However -
modifications.
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/sun4i_crtc.c | 2 ++
drivers/gpu/drm/sun4i/sunxi_engine.h | 14 ++
2 files changed, 16 insertions(+)
diff --git a/drivers/gpu/drm/sun4i/sun4i_crtc.c
b/drivers/gpu/drm/sun4i/sun4i_crtc.c
index f8c70439d1e2
The backend (planes) commit can only happen when the TCON (CRTC) is
enabled, which is not guaranteed with the default commit_tail helper.
Let's use the runtime_pm version that is designed specifically to deal with
that case.
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/
In the earlier display engine designs, any register access while a commit
is pending is forbidden.
One of the symptoms is that reading a register will return another, random,
register value which can lead to register corruptions if we ever do a
read/modify/write cycle.
Signed-off-by: Maxime
l the relevant users can
use directly.
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/drm_atomic_helper.c| 47 +++
drivers/gpu/drm/exynos/exynos_drm_fb.c | 27 +-
drivers/gpu/drm/rcar-du/rcar_du_kms.c | 18 +-
drivers/gpu/drm/roc
what you think,
Maxime
Maxime Ripard (4):
drm/atomic: implement drm_atomic_helper_commit_tail for runtime_pm users
drm/sun4i: Use the runtime_pm commit_tail variant
drm/sun4i: engine: Add commit_poll function
drm/sun4i: make sure we don't have a commit pending
drivers/gpu/drm/drm_atomic_
On Wed, Nov 30, 2016 at 02:57:35PM +0900, Chanwoo Choi wrote:
> This patch just uses the resource-managed extcon API when registering
> the extcon notifier.
>
> Signed-off-by: Chanwoo Choi
Acked-by: Maxime Ripard
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linu
an adv7123 driver when needed without breaking backward
> compatibility.
>
> Signed-off-by: Laurent Pinchart
Acked-by: Maxime Ripard
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
36 matches
Mail list logo
