Re: [PATCH] kbuild: fix kernel/bounds.c 'W=1' warning

2018-10-06 Thread Miguel Ojeda
Hi Masahiro, On Sat, Oct 6, 2018 at 11:59 PM Masahiro Yamada wrote: > > On Sun, Oct 7, 2018 at 6:18 AM Miguel Ojeda > wrote: > > > > I think marking the function as static __used should do the trick and > > would be less confusing. > > I tried __used, but I sti

Re: [PATCH] kbuild: fix kernel/bounds.c 'W=1' warning

2018-10-06 Thread Miguel Ojeda
On Fri, Oct 5, 2018 at 10:35 AM Arnd Bergmann wrote: > > Building any configuration with 'make W=1' produces a warning: > > kernel/bounds.c:16:6: warnign: no previous prototype for 'foo' > [-Wmissing-prototypes] > > When also passing -Werror, this prevents us from building any > other files. Nobo

Re: [PATCH 03/61] auxdisplay: simplify getting .drvdata

2018-04-19 Thread Miguel Ojeda
[CC'ing Linus W.] On Thu, Apr 19, 2018 at 4:05 PM, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Seems fine and other drivers in platform/ also call dev_get_drvdata directl