[PATCH v14 01/33] dt-bindings: media: rcar_vin: Reverse SoC part number list

2018-04-14 Thread Niklas Söderlund
d-by: Simon Horman <horms+rene...@verge.net.au> Acked-by: Rob Herring <r...@kernel.org> Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> Acked-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboar

Re: Potential problem with 31e77c93e432dec7 ("sched/fair: Update blocked load when newly idle")

2018-04-13 Thread Niklas Söderlund
Hi Vincent, On 2018-04-12 13:15:19 +0200, Niklas Söderlund wrote: > Hi Vincent, > > Thanks for your feedback. > > On 2018-04-12 12:33:27 +0200, Vincent Guittot wrote: > > Hi Niklas, > > > > On 12 April 2018 at 11:18, Niklas Söderlund > > <niklas.soder

Re: Potential problem with 31e77c93e432dec7 ("sched/fair: Update blocked load when newly idle")

2018-04-12 Thread Niklas Söderlund
incent > > > > > > > > > > Regards, > > > Vincent > > > > > > > > 1. c18bb396d3d261eb ("Merge > > > > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net")) > > > > 2. 31e77c93e432dec7 ("sched/fair: Update blocked load when newly idle") > > > > > > > > -- > > > > Regards, > > > > Niklas Söderlund > > > > -- > > Regards, > > Niklas Söderlund -- Regards, Niklas Söderlund

Re: Potential problem with 31e77c93e432dec7 ("sched/fair: Update blocked load when newly idle")

2018-04-12 Thread Niklas Söderlund
/arm/configs/shmobile_defconfig for my tests. -- Regards, Niklas Söderlund

Re: Potential problem with 31e77c93e432dec7 ("sched/fair: Update blocked load when newly idle")

2018-04-12 Thread Niklas Söderlund
Hi Vincent, Thanks for your feedback. On 2018-04-12 12:33:27 +0200, Vincent Guittot wrote: > Hi Niklas, > > On 12 April 2018 at 11:18, Niklas Söderlund > <niklas.soderl...@ragnatech.se> wrote: > > Hi Vincent, > > > > I have observed issues running on

Potential problem with 31e77c93e432dec7 ("sched/fair: Update blocked load when newly idle")

2018-04-12 Thread Niklas Söderlund
/net")) 2. 31e77c93e432dec7 ("sched/fair: Update blocked load when newly idle") -- Regards, Niklas Söderlund

Re: [PATCH] clk: renesas: rcar-gen2: Centralize quirks handling

2018-04-10 Thread Niklas Söderlund
; > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> > --- > To be queued in clk-renesas-for-v4.18. > > drivers/clk/renesas/rcar-gen2-cpg.c | 20 > 1 file change

Re: [PATCH v13 02/33] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

2018-04-10 Thread Niklas Söderlund
ometime next week. > > Thanks, > Fab > > > -Original Message----- > > From: Niklas Söderlund [mailto:niklas.soderlund+rene...@ragnatech.se] > > Sent: 26 March 2018 22:44 > > To: Laurent Pinchart <laurent.pinch...@ideasonboard.com>; Hans Verkuil > &

Re: [PATCH/RFT v2 0/3] thermal: add support for r8a77995

2018-04-09 Thread Niklas Söderlund
r test. And then tests i do is to increasing the CPU load in order to generate heat and observe the temperature increasing. But 40C seems like a reasonable value during idle compared to other Gen3 SoCs I looked at. -- Regards, Niklas Söderlund

Re: [PATCH V2] PCI: rcar: Clean up the macros

2018-04-08 Thread Niklas Söderlund
about if you should include bitops.h or not. But for the macro changes themselves. Reviewed-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> > --- > V2: Reword the commit message > --- > drivers/pci/host/pcie-rcar.c | 52 > ++-

Re: [PATCH v5 3/3] ARM: dts: r8a7793: Convert to new LVDS DT bindings

2018-04-08 Thread Niklas Söderlund
bridge > driver") > Fixes: bff8f8c2feb7 ("ARM: dts: r8a7793: add soc node") > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> > --- > Changes since v3: >

Re: [PATCH v5 2/3] ARM: dts: r8a7791: Convert to new LVDS DT bindings

2018-04-08 Thread Niklas Söderlund
1-koelsch.dts > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts > @@ -470,8 +470,7 @@ > > clocks = < CPG_MOD 724>, < CPG_MOD 723>, < CPG_MOD 726>, ><_clk>, <_clk>; I think you forgot to delete < CPG_MOD 726> from the clocks, wi

Re: [PATCH v5 1/3] ARM: dts: r8a7790: Convert to new LVDS DT bindings

2018-04-08 Thread Niklas Söderlund
bridge > driver") > Fixes: 4bdb7aa7dcd0 ("ARM: dts: r8a7790: add soc node") > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> > --- > Changes since v3: >

[PATCH] media: entity: fix spelling for media_entity_get_fwnode_pad()

2018-04-08 Thread Niklas Söderlund
From: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> s/dose/does/ Fixes: d295c6a460cd2ac6 ("[media] media: entity: Add media_entity_get_fwnode_pad() function") Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> --- include/media/media-e

Re: [PATCH v13 16/33] rcar-vin: simplify how formats are set and reset

2018-04-05 Thread Niklas Söderlund
On Tuesday, 27 March 2018 00:44:39 EEST Niklas Söderlund wrote: > > With the recent cleanup of the format code to prepare for Gen3 it's > > possible to simplify the Gen2 format code path as well. Clean up the > > process by defining two functions to handle the set format and rese

Re: [PATCH v13 00/33] rcar-vin: Add Gen3 with media controller

2018-04-05 Thread Niklas Söderlund
et this series accepted! > > Regards, > > Hans > > On 03/04/18 14:30, Hans Verkuil wrote: > > On 26/03/18 23:44, Niklas Söderlund wrote: > >> Hi, > >> > >> This series adds Gen3 VIN support to rcar-vin driver for Renesas r8

[PATCH v3] i2c: adv748x: afe: fix sparse warning

2018-03-26 Thread Niklas Söderlund
signedness) Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- * Changes since v2 - Add review tag from Kieran. - Send to correct mail address for linux-media so it shows up in patchwork. * C

[PATCH v13 32/33] rcar-vin: enable support for r8a7796

2018-03-26 Thread Niklas Söderlund
Add the SoC specific information for Renesas r8a7796. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Reviewed-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/platform/rcar-vi

[PATCH v13 24/33] rcar-vin: prepare for media controller mode initialization

2018-03-26 Thread Niklas Söderlund
with a comment. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Hans Verkuil <hans.verk...@cisco.com> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- drivers/media/platform/rcar-vin/rcar-core.c | 20 ++-- drivers/media

[PATCH v13 31/33] rcar-vin: enable support for r8a7795

2018-03-26 Thread Niklas Söderlund
Add the SoC specific information for Renesas r8a7795 ES1.x and ES2.0. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Reviewed-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media

[PATCH v13 29/33] rcar-vin: add link notify for Gen3

2018-03-26 Thread Niklas Söderlund
to hardware constrains the link_notifier callback will return -EMLINK. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Hans Verkuil <hans.verk...@cisco.com> --- * Changes since v11 - Fixed spelling - Updated comment to clarify the intent that

[PATCH v13 02/33] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

2018-03-26 Thread Niklas Söderlund
by: Simon Horman <horms+rene...@verge.net.au> Acked-by: Rob Herring <r...@kernel.org> Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> Acked-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> ---

[PATCH v13 01/33] dt-bindings: media: rcar_vin: Reverse SoC part number list

2018-03-26 Thread Niklas Söderlund
d-by: Simon Horman <horms+rene...@verge.net.au> Acked-by: Rob Herring <r...@kernel.org> Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> Acked-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboar

[PATCH v13 25/33] rcar-vin: add group allocator functions

2018-03-26 Thread Niklas Söderlund
data structure and registers a media device. Consecutive VINs insert themself into the global group. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Reviewed-by: Hans Verkuil <hans.ve

[PATCH v13 06/33] rcar-vin: move subdevice handling to async callbacks

2018-03-26 Thread Niklas Söderlund
are only used on Gen2. While moving this code drop a large comment which is copied from the framework documentation and fold rvin_mbus_supported() into its only caller. Also move the initialization and cleanup code to separate functions to increase readability. Signed-off-by: Niklas Söderlund

[PATCH v13 30/33] rcar-vin: extend {start,stop}_streaming to work with media controller

2018-03-26 Thread Niklas Söderlund
The procedure to start or stop streaming using the non-MC single subdevice and the MC graph and multiple subdevices are quite different. Create a new function to abstract which method is used based on which mode the driver is running in and add logic to start the MC graph. Signed-off-by: Niklas

[PATCH v13 18/33] rcar-vin: move media bus configuration to struct rvin_dev

2018-03-26 Thread Niklas Söderlund
Bus configuration will once the driver is extended to support Gen3 contain information not specific to only the directly connected parallel subdevice. Move it to struct rvin_dev to show it's not always coupled to the parallel subdevice. Signed-off-by: Niklas Söderlund <niklas.soderlund+r

[PATCH v13 33/33] rcar-vin: enable support for r8a77970

2018-03-26 Thread Niklas Söderlund
Add the SoC specific information for Renesas r8a77970. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Reviewed-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/platform/rcar-vi

[PATCH v13 03/33] rcar-vin: add Gen3 devicetree bindings documentation

2018-03-26 Thread Niklas Söderlund
VIN and CSI-2 block. This routing table will be kept inside the driver but in order for it to act on it it must know which VIN and CSI-2 is which. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Acked-by: Rob Herring <r...@kernel.org> Reviewed-by: Laur

[PATCH v13 16/33] rcar-vin: simplify how formats are set and reset

2018-03-26 Thread Niklas Söderlund
rvin_source_fmt with a struct v4l2_rect as all it's used for is keep track of the source dimensions. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Hans Verkuil <hans.verk...@cisco.com> --- * Changes since v11 - This patch where 'rcar-vin: read subd

[PATCH v13 08/33] rcar-vin: move max width and height information to chip information

2018-03-26 Thread Niklas Söderlund
On Gen3 the max supported width and height will be different from Gen2. Move the limits to the struct rvin_info to prepare for Gen3 support. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com&

[PATCH v13 11/33] rcar-vin: set a default field to fallback on

2018-03-26 Thread Niklas Söderlund
If the field is not supported by the driver it should not try to keep the current field. Instead it should set it to a default fallback. Since trying a format should always result in the same state regardless of the current state of the device. Signed-off-by: Niklas Söderlund <niklas.soderl

[PATCH v13 21/33] rcar-vin: add flag to switch to media controller mode

2018-03-26 Thread Niklas Söderlund
to struct rvin_info which will control which mode to use. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Hans Verkuil <hans.verk...@cisco.com> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- drivers/media/platform/rcar-v

[PATCH v13 09/33] rcar-vin: move functions regarding scaling

2018-03-26 Thread Niklas Söderlund
In preparation of refactoring the scaling code move the code regarding scaling to to the top of the file to avoid the need to add forward declarations. No code is changed in this commit only whole functions moved inside the same file. Signed-off-by: Niklas Söderlund <niklas.soderlund+r

[PATCH v13 05/33] rcar-vin: unregister video device on driver removal

2018-03-26 Thread Niklas Söderlund
-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Reviewed-by: Hans Verkuil <hans.verk...@cisco.com> Acked-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- drivers/media/platform/

[PATCH v13 26/33] rcar-vin: change name of video device

2018-03-26 Thread Niklas Söderlund
The rcar-vin driver needs to be part of a media controller to support Gen3. Give each VIN instance a unique name so it can be referenced from userspace. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideason

[PATCH v13 28/33] rcar-vin: parse Gen3 OF and setup media graph

2018-03-26 Thread Niklas Söderlund
in the notifier belonging to the last probed VIN. Once all CSI-2 subdevices in this notifier are bound proceed to register all VIN video devices of the group and crate media device links between all CSI-2 and VIN entities according to the SoC specific routing configuration. Signed-off-by: Niklas

[PATCH v13 20/33] rcar-vin: add function to manipulate Gen3 chsel value

2018-03-26 Thread Niklas Söderlund
-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Reviewed-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/platform/rcar-vin/rcar-dma.c | 38 ++ drivers/media/plat

[PATCH v13 19/33] rcar-vin: enable Gen3 hardware configuration

2018-03-26 Thread Niklas Söderlund
Add the register needed to work with Gen3 hardware. This patch adds the logic for how to work with the Gen3 hardware. More work is required to enable the subdevice structure needed to configure capturing. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by

[PATCH v13 27/33] rcar-vin: add chsel information to rvin_info

2018-03-26 Thread Niklas Söderlund
Each Gen3 SoC has a limited set of predefined routing possibilities for which CSI-2 device and channel can be routed to which VIN instance. Prepare to store this information in the struct rvin_info. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Hans V

[PATCH v13 22/33] rcar-vin: use different v4l2 operations in media controller mode

2018-03-26 Thread Niklas Söderlund
without directly interacting with the source subdevice. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Hans Verkuil <hans.verk...@cisco.com> --- * Changes since v11 - Fixed error labels name in rvin_mc_open(). --- drivers/media/platform/rcar-vi

[PATCH v13 07/33] rcar-vin: move model information to own struct

2018-03-26 Thread Niklas Söderlund
chip_id to model_id. Also sort the compatible string entries and make use of of_device_get_match_data() which will always work as the driver is DT only, so there's always a valid match. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Kieran Bingham <kiera

[PATCH v13 14/33] rcar-vin: align pixelformat check

2018-03-26 Thread Niklas Söderlund
If the pixelformat is not supported it should not fail but be set to something that works. While we are at it move the two different checks of the pixelformat to the same statement. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pi

[PATCH v13 12/33] rcar-vin: fix handling of single field frames (top, bottom and alternate fields)

2018-03-26 Thread Niklas Söderlund
-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Hans Verkuil <hans.verk...@cisco.com> --- * Changes since v12 - Spelling where -> were. - Add review tag from Hans. --- drivers/media/platform/rcar-vin/rcar-dma.c | 15 +-- drivers/media/platform/rcar-

[PATCH v13 17/33] rcar-vin: cache video standard

2018-03-26 Thread Niklas Söderlund
At stream on time the driver should not query the subdevice for which standard are used. Instead it should be cached when userspace sets the standard and used at stream on time. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Hans Verkuil <

[PATCH v13 15/33] rcar-vin: break out format alignment and checking

2018-03-26 Thread Niklas Söderlund
Part of the format alignment and checking can be shared with the Gen3 format handling. Break that part out to a separate function. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/platform/r

[PATCH v13 04/33] rcar-vin: rename poorly named initialize and cleanup functions

2018-03-26 Thread Niklas Söderlund
The functions to register and unregister the hardware and video device where poorly named from the start. Rename them to better describe their intended function. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Kieran Bingham <kieran.bin

[PATCH v13 00/33] rcar-vin: Add Gen3 with media controller

2018-03-26 Thread Niklas Söderlund
n updated version, thanks Sakari for pointing this out. - Add Sakaris Ack to patch 1/32. - Rebase on top of v4.9-rc1 instead of v4.9-rc3 to ease integration testing together with renesas-drivers tree. Fabrizio Castro (2): dt-bindings: media: rcar_vin: Reverse SoC part number list dt-bin

Re: [PATCH 0/6] pinctrl: sh-pfc: rcar-gen3: Rename EtherAVB "mdc" pin group to "mdio"

2018-03-15 Thread Niklas Söderlund
t and admit our mistake, and rename the > pin group from "mdc" to "mdio", like on R-Car Gen2 SoCs. Backwards > compatibility with old DTBs is retained by using a pin group alias. Thanks for fixing this, it frustrated me in the past :-) i like the pin alias so

Re: [PATCH v5 3/3] arm64: dts: renesas: Add LVDS decoder to R-Car V3M Eagle

2018-03-15 Thread Niklas Söderlund
}; > > @@ -152,8 +179,8 @@ > > ports { > port@1 { > - endpoint { > - remote-endpoint = <_in>; > + lvds0_out: endpoint { > + remote-endpoint = <_in_0>; > }; > }; > }; > -- > 2.7.4 > -- Regards, Niklas Söderlund

Re: [PATCH v5 2/3] drm: bridge: Add thc63lvd1024 LVDS decoder driver

2018-03-15 Thread Niklas Söderlund
thc63) > + return -ENOMEM; > + > + thc63->dev = >dev; > + platform_set_drvdata(pdev, thc63); > + > + ret = thc63_regulator_init(thc63); > + if (ret) > + return ret; > + > + ret = thc63_gpio_init(thc63); > +

Re: [PATCH v5 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

2018-03-15 Thread Niklas Söderlund
Hi Jacopo, Thanks for your patch, On 2018-03-15 17:11:54 +0100, Jacopo Mondi wrote: > Document Thine THC63LVD1024 LVDS decoder device tree bindings. > > Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> > Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> Revie

Re: [PATCH 00/20] Add multiplexed media pads to support CSI-2 virtual channels

2018-03-15 Thread Niklas Söderlund
ms would be useful for you? > > Best regards, > Todor Tomov > > On 11.08.2017 12:56, Niklas Söderlund wrote: > > Hi, > > > > This series is a RFC for how I think one could add CSI-2 virtual channel > > support to the V4L2 framework. The problem is tha

Re: [PATCH 1/3] rcar-vin: remove duplicated check of state in irq handler

2018-03-14 Thread Niklas Söderlund
Hi Jacopo, On 2018-03-14 16:17:33 +0100, Jacopo Mondi wrote: > Hi Niklas, Kieran, > > On Tue, Mar 13, 2018 at 06:56:54PM +0100, Niklas Söderlund wrote: > > Hi Kieran, > > > > Thanks for your feedback. > > > > On 2018-03-13 17:42:25 +0100, Kieran Bingham wro

[PATCH v2 0/2] rcar-vin: always run in continues mode

2018-03-13 Thread Niklas Söderlund
situations and no regressions in the vin-tests suite. * Changes since v1 - Dropped first patch in series as it removed a correct check due to my poor reading skills. - Corrected spelling in commit messages and comments. - Added review tags from Jacopo and Kieran, thanks! Niklas Söderlund (2

[PATCH v2 2/2] rcar-vin: use scratch buffer and always run in continuous mode

2018-03-13 Thread Niklas Söderlund
down and run in single mode until the capturing process where restarted. An additional effect of this change is that the capture logic can be made much simple as we know that continuous mode will always be used. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Re

[PATCH v2 1/2] rcar-vin: allocate a scratch buffer at stream start

2018-03-13 Thread Niklas Söderlund
on single capture mode if userspace can't queue buffers as fast as the VIN driver consumes them. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Jacopo Mondi <jacopo+rene...@jmondi.org> Reviewed-by: Kieran Bingham <kieran.bingham+rene...@i

Re: [PATCH 1/3] rcar-vin: remove duplicated check of state in irq handler

2018-03-13 Thread Niklas Söderlund
Hi Kieran, Thanks for your feedback. On 2018-03-13 17:42:25 +0100, Kieran Bingham wrote: > Hi Niklas, > > Thanks for the patch series :) - I've been looking forward to seeing this one > ! > > On 10/03/18 01:09, Niklas Söderlund wrote: > > This is an error from when th

Re: [PATCH 3/3] rcar-vin: use scratch buffer and always run in continuous mode

2018-03-12 Thread Niklas Söderlund
Hi Jacopo, Thanks for your feedback. On 2018-03-12 15:38:12 +0100, Jacopo Mondi wrote: > Hi Niklas, > a few comments below > > On Sat, Mar 10, 2018 at 01:09:53AM +0100, Niklas Söderlund wrote: > > Instead of switching capture mode depending on how many buffers are > >

[PATCH 2/3] rcar-vin: allocate a scratch buffer at stream start

2018-03-09 Thread Niklas Söderlund
on single capture mode if userspace don't queue buffers as fast as the VIN driver consumes them. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> --- drivers/media/platform/rcar-vin/rcar-dma.c | 19 +++ drivers/media/platform/rcar-vin/rcar-vin.h | 4 2

[PATCH 0/3] rcar-vin: always run in continues mode

2018-03-09 Thread Niklas Söderlund
patches have been tested with great improvement in capture speed for buffer strained situations and no regressions in the vin-tests suite. Niklas Söderlund (3): rcar-vin: remove duplicated check of state in irq handler rcar-vin: allocate a scratch buffer at stream start rcar-vin: use scratch

[PATCH 3/3] rcar-vin: use scratch buffer and always run in continuous mode

2018-03-09 Thread Niklas Söderlund
down and run in single mode until the capturing process where restarted. An additional effect of this change is that the capture logic can be made much simple as we know that continues mode will always be used. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> --- drivers

[PATCH 1/3] rcar-vin: remove duplicated check of state in irq handler

2018-03-09 Thread Niklas Söderlund
This is an error from when the driver where converted from soc-camera. There is absolutely no gain to check the state variable two times to be extra sure if the hardware is stopped. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> --- drivers/media/platform/rcar-vi

Re: [PATCH 1/4] pinctrl: sh-pfc: r8a7796: Add VIN4, VIN5 pins, groups and functions

2018-03-09 Thread Niklas Söderlund
Hi Geert, On 2018-03-09 23:24:37 +0100, Geert Uytterhoeven wrote: > Hi Niklas, > > On Fri, Mar 9, 2018 at 10:58 PM, Niklas Söderlund > <niklas.soderl...@ragnatech.se> wrote: > > On 2018-03-09 13:33:03 +0100, Geert Uytterhoeven wrote: > >> P.S. Apparently R-Car

Re: [PATCH] arm64: dts: renesas: r8a7795: Add missing SYS-DMAC2 dmas

2018-03-09 Thread Niklas Söderlund
en <geert+rene...@glider.be> Reviewed-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> > --- > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 45 > +++- > 1 file changed, 27 insertions(+), 18 deletions(-) > > diff --git a/arch/arm64/boot/

Re: [PATCH 1/4] pinctrl: sh-pfc: r8a7796: Add VIN4, VIN5 pins, groups and functions

2018-03-09 Thread Niklas Söderlund
Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > ge...@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds -- Regards, Niklas Söderlund

Re: [PATCH v12 11/33] rcar-vin: set a default field to fallback on

2018-03-09 Thread Niklas Söderlund
Hi Hans, Thanks for your feedback. On 2018-03-09 17:28:39 +0100, Hans Verkuil wrote: > On 09/03/18 17:17, Niklas Söderlund wrote: > > Hi Hans, > > > > Thanks for your feedback, I don't think I can appreciate how happy I'm > > that you reviewed this patch-set, Tha

Re: [PATCH v12 11/33] rcar-vin: set a default field to fallback on

2018-03-09 Thread Niklas Söderlund
Hi Hans, Thanks for your feedback, I don't think I can appreciate how happy I'm that you reviewed this patch-set, Thank you! On 2018-03-09 16:25:23 +0100, Hans Verkuil wrote: > On 07/03/18 23:04, Niklas Söderlund wrote: > > If the field is not supported by the driver it should not tr

Re: [PATCH] dt-bindings: media: rcar_vin: Use status "okay"

2018-03-09 Thread Niklas Söderlund
rhoeven <geert+rene...@glider.be> Reviewed-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> > --- > For the checkpatch TODO list? > https://www.devicetree.org/ > > Documentation/devicetree/bindings/media/rcar_vin.txt | 4 ++-- > 1 file changed, 2

Re: [PATCH v2] i2c: adv748x: afe: fix sparse warning

2018-03-07 Thread Niklas Söderlund
CC linux-media. It's linux-me...@vger.kernel.org not linux-me...@vger.kernel.or, sorry for the noise. On 2018-03-07 23:58:16 +0100, Niklas Söderlund wrote: > This fixes the following sparse warning: > > drivers/media/i2c/adv748x/adv748x-afe.c:294:34:expected unsigned int &g

Re: [PATCH v2] i2c: adv748x: afe: fix sparse warning

2018-03-07 Thread Niklas Söderlund
CC linux-media. It's linux-me...@vger.kernel.org not linux-me...@vger.kernel.or, sorry for the noise. On 2018-03-07 23:58:16 +0100, Niklas Söderlund wrote: > This fixes the following sparse warning: > > drivers/media/i2c/adv748x/adv748x-afe.c:294:34:expected unsigned int &g

[PATCH v2] i2c: adv748x: afe: fix sparse warning

2018-03-07 Thread Niklas Söderlund
signedness) Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> --- * Changes since v1 - Use u32 instead of unsigned int as suggested by Geert. --- drivers/media/i2c/adv748x/adv748x-afe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/med

[PATCH v12 10/33] rcar-vin: all Gen2 boards can scale simplify logic

2018-03-07 Thread Niklas Söderlund
the field is preserved simplifies the logic quite a bit. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Hans Verkuil <hans.verk...@cisco.com> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- drivers/media/platform/rcar-vi

[PATCH v12 13/33] rcar-vin: update bytesperline and sizeimage calculation

2018-03-07 Thread Niklas Söderlund
Remove over complicated logic to calculate the value for bytesperline and sizeimage that was carried over from the soc_camera port. There is no need to find the max value of bytesperline and sizeimage from user-space as they are set to 0 before the max_t() operation. Signed-off-by: Niklas

[PATCH v12 01/33] dt-bindings: media: rcar_vin: Reverse SoC part number list

2018-03-07 Thread Niklas Söderlund
d-by: Simon Horman <horms+rene...@verge.net.au> Acked-by: Rob Herring <r...@kernel.org> Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> Acked-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboar

[PATCH v12 27/33] rcar-vin: add chsel information to rvin_info

2018-03-07 Thread Niklas Söderlund
Each Gen3 SoC has a limited set of predefined routing possibilities for which CSI-2 device and channel can be routed to which VIN instance. Prepare to store this information in the struct rvin_info. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> --- * Changes sin

[PATCH v12 22/33] rcar-vin: use different v4l2 operations in media controller mode

2018-03-07 Thread Niklas Söderlund
without directly interacting with the source subdevice. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Hans Verkuil <hans.verk...@cisco.com> --- * Changes since v11 - Fixed error labels name in rvin_mc_open(). --- drivers/media/platform/rcar-vi

[PATCH v12 19/33] rcar-vin: enable Gen3 hardware configuration

2018-03-07 Thread Niklas Söderlund
Add the register needed to work with Gen3 hardware. This patch adds the logic for how to work with the Gen3 hardware. More work is required to enable the subdevice structure needed to configure capturing. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by

[PATCH v12 20/33] rcar-vin: add function to manipulate Gen3 chsel value

2018-03-07 Thread Niklas Söderlund
-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- drivers/media/platform/rcar-vin/rcar-dma.c | 38 ++ drivers/media/platform/rcar-vin/rcar-vin.h | 2 ++ 2 files changed, 4

[PATCH v12 21/33] rcar-vin: add flag to switch to media controller mode

2018-03-07 Thread Niklas Söderlund
to struct rvin_info which will control which mode to use. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Hans Verkuil <hans.verk...@cisco.com> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- drivers/media/platform/rcar-v

[PATCH v12 16/33] rcar-vin: simplify how formats are set and reset

2018-03-07 Thread Niklas Söderlund
rvin_source_fmt with a struct v4l2_rect as all it's used for is keep track of the source dimensions. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> --- * Changes since v11 - This patch where 'rcar-vin: read subdevice format for crop only when needed' - Keep caching the

[PATCH v12 14/33] rcar-vin: align pixelformat check

2018-03-07 Thread Niklas Söderlund
If the pixelformat is not supported it should not fail but be set to something that works. While we are at it move the two different checks of the pixelformat to the same statement. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pi

[PATCH v12 18/33] rcar-vin: move media bus configuration to struct rvin_dev

2018-03-07 Thread Niklas Söderlund
Bus configuration will once the driver is extended to support Gen3 contain information not specific to only the directly connected parallel subdevice. Move it to struct rvin_dev to show it's not always coupled to the parallel subdevice. Signed-off-by: Niklas Söderlund <niklas.soderlund+r

[PATCH v12 00/33] rcar-vin: Add Gen3 with media controller

2018-03-07 Thread Niklas Söderlund
ut. - Add Sakaris Ack to patch 1/32. - Rebase on top of v4.9-rc1 instead of v4.9-rc3 to ease integration testing together with renesas-drivers tree. Fabrizio Castro (2): dt-bindings: media: rcar_vin: Reverse SoC part number list dt-bindings: media: rcar_vin: add device tree support for r8a77

[PATCH v12 31/33] rcar-vin: enable support for r8a7795

2018-03-07 Thread Niklas Söderlund
Add the SoC specific information for Renesas r8a7795 ES1.x and ES2.0. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- drivers/media/platform/rcar-vin/Kconfig | 2 +- drivers/media/p

[PATCH v12 28/33] rcar-vin: parse Gen3 OF and setup media graph

2018-03-07 Thread Niklas Söderlund
in the notifier belonging to the last probed VIN. Once all CSI-2 subdevices in this notifier are bound proceed to register all VIN video devices of the group and crate media device links between all CSI-2 and VIN entities according to the SoC specific routing configuration. Signed-off-by: Niklas

[PATCH v12 17/33] rcar-vin: cache video standard

2018-03-07 Thread Niklas Söderlund
At stream on time the driver should not query the subdevice for which standard are used. Instead it should be cached when userspace sets the standard and used at stream on time. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> --- drivers/media/platform/rcar-vi

[PATCH v12 26/33] rcar-vin: change name of video device

2018-03-07 Thread Niklas Söderlund
The rcar-vin driver needs to be part of a media controller to support Gen3. Give each VIN instance a unique name so it can be referenced from userspace. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideason

[PATCH v12 04/33] rcar-vin: rename poorly named initialize and cleanup functions

2018-03-07 Thread Niklas Söderlund
The functions to register and unregister the hardware and video device where poorly named from the start. Rename them to better describe their intended function. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Kieran Bingham <kieran.bin

[PATCH v12 15/33] rcar-vin: break out format alignment and checking

2018-03-07 Thread Niklas Söderlund
Part of the format alignment and checking can be shared with the Gen3 format handling. Break that part out to a separate function. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 85 -

[PATCH v12 33/33] rcar-vin: enable support for r8a77970

2018-03-07 Thread Niklas Söderlund
Add the SoC specific information for Renesas r8a77970. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- drivers/media/platform/rcar-vin/rcar-core.c | 23 +++ 1 file

[PATCH v12 24/33] rcar-vin: prepare for media controller mode initialization

2018-03-07 Thread Niklas Söderlund
with a comment. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Hans Verkuil <hans.verk...@cisco.com> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- drivers/media/platform/rcar-vin/rcar-core.c | 20 ++-- drivers/media

[PATCH v12 25/33] rcar-vin: add group allocator functions

2018-03-07 Thread Niklas Söderlund
data structure and registers a media device. Consecutive VINs insert themself into the global group. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- drivers/media/platform/rcar-vin/rcar-

[PATCH v12 32/33] rcar-vin: enable support for r8a7796

2018-03-07 Thread Niklas Söderlund
Add the SoC specific information for Renesas r8a7796. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- drivers/media/platform/rcar-vin/rcar-core.c | 44 + 1 file

[PATCH v12 29/33] rcar-vin: add link notify for Gen3

2018-03-07 Thread Niklas Söderlund
to hardware constrains the link_notifier callback will return -EMLINK. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> --- * Changes since v11 - Fixed spelling - Updated comment to clarify the intent that no link can be enabled if any video node is open. - Use contai

[PATCH v12 30/33] rcar-vin: extend {start,stop}_streaming to work with media controller

2018-03-07 Thread Niklas Söderlund
The procedure to start or stop streaming using the non-MC single subdevice and the MC graph and multiple subdevices are quite different. Create a new function to abstract which method is used based on which mode the driver is running in and add logic to start the MC graph. Signed-off-by: Niklas

[PATCH v12 12/33] rcar-vin: fix handling of single field frames (top, bottom and alternate fields)

2018-03-07 Thread Niklas Söderlund
-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> --- drivers/media/platform/rcar-vin/rcar-dma.c | 15 +-- drivers/media/platform/rcar-vin/rcar-v4l2.c | 40 +++-- 2 files changed, 10 insertions(+), 45 deletions(-) diff --git a/drivers/media/platform/rc

[PATCH v12 11/33] rcar-vin: set a default field to fallback on

2018-03-07 Thread Niklas Söderlund
If the field is not supported by the driver it should not try to keep the current field. Instead it should set it to a default fallback. Since trying a format should always result in the same state regardless of the current state of the device. Signed-off-by: Niklas Söderlund <niklas.soderl

[PATCH v12 09/33] rcar-vin: move functions regarding scaling

2018-03-07 Thread Niklas Söderlund
In preparation of refactoring the scaling code move the code regarding scaling to to the top of the file to avoid the need to add forward declarations. No code is changed in this commit only whole functions moved inside the same file. Signed-off-by: Niklas Söderlund <niklas.soderlund+r

[PATCH v12 23/33] rcar-vin: force default colorspace for media centric mode

2018-03-07 Thread Niklas Söderlund
values. Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c b/drivers/media/platform/rc

<    1   2   3   4   5   6   7   8   9   10   >