struct
rvin_info which will control which mode to use.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/rcar-core.c | 6 +-
drivers/media/platform/rcar-vin/rcar-vin.h | 2 ++
2 files changed, 7 insertions(+), 1
truct rvin_source_fmt with a
struct v4l2_rect as all it's used for is keep track of the source
dimensions.
Signed-off-by: Niklas Söderlund
---
* Changes since v11
- This patch where 'rcar-vin: read subdevice format for crop only when
needed'
- Keep caching the source dimensions and
If the pixelformat is not supported it should not fail but be set to
something that works. While we are at it move the two different
checks of the pixelformat to the same statement.
Signed-off-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/rcar-v4l2.c
Bus configuration will once the driver is extended to support Gen3
contain information not specific to only the directly connected parallel
subdevice. Move it to struct rvin_dev to show it's not always coupled
to the parallel subdevice.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Ve
-by: Niklas Söderlund
Reviewed-by: Kieran Bingham
Reviewed-by: Hans Verkuil
Acked-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/rcar-core.c | 2 ++
drivers/media/platform/rcar-vin/rcar-v4l2.c | 3 +++
2 files changed, 5 insertions(+)
diff --git a/drivers/media/platform/rcar-vin/rcar
elling and DT documentation as pointed out by Geert and Sergei,
thanks!
- Refresh patch 2/32 with an updated version, thanks Sakari for pointing
this out.
- Add Sakaris Ack to patch 1/32.
- Rebase on top of v4.9-rc1 instead of v4.9-rc3 to ease integration
testing together with renesas-drivers
Add the SoC specific information for Renesas r8a7795 ES1.x and ES2.0.
Signed-off-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/Kconfig | 2 +-
drivers/media/platform/rcar-vin/rcar-core.c | 120
2 files changed, 121
the notifier belonging to the last probed VIN.
Once all CSI-2 subdevices in this notifier are bound proceed to register
all VIN video devices of the group and crate media device links between
all CSI-2 and VIN entities according to the SoC specific routing
configuration.
Signed-off-by: Niklas
At stream on time the driver should not query the subdevice for which
standard are used. Instead it should be cached when userspace sets the
standard and used at stream on time.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-core.c | 6 ++
drivers/media/platform
The rcar-vin driver needs to be part of a media controller to support
Gen3. Give each VIN instance a unique name so it can be referenced from
userspace.
Signed-off-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/rcar-v4l2.c | 2 +-
1 file changed, 1
The functions to register and unregister the hardware and video device
where poorly named from the start. Rename them to better describe their
intended function.
Signed-off-by: Niklas Söderlund
Reviewed-by: Kieran Bingham
Reviewed-by: Hans Verkuil
Reviewed-by: Laurent Pinchart
---
drivers
Part of the format alignment and checking can be shared with the Gen3
format handling. Break that part out to a separate function.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-v4l2.c | 85 -
1 file changed, 48 insertions(+), 37 deletions
Add the SoC specific information for Renesas r8a77970.
Signed-off-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/rcar-core.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/drivers/media/platform/rcar-vin/rcar-core.c
b
Add the SoC specific information for Renesas r8a7796.
Signed-off-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/rcar-core.c | 44 +
1 file changed, 44 insertions(+)
diff --git a/drivers/media/platform/rcar-vin/rcar-core.c
b
le a new link
due to hardware constrains the link_notifier callback will return
-EMLINK.
Signed-off-by: Niklas Söderlund
---
* Changes since v11
- Fixed spelling
- Updated comment to clarify the intent that no link can be enabled if
any video node is open.
- Use container_of() instead of a loop to
comment.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/rcar-core.c | 20 ++--
drivers/media/platform/rcar-vin/rcar-vin.h | 4
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/drivers
data structure and registers a media device.
Consecutive VINs insert themself into the global group.
Signed-off-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/rcar-core.c | 174 +++-
drivers/media/platform/rcar-vin/rcar-vin.h | 31
The procedure to start or stop streaming using the non-MC single
subdevice and the MC graph and multiple subdevices are quite different.
Create a new function to abstract which method is used based on which
mode the driver is running in and add logic to start the MC graph.
Signed-off-by: Niklas
: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-dma.c | 15 +--
drivers/media/platform/rcar-vin/rcar-v4l2.c | 40 +++--
2 files changed, 10 insertions(+), 45 deletions(-)
diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c
b/drivers/media/platform
fixed values.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-v4l2.c | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c
b/drivers/media/platform/rcar-vin/rcar-v4l2.c
index 2280535ca98
If the field is not supported by the driver it should not try to keep
the current field. Instead it should set it to a default fallback. Since
trying a format should always result in the same state regardless of the
current state of the device.
Signed-off-by: Niklas Söderlund
Reviewed-by
In preparation of refactoring the scaling code move the code regarding
scaling to to the top of the file to avoid the need to add forward
declarations. No code is changed in this commit only whole functions
moved inside the same file.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
On Gen3 the max supported width and height will be different from Gen2.
Move the limits to the struct rvin_info to prepare for Gen3 support.
Signed-off-by: Niklas Söderlund
Reviewed-by: Kieran Bingham
Reviewed-by: Hans Verkuil
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin
if
needed, in addition to document SoC support and therefore allow
checkpatch.pl to validate compatible string values.
Signed-off-by: Fabrizio Castro
Reviewed-by: Biju Das
Reviewed-by: Simon Horman
Acked-by: Rob Herring
Reviewed-by: Geert Uytterhoeven
Acked-by: Niklas Söderlund
Reviewed-b
tween each VIN and CSI-2 block. This routing table will be kept
inside the driver but in order for it to act on it it must know which
VIN and CSI-2 is which.
Signed-off-by: Niklas Söderlund
Acked-by: Rob Herring
Reviewed-by: Laurent Pinchart
---
.../devicetree/bindings/media/rcar_vin.txt
chip_id to model_id. Also sort the compatible
string entries and make use of of_device_get_match_data() which will
always work as the driver is DT only, so there's always a valid match.
Signed-off-by: Niklas Söderlund
Reviewed-by: Kieran Bingham
Reviewed-by: Hans Verkuil
Reviewed-by: Laurent Pin
only used on Gen2.
While moving this code drop a large comment which is copied from the
framework documentation and fold rvin_mbus_supported() into its only
caller. Also move the initialization and cleanup code to separate
functions to increase readability.
Signed-off-by: Niklas Söderlund
Reviewed
ned-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/ravb_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/renesas/ravb_main.c
b/drivers/net/ethernet/renesas/ravb_main.c
index 54a6265da7a06460..68f122140966d4de 100644
--- a/drivers/net/ethernet/renesas/ravb_ma
Hi Laurent,
Thanks for your feedback.
On 2018-03-02 13:06:27 +0200, Laurent Pinchart wrote:
> Hi Niklas,
>
> Thank you for the patch.
>
> On Friday, 2 March 2018 03:57:35 EET Niklas Söderlund wrote:
> > Instead of caching the subdevice format each time the video device
&
Hi Laurent,
Thanks for your comments.
On 2018-03-02 12:48:55 +0200, Laurent Pinchart wrote:
> Hi Niklas,
>
> Thank you for the patch.
>
> On Friday, 2 March 2018 03:57:31 EET Niklas Söderlund wrote:
> > There was never proper support in the VIN driver to deliver ALTERNATIN
Hi Laurent,
Thanks for your feedback.
On 2018-03-02 11:53:54 +0200, Laurent Pinchart wrote:
> Hi Niklas,
>
> Thank you for the patch.
>
> On Friday, 2 March 2018 03:57:34 EET Niklas Söderlund wrote:
> > Part of the format alignment and checking can be shared with the Gen
;vdev == vdev) {
> > + vin = group->vin[i];
> > + master_id = rvin_group_id_to_master(vin->id);
> > + break;
> > + }
> > + }
[snip]
--
Regards,
Niklas Söderlund
Hi Laurent,
Thanks for your feedback.
On 2018-03-02 11:59:14 +0200, Laurent Pinchart wrote:
> Hi Niklas,
>
> Thank you for the patch.
>
> On Friday, 2 March 2018 03:57:41 EET Niklas Söderlund wrote:
> > When the VIN driver is running in media centric mode (on Gen3) the
Hi Laurent,
Thank you for your feedback.
On 2018-03-02 13:31:47 +0200, Laurent Pinchart wrote:
> Hi Niklas,
>
> Thank you for the patch.
>
> On Friday, 2 March 2018 03:57:38 EET Niklas Söderlund wrote:
> > On Gen3 the CSI-2 routing is controlled by the VnCSI_IFMD registe
Hi Laurent,
Thanks for your feedback.
On 2018-03-02 13:26:58 +0200, Laurent Pinchart wrote:
> Hi Niklas,
>
> Thank you for the patch.
>
> On Friday, 2 March 2018 03:57:36 EET Niklas Söderlund wrote:
> > Bus configuration will once the driver is extended to support Gen3
&g
The functions to register and unregister the hardware and video device
where poorly named from the start. Rename them to better describe their
intended function.
Signed-off-by: Niklas Söderlund
Reviewed-by: Kieran Bingham
Reviewed-by: Hans Verkuil
Reviewed-by: Laurent Pinchart
---
drivers
: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-dma.c | 15 +--
drivers/media/platform/rcar-vin/rcar-v4l2.c | 40 +++--
2 files changed, 10 insertions(+), 45 deletions(-)
diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c
b/drivers/media/platform
Remove over complicated logic to calculate the value for bytesperline
and sizeimage that was carried over from the soc_camera port. There is
no need to find the max value of bytesperline and sizeimage from
user-space as they are set to 0 before the max_t() operation.
Signed-off-by: Niklas
Part of the format alignment and checking can be shared with the Gen3
format handling. Break that part out to a separate function.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-v4l2.c | 96 -
1 file changed, 54 insertions(+), 42 deletions
Add the register needed to work with Gen3 hardware. This patch adds
the logic for how to work with the Gen3 hardware. More work is required
to enable the subdevice structure needed to configure capturing.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Reviewed-by: Laurent Pinchart
chip_id to model_id. Also sort the compatible
string entries and make use of of_device_get_match_data() which will
always work as the driver is DT only, so there's always a valid match.
Signed-off-by: Niklas Söderlund
Reviewed-by: Kieran Bingham
Reviewed-by: Hans Verkuil
Reviewed-by: Laurent Pin
the field is preserved simplifies the logic quite a
bit.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/rcar-dma.c | 8
drivers/media/platform/rcar-vin/rcar-v4l2.c | 25 +++--
drivers
In preparation of refactoring the scaling code move the code regarding
scaling to to the top of the file to avoid the need to add forward
declarations. No code is changed in this commit only whole functions
moved inside the same file.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
On Gen3 the max supported width and height will be different from Gen2.
Move the limits to the struct rvin_info to prepare for Gen3 support.
Signed-off-by: Niklas Söderlund
Reviewed-by: Kieran Bingham
Reviewed-by: Hans Verkuil
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin
tween each VIN and CSI-2 block. This routing table will be kept
inside the driver but in order for it to act on it it must know which
VIN and CSI-2 is which.
Signed-off-by: Niklas Söderlund
Acked-by: Rob Herring
Reviewed-by: Laurent Pinchart
---
.../devicetree/bindings/media/rcar_vin.txt
If the field is not supported by the driver it should not try to keep
the current field. Instead it should set it to a default fallback. Since
trying a format should always result in the same state regardless of the
current state of the device.
Signed-off-by: Niklas Söderlund
---
drivers/media
only used on Gen2.
While moving this code drop a large comment which is copied from the
framework documentation and fold rvin_mbus_supported() into its only
caller. Also move the initialization and cleanup code to separate
functions to increase readability.
Signed-off-by: Niklas Söderlund
Reviewed
-by: Niklas Söderlund
Reviewed-by: Kieran Bingham
Reviewed-by: Hans Verkuil
Acked-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/rcar-core.c | 2 ++
drivers/media/platform/rcar-vin/rcar-v4l2.c | 3 +++
2 files changed, 5 insertions(+)
diff --git a/drivers/media/platform/rcar-vin/rcar
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-dma.c | 38 ++
drivers/media/platform/rcar-vin/rcar-vin.h | 2 ++
2 files changed, 40 insertions(+)
diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c
b/drivers/media/platform/rcar-vin/rcar-d
data structure and registers a media device.
Consecutive VINs insert themself into the global group.
Signed-off-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/rcar-core.c | 174 +++-
drivers/media/platform/rcar-vin/rcar-vin.h | 31
The rcar-vin driver needs to be part of a media controller to support
Gen3. Give each VIN instance a unique name so it can be referenced from
userspace.
Signed-off-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/rcar-v4l2.c | 2 +-
1 file changed, 1
comment.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/rcar-core.c | 20 ++--
drivers/media/platform/rcar-vin/rcar-vin.h | 4
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/drivers
Each Gen3 SoC has a limited set of predefined routing possibilities for
which CSI-2 device and channel can be routed to which VIN instance.
Prepare to store this information in the struct rvin_info.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-vin.h | 42
Add the SoC specific information for Renesas r8a7796.
Signed-off-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/rcar-core.c | 44 +
1 file changed, 44 insertions(+)
diff --git a/drivers/media/platform/rcar-vin/rcar-core.c
b
the notifier belonging to the last probed VIN.
Once all CSI-2 subdevices in this notifier are bound proceed to register
all VIN video devices of the group and crate media device links between
all CSI-2 and VIN entities according to the SoC specific routing
configuration.
Signed-off-by: Niklas
struct
rvin_info which will control which mode to use.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/rcar-core.c | 6 +-
drivers/media/platform/rcar-vin/rcar-vin.h | 2 ++
2 files changed, 7 insertions(+), 1
le a new link
due to hardware constrains the link_notifier callback will return
-EMLINK.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-core.c | 153
1 file changed, 153 insertions(+)
diff --git a/drivers/media/platform/rcar-vin/rcar-cor
Add the SoC specific information for Renesas r8a77970.
Signed-off-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/rcar-core.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/drivers/media/platform/rcar-vin/rcar-core.c
b
The procedure to start or stop streaming using the non-MC single
subdevice and the MC graph and multiple subdevices are quite different.
Create a new function to abstract which method is used based on which
mode the driver is running in and add logic to start the MC graph.
Signed-off-by: Niklas
Add the SoC specific information for Renesas r8a7795 ES1.x and ES2.0.
Signed-off-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/Kconfig | 2 +-
drivers/media/platform/rcar-vin/rcar-core.c | 120
2 files changed, 121
without directly
interacting with the source subdevice.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
---
drivers/media/platform/rcar-vin/rcar-dma.c | 3 +-
drivers/media/platform/rcar-vin/rcar-v4l2.c | 161 +++-
2 files changed, 160 insertions(+), 4
igned-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-v4l2.c | 158 ++--
drivers/media/platform/rcar-vin/rcar-vin.h | 12 ---
2 files changed, 80 insertions(+), 90 deletions(-)
diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c
b/drivers/
validation tools fail. Until the user requested
colorspace can be validated lets force it to the driver default.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-v4l2.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/media
If the pixelformat is not supported it should not fail but be set to
something that works. While we are at it move the two different
checks of the pixelformat to the same statement.
Signed-off-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/rcar-vin/rcar-v4l2.c
Bus configuration will once the driver is extended to support Gen3
contain information not specific to only the directly connected parallel
subdevice. Move it to struct rvin_dev to show it's not always coupled
to the parallel subdevice.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Ve
if
needed, in addition to document SoC support and therefore allow
checkpatch.pl to validate compatible string values.
Signed-off-by: Fabrizio Castro
Reviewed-by: Biju Das
Reviewed-by: Simon Horman
Acked-by: Rob Herring
Reviewed-by: Geert Uytterhoeven
Acked-by: Niklas Söderlund
---
Doc
h patch 2/32 with an updated version, thanks Sakari for pointing
this out.
- Add Sakaris Ack to patch 1/32.
- Rebase on top of v4.9-rc1 instead of v4.9-rc3 to ease integration
testing together with renesas-drivers tree.
Fabrizio Castro (2):
dt-bindings: media: rcar_vin: Reverse SoC part number
From: Fabrizio Castro
Change the sorting of the part numbers from descending to ascending to
match with other documentation.
Signed-off-by: Fabrizio Castro
Reviewed-by: Biju Das
Reviewed-by: Simon Horman
Acked-by: Rob Herring
Reviewed-by: Geert Uytterhoeven
Acked-by: Niklas Söderlund
t, "remote-endpoint",
> + &value[i], sizeof(value[i]));
> + of_node_put(endpoint);
> + if (ret < 0)
> + goto done;
> + }
> +
> + ret = of_changeset_apply(&rcar_du_l
bus.
>
> Allow a device tree node to override the default addresses so that
> address conflicts with other devices on the same bus may be resolved at
> the board description level.
>
> Signed-off-by: Kieran Bingham
Reviewed-by: Niklas Söderlund
> ---
> driver
epresented on a single line.
>
> Define ADV748X_REGMAP_CONF for this purpose use it to create the tables.
>
> Signed-off-by: Kieran Bingham
Reviewed-by: Niklas Söderlund
>
> ---
> v2:
> - Remove unnecessary #undef
>
> drivers/media/i2c/adv748x/adv748x-core.c | 109
: "BRS";
> -
> /* Prepare the display list. */
> dl = vsp1_dl_list_get(pipe->output->dlm);
>
> @@ -570,7 +565,7 @@ void vsp1_du_atomic_flush(struct device *dev, unsigned
> int pipe_index)
> rpf->entity.sink_pad = i;
>
> dev_dbg(vsp1->dev, "%s: connecting RPF.%u to %s:%u\n",
> - __func__, rpf->entity.index, bru_name, i);
> + __func__, rpf->entity.index, BRU_NAME(pipe->bru), i);
>
> ret = vsp1_du_setup_rpf_pipe(vsp1, pipe, rpf, i);
> if (ret < 0)
> --
> Regards,
>
> Laurent Pinchart
>
--
Regards,
Niklas Söderlund
tasheets and what the code looked before feel
free to add.
Reviewed-by: Niklas Söderlund
> ---
> Changes since v1:
>
> - Update the SPDX headers to use GPL-2.0 instead of GPL-2.0-only
> - Update to the -lvds compatible string format
> ---
> drivers/gpu/drm/rcar-du/Kconfi
) ES2.0 DU
> clocks = <&cpg CPG_MOD 724>,
><&cpg CPG_MOD 723>,
><&cpg CPG_MOD 722>,
> - <&cpg CPG_MOD 721>,
> - <&cpg CPG_MOD 727>;
> - clock-names = "du.0", "du.1", "du.2", "du.3", "lvds.0";
> + <&cpg CPG_MOD 721>;
> + clock-names = "du.0", "du.1", "du.2", "du.3";
> vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>;
>
> ports {
> --
> Regards,
>
> Laurent Pinchart
>
--
Regards,
Niklas Söderlund
sas,r8a7743-lvds" for R8A7743 (RZ/G1M) compatible LVDS encoders
> + - "renesas,r8a7790-lvds" for R8A7790 (R-Car H2) compatible LVDS encoders
> + - "renesas,r8a7791-lvds" for R8A7791 (R-Car M2-W) compatible LVDS encoders
> + - "renesas,r8a7793-lvds" for R8
/0x140
[ 89.611010] vfs_read+0x90/0x170
[ 89.614269] SyS_read+0x60/0xd8
[ 89.617443] __sys_trace_return+0x0/0x4
[ 89.621314] ---[ end trace 99c8d0d39c13e794 ]---
Fixes: 82d2de5a4f646f72 ("pinctrl: sh-pfc: r8a7795: Add GP-1-28 port pin
support")
Signed-off-by: Niklas
signedness)
Signed-off-by: Niklas Söderlund
---
drivers/media/i2c/adv748x/adv748x-afe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/adv748x/adv748x-afe.c
b/drivers/media/i2c/adv748x/adv748x-afe.c
index 5188178588c9067d..39a9996d0db08c31 100644
--- a
ing
able to validate input from user-space. But I'm even less excited about
breaking v4l2-compliance compatibility so any path I can take here to
keep the user being able to specify the colorspace and v4l2-compliance
being happy would be a better solution for me :-)
1. https://patchwork.linuxtv.org/patch/46717/
2. 432d9ebfcea65337 ("v4l2-compliance: ignore colorspace tests for passthu
subdevs")
--
Regards,
Niklas Söderlund
Allow for changing the MTU within the limit of the maximum size of a
descriptor (2048 bytes). Add the callback to change MTU from user-space
and take the configurable MTU into account when configuring the
hardware.
Signed-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/ravb.h
Hi Sergei,
Thanks for your feedback.
On 2018-02-14 14:34:09 +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 02/13/2018 04:12 PM, Niklas Söderlund wrote:
>
> >> On 02/12/2018 11:00 PM, Niklas Söderlund wrote:
> >>
> >>> Allow for chancing the MTU
There is no way for drivers to validate a colorspace value, which could
be provided by user-space by VIDIOC_S_FMT for example. Add a helper to
validate that the colorspace value is part of enum v4l2_colorspace.
Signed-off-by: Niklas Söderlund
---
include/uapi/linux/videodev2.h | 4
1 file
Hi Laurent,
On 2018-02-14 00:31:21 +0200, Laurent Pinchart wrote:
> Hi Niklas,
>
> On Tuesday, 13 February 2018 18:47:04 EET Niklas Söderlund wrote:
> > On 2018-02-13 18:26:34 +0200, Laurent Pinchart wrote:
> > > On Monday, 29 January 2018 18:34:15 EET Niklas Söderlund
There is no way for drivers to validate a colorspace value, which could
be provided by user-space by VIDIOC_S_FMT for example. Add a helper to
validate that the colorspace value is part of enum v4l2_colorspace.
Signed-off-by: Niklas Söderlund
---
include/uapi/linux/videodev2.h | 5 +
1 file
Hi Laurent,
On 2018-02-13 19:02:38 +0200, Laurent Pinchart wrote:
> Hi Niklas,
>
> On Tuesday, 13 February 2018 18:58:09 EET Niklas Söderlund wrote:
> > On 2018-02-13 18:41:33 +0200, Laurent Pinchart wrote:
> > > On Monday, 29 January 2018 18:34:18 EET Niklas Söderlund wr
Hi Laurent,
On 2018-02-13 18:41:33 +0200, Laurent Pinchart wrote:
> Hi Niklas,
>
> Thank you for the patch.
>
> On Monday, 29 January 2018 18:34:18 EET Niklas Söderlund wrote:
> > On Gen3 the CSI-2 routing is controlled by the VnCSI_IFMD register. One
> > feature of
Hi Laurent,
On 2018-02-13 18:26:34 +0200, Laurent Pinchart wrote:
> Hi Niklas,
>
> Thank you for the patch.
Thanks for your comments.
>
> On Monday, 29 January 2018 18:34:15 EET Niklas Söderlund wrote:
> > There was never proper support in the VIN driver to deliver
gt;
> Fixes: c5aa87977626e778 ("ARM: dts: lager: Add CEC clock for HDMI
> transmitter")
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
> ---
> arch/arm/boot/dts/r8a7790-lager.dts | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
Hi Sergei,
Thanks for your feedback.
On 2018-02-13 13:01:04 +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 02/12/2018 11:00 PM, Niklas Söderlund wrote:
>
> > Allow for chancing the MTU within the limit of the maximum size of a
>
>Changing. :-)
Yes :-)
>
>
-by: Niklas Söderlund
Acked-by: Rob Herring
Acked-by: Sakari Ailus
---
.../bindings/media/renesas,rcar-csi2.txt | 99 ++
MAINTAINERS| 1 +
2 files changed, 100 insertions(+)
create mode 100644
Documentation/devicetree
priv->pads[i].flags = MEDIA_PAD_FL_SOURCE;
+
+ ret = media_entity_pads_init(&priv->subdev.entity, NR_OF_RCAR_CSI2_PAD,
+priv->pads);
+ if (ret)
+ goto error;
+
+ pm_runtime_enable(&pdev->dev);
+
+
andler.
- Fix media bus format error s/YUYV8/UYVY8/
Changes since v1:
- Drop dependency on a pad aware s_stream operation.
- Use the DT bindings format "renesas,-", thanks Geert
for pointing this out.
Niklas Söderlund (2):
rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver documentation
Hi again,
On 2018-02-12 21:12:48 +0100, Niklas Söderlund wrote:
> Hi Geert,
>
> When doing some testing on v4.16-rc1 I ran across this warning a couple
> of times. I was using the renesas_config from the current master branch
> of renesas-drivers at the time. It do not hit every
Implement compat IOCTL handling for VIDIOC_SUBDEV_G_ROUTING and
VIDIOC_SUBDEV_S_ROUTING IOCTLs.
Signed-off-by: Niklas Söderlund
---
drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
Hi Sakari,
With this fix on-top of your vc branch I
x20
[3.775747] do_one_initcall+0x9c/0x14c
[3.779580] kernel_init_freeable+0x1dc/0x274
[ 3.783934] kernel_init+0x10/0x100
[3.787419] ret_from_fork+0x10/0x18
--
Regards,
Niklas Söderlund
Allow for chancing the MTU within the limit of the maximum size of a
descriptor (2048 bytes). Add the callback to change MTU from user-space
and take the configurable MTU into account when configuring the
hardware.
Signed-off-by: Niklas Söderlund
---
drivers/net/ethernet/renesas/ravb.h
his by
> providing the missing CBUS page definition.
>
> Signed-off-by: Kieran Bingham
I would drop the '.' from the subject line, with that fixed:
Reviewed-by: Niklas Söderlund
> ---
> drivers/media/i2c/adv748x/adv748x-core.c | 3 +++
> drivers/media/i2c/adv748x/ad
+ ADV748X_REGMAP_CONF("hdmi"),
> + ADV748X_REGMAP_CONF("edid"),
> + ADV748X_REGMAP_CONF("repeater"),
> + ADV748X_REGMAP_CONF("infoframe"),
> + ADV748X_REGMAP_CONF("cec"),
> + ADV748X_REGMAP_CONF("sdp"),
> + ADV748X_REGMAP_CONF("txa"),
> + ADV748X_REGMAP_CONF("txb"),
> };
>
> +#undef ADV748X_REGMAP_CONF
> +
Why is this macro undefined here? It have a rather limited scope as it's
only local to this C file and it have a good prefix of ADV748X_ so
conflicts are highly unlikely. Is there something I'm missing?
Is it really customary to undefine helper macros like this once they are
used to populate the structure?
> static int adv748x_configure_regmap(struct adv748x_state *state, int region)
> {
> int err;
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
rrect this by jumping to the next (and correct) label in the cleanup
> code: err_cleanup_dt.
>
> Fixes: 3e89586a64df ("media: i2c: adv748x: add adv748x driver")
>
> Signed-off-by: Kieran Bingham
Reviewed-by: Niklas Söderlund
> ---
> drivers/media/i2c/adv748x/
Add the LVDS device to r8a77970.dtsi in a disabled state. Also connect
the it to the LVDS output of the DU. While at it align the endpoint name
of the du to du_out_lvds0 which is used in other Renesas DTS files to
describe this link.
Signed-off-by: Niklas Söderlund
---
arch/arm64/boot/dts
Add the HDMI connector and the ADV7511W, also connect it to LVDS. Enable
the DU and LVDS to be able to use the HDMI output.
Signed-off-by: Niklas Söderlund
---
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 66 ++
1 file changed, 66 insertions(+)
diff --git a/arch
601 - 700 of 1858 matches
Mail list logo
