[PATCH] pinctrl: sh-pfc: Use seq_puts() in sh_pfc_pin_dbg_show()

From: Markus Elfring Date: Sat, 6 Jan 2018 21:50:20 +0100 A string which did not contain a data format specification should be put into a sequence. Thus use the corresponding function "seq_puts". This issue was detected by using the Coccinelle software.

[PATCH v2] PCI: rcar: Use common error handling code in rcar_pcie_enable_msi()

From: Markus Elfring Date: Thu, 2 Nov 2017 13:35:17 +0100 * Adjust a jump target so that a specific error message is stored only once at the end of this function implementation. * Replace two calls of the function "dev_err" by goto statements. This issue was

[PATCH v2 2/2] drm/rcar-du: Adjust 14 checks for null pointers

From: Markus Elfring Date: Wed, 1 Nov 2017 16:00:46 +0100 The script "checkpatch.pl" pointed information out like the following. Comparison to NULL could be written !... Thus fix the affected source code places. Signed-off-by: Markus Elfring

[PATCH v2 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init()

From: Markus Elfring Date: Wed, 1 Nov 2017 15:57:31 +0100 * Add a jump target so that a bit of exception handling can be better reused at the end of this function. * Increase the scope for the variable "ret". This issue was detected by using the Coccinelle

[PATCH v2 0/2] R-Car Display Unit: Fine-tuning for some function implementations

From: Markus Elfring Date: Wed, 1 Nov 2017 16:23:45 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): drm/rcar-du: Use common error handling code in rcar_du_encoders_init() drm/rcar-du: Adjust 14 checks

Re: PCI: rcar: Use common error handling code in rcar_pcie_enable_msi()

> This is fine by me Thanks for another bit of change acceptance. > except that the change in the name of the goto label seems spurious. I am curious if the popularity of a jump label like “err” will decrease (in the Linux source files) over time. > But if you really want to change it then

Re: drm/rcar-du: Use common error handling code in rcar_du_encoders_init()

> In general, I'll pick up any patches that are good, This is usual. > but the current track record is that Markus' patches need extra scrutiny, I find that this can be fine according to a safe review for presented update suggestions. > and many of the patches contain subjective changes that

[PATCH] PCI: rcar: Use common error handling code in rcar_pcie_enable_msi()

From: Markus Elfring Date: Mon, 30 Oct 2017 08:28:06 +0100 Adjust a jump target so that a specific error message is stored only once at the end of this function implementation. Replace two calls of the function "dev_err" by goto statements. This issue was detected

Re: drm/rcar-du: Use common error handling code in rcar_du_encoders_init()

> Just for the record, I've been bitten in the past by applying one of Markus' > patches that seemed to make sense, only to discover later that it introduced > a > security hole. How do you think about to take another look at the circumstances under which a questionable commit happened in the

Re: [PATCH] ravb: Use common error handling code in ravb_probe()

>> @@ -2069,10 +2069,9 @@ static int ravb_probe(struct platform_device *pdev) >> irq = platform_get_irq_byname(pdev, "ch22"); >> else >> irq = platform_get_irq(pdev, 0); >> - if (irq < 0) { >> - error = irq; >> - goto

Re: Unicode characters in commit messages?

> These long email threads are a waste of time They occur for different topics. > when we already answered your questions completely There were some attempts for specific details. > and over and over. I hope that further useful adjustments can be achieved for involved information sources.

Re: Unicode characters in commit messages?

>> Would you like to support Unicode characters there? > > Multiple people have answered this question already and I have answered > it multiple times. I found the corresponding feedback not sufficient so far to reach a final consensus. Will this topic evolve any further? Regards, Markus

Re: drm/rcar-du: Adjust 14 checks for null pointers

>> The script “checkpatch.pl” pointed information out like the following. >> >> Comparison to NULL could be written !… >> >> Thus fix the affected source code places. >> > > This one is fine This kind of feedback is nice. > except for the commit message. Would you like to support Unicode

Re: Clarification for approaches around exception handling

> But anyways I guess other people sometimes disagree with me. Am I one of them? ;-) > Unwinding is for when you allocate five things in a row. This is a general issue. I find that it is also needed in this function as usual. > You have to undo four if the last allocation fails. Concrete

[PATCH 2/2] drm/rcar-du: Adjust 14 checks for null pointers

From: Markus Elfring Date: Tue, 24 Oct 2017 17:47:37 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus

[PATCH 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init()

From: Markus Elfring Date: Tue, 24 Oct 2017 17:16:09 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH] clk/Renesas: Delete an error message for a failed memory allocation in three functions

From: Markus Elfring Date: Mon, 25 Sep 2017 10:10:51 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: Possible unnecessary 'out of memory' message Thus fix affected source code places. Signed-off-by: Markus Elfring