Re: [PATCH] dt-bindings: pwm: renesas: pwm-rcar: document R8A779{7|8}0 bindings

2018-10-16 Thread Thierry Reding
On Mon, Oct 15, 2018 at 01:57:13PM -0500, Rob Herring wrote: > On Fri, Oct 12, 2018 at 01:21:14PM +0200, Thierry Reding wrote: > > On Mon, Oct 01, 2018 at 10:57:39PM +0300, Sergei Shtylyov wrote: > > > Document the R-Car V3{M|H} (R8A779{7|8}0) SoC in the Renesas R-Car PWM > &

Re: [PATCH] dt-bindings: pwm: renesas-tpu: Document r8a7744 support

2018-10-12 Thread Thierry Reding
On Thu, Oct 04, 2018 at 05:21:34PM +0100, Biju Das wrote: > Document r8a7744 specific compatible strings. No driver change is > needed as the fallback compatible string "renesas,tpu" activates the > right code in the driver. > > Signed-off-by: Biju Das > Reviewed-by: Chris Paterson > --- > This

Re: [PATCH] dt-bindings: pwm: rcar: Add r8a7744 support

2018-10-12 Thread Thierry Reding
On Thu, Oct 04, 2018 at 05:17:19PM +0100, Biju Das wrote: > Document RZ/G1N (R8A7744) SoC bindings. > > Signed-off-by: Biju Das > Reviewed-by: Chris Paterson > --- > This patch is tested against next-20181004 > --- > Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt | 1 + > 1 file

Re: [PATCH] dt-bindings: pwm: renesas: pwm-rcar: document R8A779{7|8}0 bindings

2018-10-12 Thread Thierry Reding
On Mon, Oct 01, 2018 at 10:57:39PM +0300, Sergei Shtylyov wrote: > Document the R-Car V3{M|H} (R8A779{7|8}0) SoC in the Renesas R-Car PWM > bindings. R8A77970's hardware is a generic R-Car gen3 PWM, while R8A77980 > has an extra error injection register... > > Signed-off-by: Sergei Shtylyov >

Re: [PATCH] dt-bindings: pwm: renesas: tpu: document R8A779{7|8}0 bindings

2018-10-12 Thread Thierry Reding
On Sat, Sep 22, 2018 at 10:57:29PM +0300, Sergei Shtylyov wrote: > Document the R-Car V3{M|H} (R8A779{7|8}0) SoC in the Renesas TPU bindings; > the TPU hardware in those is the Renesas standard 4-channel timer pulse > unit. > > Signed-off-by: Sergei Shtylyov > > --- > This patch is against

Re: [PATCH v2] dt-bindings: pwm: renesas: tpu: fix "compatible" prop description

2018-10-12 Thread Thierry Reding
On Sat, Sep 22, 2018 at 10:43:24PM +0300, Sergei Shtylyov wrote: > The "compatible" property description contradicts even the example given: > it only says that there must be a single value while the example has the > fallback value too -- which makes much more sense. Moreover, the generic >

Re: [PATCH resend] pwm: renesas-tpu: convert to SPDX identifiers

2018-10-12 Thread Thierry Reding
On Wed, Sep 26, 2018 at 01:45:47AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > Signed-off-by: Kuninori Morimoto > Reviewed-by: Simon Horman > --- > Thierry > > 2weeks past,

Re: [PATCH resend] pwm: rcar: convert to SPDX identifiers

2018-10-12 Thread Thierry Reding
On Wed, Sep 26, 2018 at 01:45:17AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > Signed-off-by: Kuninori Morimoto > Reviewed-by: Simon Horman > --- > Thierry > > 2weeks past,

Re: [PATCH v2] dt-bindings: pwm: renesas: tpu: fix "compatible" prop description

2018-09-24 Thread Thierry Reding
On Sat, Sep 22, 2018 at 10:43:24PM +0300, Sergei Shtylyov wrote: > The "compatible" property description contradicts even the example given: > it only says that there must be a single value while the example has the > fallback value too -- which makes much more sense. Moreover, the generic >

Re: [PATCH] dt-bindings: pwm: rcar: Add bindings for R-Car E3 support

2018-08-20 Thread Thierry Reding
On Mon, Jul 30, 2018 at 08:49:51PM +0900, Yoshihiro Shimoda wrote: > This patch adds bindings for R-Car E3. No driver update is needed. > > Signed-off-by: Yoshihiro Shimoda > --- > Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt | 1 + > 1 file changed, 1 insertion(+) Applied,

Re: [PATCH 10/61] gpio: simplify getting .drvdata

2018-04-30 Thread Thierry Reding
On Mon, Apr 30, 2018 at 11:03:25AM +0200, Linus Walleij wrote: > On Thu, Apr 19, 2018 at 5:14 PM, Grygorii Strashko > wrote: > > On 04/19/2018 09:05 AM, Wolfram Sang wrote: > >> > >> We should get drvdata from struct device directly. Going via > >> platform_device is an

Re: [PATCH 43/61] pwm: simplify getting .drvdata

2018-04-30 Thread Thierry Reding
On Thu, Apr 19, 2018 at 04:06:13PM +0200, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang > --- > > Build tested only. buildbot is happy.

Re: [PATCH] drm/core: Remove drm_dev_unref() and it's uses

2018-04-26 Thread Thierry Reding
rm_dev_unref() with drm_dev_put and remove > the function itself. > > Coccinelle was used for mass-patching. > > Signed-off-by: Vaishali Thakkar <vthakkar1...@gmail.com> Yes, please. Acked-by: Thierry Reding <tred...@nvidia.com> signature.asc Description: PGP signature

Re: [PATCH v2 0/2] pwm: rcar: Add suspend/resume support and cleanup for runtime_pm

2018-03-27 Thread Thierry Reding
On Tue, Mar 13, 2018 at 05:18:16PM +0900, Yoshihiro Shimoda wrote: > This patch set improves power management for Renesas PWM driver. > > Changes from v1: > - Add Reviewed-by Geert-san in patch 1 (Thanks!). > - Check a condition in suspend/resume if requested or not in patch 2. > > Hien Dang

Re: [PATCH] dt-bindings: pwm: renesas,pwm-rcar: add bindings for R-Car M3N support

2018-03-27 Thread Thierry Reding
On Fri, Mar 09, 2018 at 08:53:17PM +0900, Yoshihiro Shimoda wrote: > This patch adds bindings for R-Car M3N. No driver update is needed. > > Signed-off-by: Yoshihiro Shimoda > --- > Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt | 1 + > 1 file

Re: [PATCH] pwm: rcar: fix a condition to prevent mismatch value setting to duty

2018-03-27 Thread Thierry Reding
On Fri, Mar 09, 2018 at 08:24:21PM +0900, Yoshihiro Shimoda wrote: > From: Ryo Kodama > > This patch fixes an issue that is possible to set mismatch value > to duty for R-Car PWM if we input the following commands: > > # cd /sys/class/pwm// > # echo 0 > export > #

Re: [PATCH v4] dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings

2018-03-27 Thread Thierry Reding
On Wed, Dec 20, 2017 at 11:15:43AM +, Fabrizio Castro wrote: > This patch adds compatible strings specific to r8a774[35], no driver > change is needed as the fallback compatible string will activate the > right code. > > Also, this patch replaces the example with a DT snippet used > for

Re: [PATCH v3 4/5] dt-bindings: pwm: renesas-tpu: Document r8a774[35] support

2018-03-27 Thread Thierry Reding
On Tue, Dec 19, 2017 at 01:34:59PM +, Fabrizio Castro wrote: > Document r8a774[35] specific compatible strings. No driver change is > needed as the fallback compatible string "renesas,tpu" activates the > right code in the driver. > > Signed-off-by: Fabrizio Castro

Re: [PATCH repost2] pwm: renesas-tpu: remove support for sh7372

2017-08-18 Thread Thierry Reding
On Fri, Aug 18, 2017 at 12:09:01PM +0200, Simon Horman wrote: > Remove support for the SH7372 (SH-Mobile AP4) from the renesas-tpu driver. > > Commit edf4100906044225 ("ARM: shmobile: sh7372 dtsi: Remove Legacy file") > removes this SoC from the kernel in v4.1. > > Acked-by: Geert Uytterhoeven

Re: [PATCH v4] dt-bindings: pwm: Add R-Car M3-W device tree bindings

2017-07-05 Thread Thierry Reding
On Fri, May 12, 2017 at 10:09:42AM +0200, Simon Horman wrote: > From: Ulrich Hecht > > Add device tree bindings for the PWM controller found on R-Car M3-W SoCs. > > Signed-off-by: Ulrich Hecht > --- > v4 > * Broke out of lager

Re: [PATCH v2 05/13] drm: panels: Constify device node argument to of_drm_find_panel()

2017-01-03 Thread Thierry Reding
On Sat, Nov 19, 2016 at 05:28:05AM +0200, Laurent Pinchart wrote: > The argument is never modified by the function, make it const. > > Signed-off-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_panel.c | 2 +- > include/drm/drm_panel.h | 4 ++-- >

Re: [PATCH v2.1 04/13] drm: Add data transmission order bus flag

2017-01-03 Thread Thierry Reding
g this I'll probably do that myself, and I leave it up to whoever else might apply it whether or not they want to be pedantic, so: Reviewed-by: Thierry Reding <tred...@nvidia.com> signature.asc Description: PGP signature

Re: [PATCH v2 06/13] drm: panels: Add LVDS panel driver

2016-11-22 Thread Thierry Reding
On Sat, Nov 19, 2016 at 05:28:06AM +0200, Laurent Pinchart wrote: > This driver supports LVDS panels that don't require device-specific > handling of power supplies or control signals. It implements automatic > backlight handling if the panel is attached to a backlight controller. > >

Re: [PATCH v2 01/13] devicetree/bindings: display: Document common panel properties

2016-11-22 Thread Thierry Reding
On Sat, Nov 19, 2016 at 05:28:01AM +0200, Laurent Pinchart wrote: > Document properties common to several display panels in a central > location that can be referenced by the panel device tree bindings. > > Signed-off-by: Laurent Pinchart > --- >

Re: [PATCH v3 5/6] pwm: add R-Car H3 device tree bindings

2016-07-11 Thread Thierry Reding
On Thu, Mar 31, 2016 at 01:39:15PM +0200, Ulrich Hecht wrote: > Signed-off-by: Ulrich Hecht > Acked-by: Geert Uytterhoeven > --- > Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt | 1 + > 1 file changed, 1 insertion(+)

Re: [PATCH v3 1/6] pwm: rcar: Use ARCH_RENESAS

2016-07-11 Thread Thierry Reding
On Thu, Mar 31, 2016 at 01:39:11PM +0200, Ulrich Hecht wrote: > From: Ryo Kodama > > Replace ARCH_RCAR_GEN{1,2} with ARCH_RENESAS in order to support R-Car Gen3. > > Signed-off-by: Ryo Kodama > Signed-off-by: Harunobu Kurokawa

Re: [PATCH v2] pwm: improve args checking in pwm_apply_state()

2016-06-23 Thread Thierry Reding
On Wed, Jun 22, 2016 at 01:46:48PM -0700, Brian Norris wrote: > On Wed, Jun 22, 2016 at 10:41:14PM +0200, Boris Brezillon wrote: > > On Wed, 22 Jun 2016 12:16:59 -0700 > > Brian Norris wrote: > > > Notably, you're dropping the 'if (!pwm) { }' safety checks that are part

Re: [PATCH v2] pwm: improve args checking in pwm_apply_state()

2016-06-22 Thread Thierry Reding
On Wed, Jun 22, 2016 at 10:04:22AM +0200, Boris Brezillon wrote: > On Tue, 21 Jun 2016 11:37:31 -0700 > Brian Norris wrote: > > > Hi Geert, > > > > On Tue, Jun 21, 2016 at 04:42:04PM +0200, Geert Uytterhoeven wrote: > > > On Fri, May 27, 2016 at 6:45 PM, Brian Norris

Re: [PATCH] pwm: sysfs: get return value from pwm_apply_state()

2016-06-10 Thread Thierry Reding
On Wed, Jun 08, 2016 at 10:58:23AM +0900, Yoshihiro Shimoda wrote: > From: Ryo Kodama > > This patch adds to check the return value from pwm_apply_state() > used in enable_store(). The error of enable_store() doesn't work > if the return value doesn't received. > >

Re: [PATCH] pwm: rcar: Use ARCH_RENESAS

2016-03-04 Thread Thierry Reding
On Thu, Feb 25, 2016 at 10:03:23AM +0900, Simon Horman wrote: > Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. > > This is part of an ongoing process to migrate from ARCH_SHMOBILE to > ARCH_RENESAS the motivation for which being that RENESAS seems to be a more > appropriate name than