[PATCH/RFC] serial: sh-sci: Fix unlocked access to SCSCR register

2016-11-07 Thread Simon Horman
From: Takatoshi Akiyama The SCSCR register access in sci_break_ctl() is not locked. sci_start_tx() and sci_set_termios() changes the SCSCR register, but does not lock sci_port. Therefore, this patch adds lock during register access. Also, remove the log output that leads to a double lock. Sig

Re: [PATCH/RFC] serial: sh-sci: Fix unlocked access to SCSCR register

2016-11-07 Thread Wolfram Sang
On Mon, Nov 07, 2016 at 04:42:53PM +0100, Simon Horman wrote: > From: Takatoshi Akiyama > > The SCSCR register access in sci_break_ctl() is not locked. > > sci_start_tx() and sci_set_termios() changes the SCSCR register, > but does not lock sci_port. Maybe naive question: Shouldn't stop_tx and/

Re: [PATCH/RFC] serial: sh-sci: Fix unlocked access to SCSCR register

2017-11-02 Thread Simon Horman
On Mon, Nov 07, 2016 at 04:52:09PM +0100, Wolfram Sang wrote: > On Mon, Nov 07, 2016 at 04:42:53PM +0100, Simon Horman wrote: > > From: Takatoshi Akiyama > > > > The SCSCR register access in sci_break_ctl() is not locked. > > > > sci_start_tx() and sci_set_termios() changes the SCSCR register, >