Re: [PATCH] ARM: dts: r7s72100: add clock bit definitions

2017-06-01 Thread Geert Uytterhoeven
Hi Chris, On Tue, May 30, 2017 at 6:23 PM, Chris Brandt wrote: >> > +#define R7S72100_CLK_SPIMBC0 3 >> > +#define R7S72100_CLK_SPIMBC1 2 >> >> R7S72100_CLK_SPB[0-1]? > > Here's the one that I'm struggling with what to call. > > Internally, the IP block is referred to as the "SPIBSC". As in, S

RE: [PATCH] ARM: dts: r7s72100: add clock bit definitions

2017-05-30 Thread Chris Brandt
Hi Geert, As always Thank you for your review! On Monday, May 29, 2017, Geert Uytterhoeven wrote: > > #define R7S72100_CLK_PLL 0 > > No CoreSight (MSTP20)? OK, I'll add that in. > > +#define R7S72100_CLK_MCPWM 0 > > Perhaps just R7S72100_CLK_PWM? OK. People don't seem to be usin

Re: [PATCH] ARM: dts: r7s72100: add clock bit definitions

2017-05-30 Thread Simon Horman
On Mon, May 29, 2017 at 11:31:37AM +0200, Geert Uytterhoeven wrote: > Hi Chris, > > On Thu, May 25, 2017 at 6:05 PM, Chris Brandt > wrote: > > Add the remaining bit locations for the module stop clock registers. > > > > Signed-off-by: Chris Brandt > > Reviewed-by: Geert Uytterhoeven Chris, p

Re: [PATCH] ARM: dts: r7s72100: add clock bit definitions

2017-05-29 Thread Geert Uytterhoeven
Hi Chris, On Thu, May 25, 2017 at 6:05 PM, Chris Brandt wrote: > Add the remaining bit locations for the module stop clock registers. > > Signed-off-by: Chris Brandt Reviewed-by: Geert Uytterhoeven > --- a/include/dt-bindings/clock/r7s72100-clock.h > +++ b/include/dt-bindings/clock/r7s72100-c

[PATCH] ARM: dts: r7s72100: add clock bit definitions

2017-05-25 Thread Chris Brandt
Add the remaining bit locations for the module stop clock registers. Signed-off-by: Chris Brandt --- include/dt-bindings/clock/r7s72100-clock.h | 40 ++ 1 file changed, 40 insertions(+) diff --git a/include/dt-bindings/clock/r7s72100-clock.h b/include/dt-bindings/cl