The RZ/A1 is different than the other Renesas SOCs because the MSTP
registers are 8-bit instead of 32-bit and if you try writing values as
32-bit nothing happens...meaning this driver never worked for r7s72100.
Fixes: b6face404f38 ("ARM: shmobile: r7s72100: add essential clock nodes to
dtsi")
Sig
Hi Chris
> The RZ/A1 is different than the other Renesas SOCs because the MSTP
> registers are 8-bit instead of 32-bit and if you try writing values as
> 32-bit nothing happens...meaning this driver never worked for r7s72100.
>
> Fixes: b6face404f38 ("ARM: shmobile: r7s72100: add essential clock
Hi Morimoto-san,
On Dec 14, 2016, Kuninori Morimoto wrote:
> I don't think using global variable is a good idea.
> For example, how about add reg_width_8bit into mstp_clock_group, and
> cpg_mstp_read/write requests it, or something like that ?
If I make a separate CLK_OF_DECLARE like this:
stati
Hi Chris
> > I don't think using global variable is a good idea.
> > For example, how about add reg_width_8bit into mstp_clock_group, and
> > cpg_mstp_read/write requests it, or something like that ?
>
> If I make a separate CLK_OF_DECLARE like this:
>
> static void __init cpg_mstp_clocks_init8
Hi Chris
> > > I don't think using global variable is a good idea.
> > > For example, how about add reg_width_8bit into mstp_clock_group, and
> > > cpg_mstp_read/write requests it, or something like that ?
> >
> > If I make a separate CLK_OF_DECLARE like this:
> >
> > static void __init cpg_mst
Hi Chris,
On Thu, Dec 15, 2016 at 3:58 AM, Chris Brandt wrote:
> On Dec 14, 2016, Kuninori Morimoto wrote:
>> I don't think using global variable is a good idea.
>> For example, how about add reg_width_8bit into mstp_clock_group, and
>> cpg_mstp_read/write requests it, or something like that ?
>
Hi Geert and Morimoto-san,
On December 15, 2016, Geert Uytterhoeven wrote:
> Or you can add an of_device_is_compatible(np, "renesas,r7s72100-mstp-
> clocks") check to cpg_mstp_clocks_init(), keeping the single
> CLK_OF_DECLARE().
>
> I think that would also performs slightly better, as only nodes
