> > Any plans to apply it? drivers/gpio/gpiolib.c is your territory, I believe
> > ;-)
>
> Ooops sorry.
>
> Patch applied.
Thanks Geert & Linus!
signature.asc
Description: PGP signature
On Tue, Sep 11, 2018 at 2:04 PM Geert Uytterhoeven wrote:
> On Sun, Jul 29, 2018 at 11:33 PM Linus Walleij
> wrote:> > On Wed, Jul 25, 2018 at 10:20 PM Wolfram Sang
> wrote:
> > > > That all being said, I think this patch is still useful as is.
> > >
> > > Linus, do you have time to comment on
Hi Linus,
On Sun, Jul 29, 2018 at 11:33 PM Linus Walleij wrote:
> On Wed, Jul 25, 2018 at 10:20 PM Wolfram Sang wrote:
> > > That all being said, I think this patch is still useful as is.
> >
> > Linus, do you have time to comment on this?
>
> This looks like a good solution to me.
> Reviewed-by
On Wed, Jul 25, 2018 at 10:20 PM Wolfram Sang wrote:
> > That all being said, I think this patch is still useful as is.
>
> Linus, do you have time to comment on this?
This looks like a good solution to me.
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
> That all being said, I think this patch is still useful as is.
Linus, do you have time to comment on this?
signature.asc
Description: PGP signature
On Wed, Jul 11, 2018 at 06:33:19PM +0200, Wolfram Sang wrote:
> EINVAL is very generic, use ENOTSUPP in case the gpiochip does not
> provide this function. While removing the assignment from the 'status'
> variable, use better indentation in the declaration block.
>
> Signed-off-by: Wolfram Sang
> For the short term, I will remove the sanity check from the I2C core and
> hope the user properly set up the GPIO.
For the record, this patch is here:
http://patchwork.ozlabs.org/patch/943115/
Forgot to cc linux-gpio.
signature.asc
Description: PGP signature
On Wed, Jul 11, 2018 at 06:33:19PM +0200, Wolfram Sang wrote:
> EINVAL is very generic, use ENOTSUPP in case the gpiochip does not
> provide this function. While removing the assignment from the 'status'
> variable, use better indentation in the declaration block.
>
> Signed-off-by: Wolfram Sang
> Do you want me to implement it?
Yes, please.
Thanks a lot!
signature.asc
Description: PGP signature
Hi Wolfram,
On Wed, Jul 11, 2018 at 6:33 PM Wolfram Sang
wrote:
> @Geert: any reason gpio-rcar is missing it? I would need it for the
> i2c-gpio-fault-injector.
Because so far no one had a need for it?
/me thought gpiolib would return a cached value from a previous
set_direction_{in,out}put(), b
EINVAL is very generic, use ENOTSUPP in case the gpiochip does not
provide this function. While removing the assignment from the 'status'
variable, use better indentation in the declaration block.
Signed-off-by: Wolfram Sang
---
I got puzzled by the EINVAL until I found out that gpio-rcar simply
11 matches
Mail list logo