Re: [PATCH] mmc: renesas_sdhi_internal_dmac: mask DMAC interrupts

2018-08-20 Thread Wolfram Sang
> >> /* DM_CM_INFO2 and DM_CM_INFO2_MASK */ > >> #define INFO2_DTRANERR1 BIT(17) > >> #define INFO2_DTRANERR0 BIT(16) > >> +#define INFO2_RESERVED_BITS GENMASK_ULL(32, 0) > > > > Same as above. Maybe we even need one define only? > >No, I think 2 separate regs de

Re: [PATCH] mmc: renesas_sdhi_internal_dmac: mask DMAC interrupts

2018-08-20 Thread Sergei Shtylyov
Hello! On 08/20/2018 07:38 PM, Wolfram Sang wrote: >> I have encountered an interrupt storm during the eMMC chip probing (and >> the chip finally didn't get detected). It turned out that U-Boot left >> the SDHI DMA interrupts enabled while the Linux driver didn't use those. >> Masking those in

Re: [PATCH] mmc: renesas_sdhi_internal_dmac: mask DMAC interrupts

2018-08-20 Thread Wolfram Sang
On Fri, Aug 17, 2018 at 07:54:09PM +0300, Sergei Shtylyov wrote: > I have encountered an interrupt storm during the eMMC chip probing (and > the chip finally didn't get detected). It turned out that U-Boot left > the SDHI DMA interrupts enabled while the Linux driver didn't use those. > Masking

[PATCH] mmc: renesas_sdhi_internal_dmac: mask DMAC interrupts

2018-08-17 Thread Sergei Shtylyov
I have encountered an interrupt storm during the eMMC chip probing (and the chip finally didn't get detected). It turned out that U-Boot left the SDHI DMA interrupts enabled while the Linux driver didn't use those. Masking those interrupts in renesas_sdhi_internal_dmac_request_dma() gets rid of