Re: [PATCH] pinctrl: sh-pfc: Let gpio_chip.to_irq() return -ENXIO on error

Hi Linus, On Mon, May 2, 2016 at 11:25 AM, Linus Walleij wrote: > On Mon, May 2, 2016 at 11:10 AM, Geert Uytterhoeven > wrote: >> On Mon, May 2, 2016 at 11:06 AM, Linus Walleij >> wrote: >>> On Mon, May 2, 2016 at 11:04

Re: [PATCH] pinctrl: sh-pfc: Let gpio_chip.to_irq() return -ENXIO on error

Hi Linus, On Mon, May 2, 2016 at 11:06 AM, Linus Walleij wrote: > On Mon, May 2, 2016 at 11:04 AM, Geert Uytterhoeven > wrote: > >> [silly response deleted] >> >> Scrap it. > > :D > >> The only annoying thing is that 0 cannot easily be propagated

Re: [PATCH] pinctrl: sh-pfc: Let gpio_chip.to_irq() return -ENXIO on error

On Mon, May 2, 2016 at 11:04 AM, Geert Uytterhoeven wrote: > [silly response deleted] > > Scrap it. :D > The only annoying thing is that 0 cannot easily be propagated upstream as > an error code, so it has to be tested for explicitly. Well with the Big Penguin's clear

Re: [PATCH] pinctrl: sh-pfc: Let gpio_chip.to_irq() return -ENXIO on error

Hi Linus, On Mon, May 2, 2016 at 10:30 AM, Linus Walleij wrote: > On Mon, May 2, 2016 at 10:03 AM, Geert Uytterhoeven > wrote: >> On Sun, May 1, 2016 at 10:48 AM, Linus Walleij >> wrote: - Drivers that call

Re: [PATCH] pinctrl: sh-pfc: Let gpio_chip.to_irq() return -ENXIO on error

On Mon, May 2, 2016 at 10:03 AM, Geert Uytterhoeven wrote: > On Sun, May 1, 2016 at 10:48 AM, Linus Walleij > wrote: >>> - Drivers that call irq_find_mapping(), irq_create_mapping(), or >>> irq_create_fwspec_mapping() return zero! This

Re: [PATCH] pinctrl: sh-pfc: Let gpio_chip.to_irq() return -ENXIO on error

Hi Linus, On Sun, May 1, 2016 at 10:48 AM, Linus Walleij wrote: >> Currrently the gpio_chip.to_irq() callback returns -ENOSYS on error, >> which causes bad interactions with the serial_mctrl_gpio helpers. >> >> mctrl_gpio_init() returns -ENOSYS if GPIOLIB is not

Re: [PATCH] pinctrl: sh-pfc: Let gpio_chip.to_irq() return -ENXIO on error

On Fri, Apr 29, 2016 at 9:24 AM, Geert Uytterhoeven wrote: > Currrently the gpio_chip.to_irq() callback returns -ENOSYS on error, > which causes bad interactions with the serial_mctrl_gpio helpers. > > mctrl_gpio_init() returns -ENOSYS if GPIOLIB is not enabled, which is

[PATCH] pinctrl: sh-pfc: Let gpio_chip.to_irq() return -ENXIO on error

Currrently the gpio_chip.to_irq() callback returns -ENOSYS on error, which causes bad interactions with the serial_mctrl_gpio helpers. mctrl_gpio_init() returns -ENOSYS if GPIOLIB is not enabled, which is intended to be ignored by its callers. However, ignoring -ENOSYS when it was caused by a