Re: [PATCH] ravb: Use common error handling code in ravb_probe()

2017-10-30 Thread Sergei Shtylyov
On 10/30/2017 11:51 PM, Sergei Shtylyov wrote: From: Markus Elfring Date: Sat, 28 Oct 2017 19:10:08 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Have you actually tried to see if there's any change in the resulting object

Re: [PATCH] ravb: Use common error handling code in ravb_probe()

2017-10-30 Thread Sergei Shtylyov
On 10/29/2017 02:00 PM, Geert Uytterhoeven wrote: From: Markus Elfring Date: Sat, 28 Oct 2017 19:10:08 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus

Re: [PATCH] ravb: Use common error handling code in ravb_probe()

2017-10-30 Thread Sergei Shtylyov
Hello! On 10/28/2017 08:19 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Sat, 28 Oct 2017 19:10:08 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Have you actually tried to see if there's any change in the resulting

Re: [PATCH] ravb: Use common error handling code in ravb_probe()

2017-10-29 Thread SF Markus Elfring
>> @@ -2069,10 +2069,9 @@ static int ravb_probe(struct platform_device *pdev) >> irq = platform_get_irq_byname(pdev, "ch22"); >> else >> irq = platform_get_irq(pdev, 0); >> - if (irq < 0) { >> - error = irq; >> - goto out_rel

Re: [PATCH] ravb: Use common error handling code in ravb_probe()

2017-10-29 Thread Geert Uytterhoeven
Hi Markus, On Sat, Oct 28, 2017 at 7:19 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 28 Oct 2017 19:10:08 +0200 > > Add a jump target so that a bit of exception handling can be better reused > at the end of this function. > > This issue was detected by using the Coccinelle so

[PATCH] ravb: Use common error handling code in ravb_probe()

2017-10-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 28 Oct 2017 19:10:08 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/renesas/ravb_main