Re: [PATCH] watchdog: softdog: make pretimeout support a compile option

2017-01-19 Thread Wolfram Sang
> > +#if IS_ENABLED(CONFIG_SOFT_WATCHDOG_PRETIMEOUT) > > static void softdog_pretimeout(unsigned long data) > > I would prefer __maybe_unused here .. > > > { > > watchdog_notify_pretimeout(_dev); > > @@ -82,16 +83,23 @@ static void softdog_pretimeout(unsigned long data) > > static struct

Re: [PATCH] watchdog: softdog: make pretimeout support a compile option

2017-01-10 Thread Guenter Roeck
On Fri, Jan 06, 2017 at 09:41:44AM +0100, Wolfram Sang wrote: > It occured to me that the panic pretimeout governor will stall the > softdog, because it is purely software which simply halts on panic. > Testing governors with the softdog on the other hand is really useful. > So, make this feature

[PATCH] watchdog: softdog: make pretimeout support a compile option

2017-01-06 Thread Wolfram Sang
It occured to me that the panic pretimeout governor will stall the softdog, because it is purely software which simply halts on panic. Testing governors with the softdog on the other hand is really useful. So, make this feature a compile time option which needs to be enabled explicitly. This also