Re: [PATCH 0/2] Salvator-X: Add GPIO keys support

2016-11-15 Thread Linus Walleij
On Tue, Nov 15, 2016 at 3:28 PM, Laurent Pinchart wrote: >> >>> Apart from that, there's also the discrepancy between hardware >> >>> description (the GPIO is connected to both buttons and LEDs, hence it >> >>> should be described that way in DT) >> >> >> >>

Re: [PATCH 0/2] Salvator-X: Add GPIO keys support

2016-11-15 Thread Laurent Pinchart
On Tuesday 15 Nov 2016 16:26:11 Laurent Pinchart wrote: > Hi Geert, > > (CC'ing Linus) With Linus' e-mail address fixed. I'll blame my e-mail client that uses incorrect addresses from old e-mails as the top auto-completion options :-/ > On Tuesday 15 Nov 2016 08:58:18 Geert Uytterhoeven wrote:

Re: [PATCH 0/2] Salvator-X: Add GPIO keys support

2016-11-15 Thread Geert Uytterhoeven
On Tue, Nov 15, 2016 at 3:26 PM, Laurent Pinchart wrote: >> > disabling the I/O interrupt (or just ignoring it). >> >> IIRC, the R-Car GPIO block will send interrupts in output mode only. > > Do you mean input mode only ? Yes, sorry (still suffering a bit from

Re: [PATCH 0/2] Salvator-X: Add GPIO keys support

2016-11-15 Thread Laurent Pinchart
Hi Geert, (CC'ing Linus) On Tuesday 15 Nov 2016 08:58:18 Geert Uytterhoeven wrote: > On Tue, Nov 15, 2016 at 12:59 AM, Laurent Pinchart wrote: > > On Monday 14 Nov 2016 20:47:03 Geert Uytterhoeven wrote: > >> On Mon, Nov 14, 2016 at 5:44 PM, Laurent Pinchart wrote: > >>> On Monday 14 Nov 2016

Re: [PATCH 0/2] Salvator-X: Add GPIO keys support

2016-11-14 Thread Geert Uytterhoeven
Hi Laurent, On Tue, Nov 15, 2016 at 12:59 AM, Laurent Pinchart wrote: > On Monday 14 Nov 2016 20:47:03 Geert Uytterhoeven wrote: >> On Mon, Nov 14, 2016 at 5:44 PM, Laurent Pinchart wrote: >> > On Monday 14 Nov 2016 14:47:00 Geert Uytterhoeven wrote: >> >> On

Re: [PATCH 0/2] Salvator-X: Add GPIO keys support

2016-11-14 Thread Laurent Pinchart
Hi Geert, On Monday 14 Nov 2016 20:47:03 Geert Uytterhoeven wrote: > On Mon, Nov 14, 2016 at 5:44 PM, Laurent Pinchart wrote: > > On Monday 14 Nov 2016 14:47:00 Geert Uytterhoeven wrote: > >> On Mon, Nov 14, 2016 at 2:41 PM, Laurent Pinchart wrote: > >>> On Monday 14 Nov 2016 14:35:26 Geert

Re: [PATCH 0/2] Salvator-X: Add GPIO keys support

2016-11-14 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Nov 14, 2016 at 5:44 PM, Laurent Pinchart wrote: > On Monday 14 Nov 2016 14:47:00 Geert Uytterhoeven wrote: >> On Mon, Nov 14, 2016 at 2:41 PM, Laurent Pinchart wrote: >> > On Monday 14 Nov 2016 14:35:26 Geert Uytterhoeven wrote: >> >> The

Re: [PATCH 0/2] Salvator-X: Add GPIO keys support

2016-11-14 Thread Laurent Pinchart
Hi Geert, On Monday 14 Nov 2016 14:47:00 Geert Uytterhoeven wrote: > On Mon, Nov 14, 2016 at 2:41 PM, Laurent Pinchart wrote: > > On Monday 14 Nov 2016 14:35:26 Geert Uytterhoeven wrote: > >> The main reason I haven't sent out a similar series yet is because the > >> GPIOs used for the 3 push

Re: [PATCH 0/2] Salvator-X: Add GPIO keys support

2016-11-14 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Nov 14, 2016 at 2:41 PM, Laurent Pinchart wrote: > On Monday 14 Nov 2016 14:35:26 Geert Uytterhoeven wrote: >> The main reason I haven't sent out a similar series yet is because the GPIOs >> used for the 3 push buttons are shared with the 3

Re: [PATCH 0/2] Salvator-X: Add GPIO keys support

2016-11-14 Thread Laurent Pinchart
Hi Geert, On Monday 14 Nov 2016 14:35:26 Geert Uytterhoeven wrote: > On Mon, Nov 14, 2016 at 2:07 PM, Laurent Pinchart wrote: > > This simple series adds GPIO keys support to both the H3- and M3-W-based > > Salvator-X boards. Please see individual patches for details. > > Thanks for your series!

Re: [PATCH 0/2] Salvator-X: Add GPIO keys support

2016-11-14 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Nov 14, 2016 at 2:07 PM, Laurent Pinchart wrote: > This simple series adds GPIO keys support to both the H3- and M3-W-based > Salvator-X boards. Please see individual patches for details. Thanks for your series! The main reason I

[PATCH 0/2] Salvator-X: Add GPIO keys support

2016-11-14 Thread Laurent Pinchart
Hello, This simple series adds GPIO keys support to both the H3- and M3-W-based Salvator-X boards. Please see individual patches for details. Laurent Pinchart (2): arm64: dts: r8a7795: salvator-x: Add GPIO keys support arm64: dts: r8a7796: salvator-x: Add GPIO keys support