RE: [PATCH 1/2] watchdog: core: fix null pointer dereference when releasing cdev

2018-09-03 Thread Fabrizio Castro
> Subject: [PATCH 1/2] watchdog: core: fix null pointer dereference when > releasing cdev > > watchdog_stop() calls watchdog_update_worker() which needs a valid > wdd->wd_data pointer. So, when unregistering the cdev, clear the > pointers after we call watchdog_stop(),

Re: [PATCH 1/2] watchdog: core: fix null pointer dereference when releasing cdev

2018-08-28 Thread Guenter Roeck
On 08/28/2018 03:13 AM, Wolfram Sang wrote: watchdog_stop() calls watchdog_update_worker() which needs a valid wdd->wd_data pointer. So, when unregistering the cdev, clear the pointers after we call watchdog_stop(), not before. Fixes: bb292ac1c602 ("watchdog: Introduce

[PATCH 1/2] watchdog: core: fix null pointer dereference when releasing cdev

2018-08-28 Thread Wolfram Sang
watchdog_stop() calls watchdog_update_worker() which needs a valid wdd->wd_data pointer. So, when unregistering the cdev, clear the pointers after we call watchdog_stop(), not before. Fixes: bb292ac1c602 ("watchdog: Introduce watchdog_stop_on_unregister helper") Signed-off-by: Wolfram Sang ---