On Thu, Sep 20, 2018 at 12:02:27AM +0200, Niklas Söderlund wrote:
> Hi Wolfram,
>
> On 2018-09-16 16:48:07 +0200, Wolfram Sang wrote:
> >
> > > > > > So, we should at least protect this with TMIO_MMC_MIN_RCAR2, I'd
> > > > > > think.
> > > > > > Maybe we should even move it to renesas_sdhi_core.
Hi Wolfram,
On 2018-09-16 16:48:07 +0200, Wolfram Sang wrote:
>
> > > > > So, we should at least protect this with TMIO_MMC_MIN_RCAR2, I'd
> > > > > think.
> > > > > Maybe we should even move it to renesas_sdhi_core.c, but I am not too
> > > > > sure about that.
> > >
> > > ... this.
> > >
> >
> > > > So, we should at least protect this with TMIO_MMC_MIN_RCAR2, I'd think.
> > > > Maybe we should even move it to renesas_sdhi_core.c, but I am not too
> > > > sure about that.
> >
> > ... this.
> >
>
> I will look into this and send a new version :-)
Did you send V2 of this? I can't fin
Hi Wolfram,
Thanks for your feedback.
On 2018-06-27 09:27:02 +0200, Wolfram Sang wrote:
>
> > > > +#define TMIO_MASK_INIT 0x8b7f031d /* H/W initial value */
> > >
> > > known on R-Car 2+ only!
> >
> > No it's also know on Gen3 :-)
>
> Sure, 2+ means "R-Car 2 and later". Like with GPL
> > > +#define TMIO_MASK_INIT 0x8b7f031d /* H/W initial value */
> >
> > known on R-Car 2+ only!
>
> No it's also know on Gen3 :-)
Sure, 2+ means "R-Car 2 and later". Like with GPL2+. Sorry if this was
not clear. And it is still my main argument to do...
> > So, we should at least pro
Hi Wolfram,
Thanks for your feedback.
On 2018-06-09 20:15:52 +0200, Wolfram Sang wrote:
> Hi Niklas,
>
> On Thu, Jun 07, 2018 at 01:22:50AM +0200, Niklas Söderlund wrote:
> > From: Masaharu Hayakawa
> >
> > The initial value of the interrupt mask register may be different from
> > the H/W manu
Hi Niklas,
On Thu, Jun 07, 2018 at 01:22:50AM +0200, Niklas Söderlund wrote:
> From: Masaharu Hayakawa
>
> The initial value of the interrupt mask register may be different from
> the H/W manual at the startup of the kernel by setting of initial program.
s/initial program/bootloader/ ?
> Since
From: Masaharu Hayakawa
The initial value of the interrupt mask register may be different from
the H/W manual at the startup of the kernel by setting of initial program.
Since the error interrupts may be unmasked, the driver sets initial value.
Signed-off-by: Masaharu Hayakawa
Signed-off-by: Ni