Re: [PATCH 11/22] drm: bridge: dw-hdmi: Refactor hdmi_phy_configure resolution parameter

2016-12-04 Thread Kieran Bingham
On 02/12/16 14:18, Russell King - ARM Linux wrote: > On Fri, Dec 02, 2016 at 01:43:26AM +0200, Laurent Pinchart wrote: >> From: Kieran Bingham >> >> The current code hard codes the call of hdmi_phy_configure() to be 8bpp >> and provides extraneous error checking to verify that this hardcoded >> va

Re: [PATCH 11/22] drm: bridge: dw-hdmi: Refactor hdmi_phy_configure resolution parameter

2016-12-02 Thread Russell King - ARM Linux
On Fri, Dec 02, 2016 at 05:51:18PM +0200, Laurent Pinchart wrote: > Hi Russell, > > On Friday 02 Dec 2016 14:18:08 Russell King - ARM Linux wrote: > > On Fri, Dec 02, 2016 at 01:43:26AM +0200, Laurent Pinchart wrote: > > > From: Kieran Bingham > > > > > > The current code hard codes the call of

Re: [PATCH 11/22] drm: bridge: dw-hdmi: Refactor hdmi_phy_configure resolution parameter

2016-12-02 Thread Laurent Pinchart
Hi Russell, On Friday 02 Dec 2016 14:18:08 Russell King - ARM Linux wrote: > On Fri, Dec 02, 2016 at 01:43:26AM +0200, Laurent Pinchart wrote: > > From: Kieran Bingham > > > > The current code hard codes the call of hdmi_phy_configure() to be 8bpp > > and provides extraneous error checking to ve

Re: [PATCH 11/22] drm: bridge: dw-hdmi: Refactor hdmi_phy_configure resolution parameter

2016-12-02 Thread Russell King - ARM Linux
On Fri, Dec 02, 2016 at 01:43:26AM +0200, Laurent Pinchart wrote: > From: Kieran Bingham > > The current code hard codes the call of hdmi_phy_configure() to be 8bpp > and provides extraneous error checking to verify that this hardcoded > value is correct. > > Simplify the passing of the data by

[PATCH 11/22] drm: bridge: dw-hdmi: Refactor hdmi_phy_configure resolution parameter

2016-12-01 Thread Laurent Pinchart
From: Kieran Bingham The current code hard codes the call of hdmi_phy_configure() to be 8bpp and provides extraneous error checking to verify that this hardcoded value is correct. Simplify the passing of the data by setting the parameter to be of the enum type it represents rather than convertin