Re: [PATCH 2/2] mmc: host: sh_mobile_sdhi: don't populate unneeded functions

2016-09-09 Thread Ulf Hansson
On 5 September 2016 at 10:18, Wolfram Sang wrote: > >> > It can be argued that this tag could be added: >> > >> > Fixes: 452e5eef6d311e ("mmc: tmio: Add UHS-I mode support") >> > >> > I don't know how well it applies, though, because the code has been >> > modified a lot

Re: [PATCH 2/2] mmc: host: sh_mobile_sdhi: don't populate unneeded functions

2016-09-05 Thread Wolfram Sang
> > It can be argued that this tag could be added: > > > > Fixes: 452e5eef6d311e ("mmc: tmio: Add UHS-I mode support") > > > > I don't know how well it applies, though, because the code has been > > modified a lot recently. But we can try. > > Please tell me if you would like me to drop any of

Re: [PATCH 2/2] mmc: host: sh_mobile_sdhi: don't populate unneeded functions

2016-09-02 Thread Ulf Hansson
On 2 September 2016 at 07:23, Wolfram Sang wrote: > Magnus, > >> To my eye it looks like this patch might be adding a fix for a bug >> introduced by another patch. R-Car Gen2 and later are quite recent >> SoCs but I believe support for other mobile chips and earlier R-Car >>

Re: [PATCH 2/2] mmc: host: sh_mobile_sdhi: don't populate unneeded functions

2016-09-01 Thread Wolfram Sang
Magnus, > To my eye it looks like this patch might be adding a fix for a bug > introduced by another patch. R-Car Gen2 and later are quite recent > SoCs but I believe support for other mobile chips and earlier R-Car > SoCs also also covered by the SDHI driver. Also there are theTMIO > chips that

Re: [PATCH 2/2] mmc: host: sh_mobile_sdhi: don't populate unneeded functions

2016-09-01 Thread Magnus Damm
On Wed, Aug 24, 2016 at 6:34 PM, Wolfram Sang wrote: > Populating card_busy caused a side-effect on a chip variant we don't > have documentation for (r8a73a4). So, enable it and voltage switching > only on devices known to support those features. > >

[PATCH 2/2] mmc: host: sh_mobile_sdhi: don't populate unneeded functions

2016-08-24 Thread Wolfram Sang
Populating card_busy caused a side-effect on a chip variant we don't have documentation for (r8a73a4). So, enable it and voltage switching only on devices known to support those features. Signed-off-by: Wolfram Sang --- drivers/mmc/host/sh_mobile_sdhi.c | 10