Re: [PATCH 2/2] v4l: vsp1: Add HGT support

2016-09-06 Thread Niklas Söderlund
Hi Laurent, Thanks for your review. On 2016-09-05 18:43:58 +0300, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Friday 02 Sep 2016 15:47:14 Niklas Söderlund wrote: > > The HGT is a Histogram Generator Two-Dimensions. It computes a weighted > > frequency histograms

Re: [PATCH 2/2] v4l: vsp1: Add HGT support

2016-09-05 Thread Laurent Pinchart
On Monday 05 Sep 2016 17:57:11 Geert Uytterhoeven wrote: > On Mon, Sep 5, 2016 at 5:43 PM, Laurent Pinchart wrote: > >> + for (n = 0; n < 6; n++) > > > > Nitpicking, the driver uses pre-increment in for loops (++n), not post- > > increment. This used to be a best-practice rule in C++, where >

Re: [PATCH 2/2] v4l: vsp1: Add HGT support

2016-09-05 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Sep 5, 2016 at 5:43 PM, Laurent Pinchart wrote: >> + for (n = 0; n < 6; n++) > > Nitpicking, the driver uses pre-increment in for loops (++n), not post- > increment. This used to be a best-practice rule in C++, where pre-increment > can

Re: [PATCH 2/2] v4l: vsp1: Add HGT support

2016-09-05 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Friday 02 Sep 2016 15:47:14 Niklas Söderlund wrote: > The HGT is a Histogram Generator Two-Dimensions. It computes a weighted > frequency histograms for hue and saturation areas over a configurable > region of the image with optional subsampling. > >

[PATCH 2/2] v4l: vsp1: Add HGT support

2016-09-02 Thread Niklas Söderlund
The HGT is a Histogram Generator Two-Dimensions. It computes a weighted frequency histograms for hue and saturation areas over a configurable region of the image with optional subsampling. Signed-off-by: Niklas Söderlund ---