[PATCH 2/5] media: i2c: max2175: Add MAX2175 support

2016-11-09 Thread Ramesh Shanmugasundaram
This patch adds driver support for MAX2175 chip. This is Maxim Integrated's RF to Bits tuner front end chip designed for software-defined radio solutions. This driver exposes the tuner as a sub-device instance with standard and custom controls to configure the device. Signed-off-by: Ramesh Shanmug

Re: [PATCH 2/5] media: i2c: max2175: Add MAX2175 support

2016-11-10 Thread Antti Palosaari
Hello On 11/09/2016 05:44 PM, Ramesh Shanmugasundaram wrote: +static int max2175_set_lo_freq(struct max2175 *ctx, u64 lo_freq) +{ + u64 scaled_lo_freq, scaled_npf, scaled_integer, scaled_fraction; + u32 frac_desired, int_desired, lo_mult = 1; + const u32 scale_factor = 100

Re: [PATCH 2/5] media: i2c: max2175: Add MAX2175 support

2016-11-11 Thread Laurent Pinchart
Hi Antti, On Friday 11 Nov 2016 09:16:04 Antti Palosaari wrote: > Hello > > On 11/09/2016 05:44 PM, Ramesh Shanmugasundaram wrote: > > +static int max2175_set_lo_freq(struct max2175 *ctx, u64 lo_freq) > > +{ > > + u64 scaled_lo_freq, scaled_npf, scaled_integer, scaled_fraction; > > + u32 frac

Re: [PATCH 2/5] media: i2c: max2175: Add MAX2175 support

2016-11-11 Thread Hans Verkuil
Hi Ramesh, A quick review: On 11/09/2016 04:44 PM, Ramesh Shanmugasundaram wrote: > This patch adds driver support for MAX2175 chip. This is Maxim > Integrated's RF to Bits tuner front end chip designed for software-defined > radio solutions. This driver exposes the tuner as a sub-device instance

Re: [PATCH 2/5] media: i2c: max2175: Add MAX2175 support

2016-11-11 Thread Laurent Pinchart
Hi Hans, On Friday 11 Nov 2016 14:21:22 Hans Verkuil wrote: > On 11/09/2016 04:44 PM, Ramesh Shanmugasundaram wrote: > > This patch adds driver support for MAX2175 chip. This is Maxim > > Integrated's RF to Bits tuner front end chip designed for software-defined > > radio solutions. This driver ex

Re: [PATCH 2/5] media: i2c: max2175: Add MAX2175 support

2016-11-11 Thread Hans Verkuil
On 11/11/2016 02:48 PM, Laurent Pinchart wrote: > Hi Hans, > > On Friday 11 Nov 2016 14:21:22 Hans Verkuil wrote: >> On 11/09/2016 04:44 PM, Ramesh Shanmugasundaram wrote: >>> This patch adds driver support for MAX2175 chip. This is Maxim >>> Integrated's RF to Bits tuner front end chip designed f

RE: [PATCH 2/5] media: i2c: max2175: Add MAX2175 support

2016-11-14 Thread Ramesh Shanmugasundaram
Hi Hans, Thank you for the review comments. > On 11/09/2016 04:44 PM, Ramesh Shanmugasundaram wrote: > > This patch adds driver support for MAX2175 chip. This is Maxim > > Integrated's RF to Bits tuner front end chip designed for > > software-defined radio solutions. This driver exposes the tuner

Re: [PATCH 2/5] media: i2c: max2175: Add MAX2175 support

2016-11-14 Thread Rob Herring
On Wed, Nov 09, 2016 at 03:44:41PM +, Ramesh Shanmugasundaram wrote: > This patch adds driver support for MAX2175 chip. This is Maxim > Integrated's RF to Bits tuner front end chip designed for software-defined > radio solutions. This driver exposes the tuner as a sub-device instance > with sta

RE: [PATCH 2/5] media: i2c: max2175: Add MAX2175 support

2016-11-17 Thread Ramesh Shanmugasundaram
Hi Rob, Thanks for the review comments. > On Wed, Nov 09, 2016 at 03:44:41PM +, Ramesh Shanmugasundaram wrote: > > This patch adds driver support for MAX2175 chip. This is Maxim > > Integrated's RF to Bits tuner front end chip designed for > > software-defined radio solutions. This driver exp