Re: [PATCH 3/4] PCI: rcar: Add missing irq_dispose_mapping() into failpath

2018-05-22 Thread Marek Vasut
On 05/22/2018 05:18 PM, Geert Uytterhoeven wrote: > Hi Marek, Hi, > On Mon, May 21, 2018 at 3:11 PM, Marek Vasut wrote: >> The rcar_pcie_get_resources() is another misnomer with a side effect. >> The function does not only get resources, but also maps MSI IRQs via >> irq_of_parse_and_map(). In c

Re: [PATCH 3/4] PCI: rcar: Add missing irq_dispose_mapping() into failpath

2018-05-22 Thread Geert Uytterhoeven
Hi Marek, On Mon, May 21, 2018 at 3:11 PM, Marek Vasut wrote: > The rcar_pcie_get_resources() is another misnomer with a side effect. > The function does not only get resources, but also maps MSI IRQs via > irq_of_parse_and_map(). In case anything fails afterward, the IRQ > mapping must be dispos

Re: [PATCH 3/4] PCI: rcar: Add missing irq_dispose_mapping() into failpath

2018-05-22 Thread Simon Horman
On Mon, May 21, 2018 at 03:11:22PM +0200, Marek Vasut wrote: > The rcar_pcie_get_resources() is another misnomer with a side effect. > The function does not only get resources, but also maps MSI IRQs via > irq_of_parse_and_map(). In case anything fails afterward, the IRQ > mapping must be disposed

[PATCH 3/4] PCI: rcar: Add missing irq_dispose_mapping() into failpath

2018-05-21 Thread Marek Vasut
The rcar_pcie_get_resources() is another misnomer with a side effect. The function does not only get resources, but also maps MSI IRQs via irq_of_parse_and_map(). In case anything fails afterward, the IRQ mapping must be disposed through irq_dispose_mapping() which is not done. This patch handles