Re: [PATCH 3/4] kms++util: Add verification module

On 18/12/17 17:41, Laurent Pinchart wrote: Hi Tomi, On Monday, 18 December 2017 14:04:45 EET Tomi Valkeinen wrote: On 18/12/17 13:50, Laurent Pinchart wrote: That's an option too. I had a look at the code once to find out how ImageMagick was performing scaling and gave up with a headache soon

Re: [PATCH 3/4] kms++util: Add verification module

Hi Tomi, On Monday, 18 December 2017 14:04:45 EET Tomi Valkeinen wrote: > On 18/12/17 13:50, Laurent Pinchart wrote: > > That's an option too. I had a look at the code once to find out how > > ImageMagick was performing scaling and gave up with a headache soon > > afterwards. We need more formats

Re: [PATCH 3/4] kms++util: Add verification module

Hi Laurent, On Mon, Dec 18, 2017 at 12:50 PM, Laurent Pinchart wrote: > On Monday, 18 December 2017 13:46:22 EET Tomi Valkeinen wrote: >> On 18/12/17 13:36, Laurent Pinchart wrote: >> > The problem with PNG (or any other format really) is that you not only >> >

Re: [PATCH 3/4] kms++util: Add verification module

On 18/12/17 13:50, Laurent Pinchart wrote: That's an option too. I had a look at the code once to find out how ImageMagick was performing scaling and gave up with a headache soon afterwards. We need more formats than what ImageMagick currently supports (it's mostly focused on image file formats

Re: [PATCH 3/4] kms++util: Add verification module

Hi Tomi, On Monday, 18 December 2017 13:46:22 EET Tomi Valkeinen wrote: > On 18/12/17 13:36, Laurent Pinchart wrote: > > The problem with PNG (or any other format really) is that you not only > > need to encode the image into the target format (PNG or JPG would require > > external libraries,

Re: [PATCH 3/4] kms++util: Add verification module

On 16/12/17 18:13, Kieran Bingham wrote: +void save_raw_frame(IFramebuffer& fb, const char *filename) +{ +    unique_ptr os; +    os = unique_ptr(new ofstream(filename, ofstream::binary)); + +    for (unsigned i = 0; i < fb.num_planes(); ++i) +    os->write((char*)fb.map(i), fb.size(i)); +}

Re: [PATCH 3/4] kms++util: Add verification module

On 18/12/17 13:36, Laurent Pinchart wrote: The problem with PNG (or any other format really) is that you not only need to encode the image into the target format (PNG or JPG would require external libraries, simpler formats such as BMP or PNM could be handled internally), but you also need to

Re: [PATCH 3/4] kms++util: Add verification module

Hi Kieran, On Saturday, 16 December 2017 18:13:51 EET Kieran Bingham wrote: > On 15/12/17 13:43, Tomi Valkeinen wrote: > > On 14/12/17 01:10, Kieran Bingham wrote: > >> From: Kieran Bingham > >> > >> Provide a util module to provide helpers involved in

Re: [PATCH 3/4] kms++util: Add verification module

Hi Tomi, Thank you for taking the time to look at this topic. On 15/12/17 13:43, Tomi Valkeinen wrote: > Hi, > > On 14/12/17 01:10, Kieran Bingham wrote: >> From: Kieran Bingham >> >> Provide a util module to provide helpers involved in validation and >>

Re: [PATCH 3/4] kms++util: Add verification module

Hi, On 14/12/17 01:10, Kieran Bingham wrote: From: Kieran Bingham Provide a util module to provide helpers involved in validation and verification of data frames. The first addition is a raw frame binary output with bindings to python modelled on Tomi's

[PATCH 3/4] kms++util: Add verification module

From: Kieran Bingham Provide a util module to provide helpers involved in validation and verification of data frames. The first addition is a raw frame binary output with bindings to python modelled on Tomi's implementation in wbcap. Signed-off-by: Kieran