Re: [PATCH 4/4] PCI: rcar: Teardown MSI setup if rcar_pcie_enable() fails

2018-05-23 Thread Marek Vasut
On 05/23/2018 08:18 AM, Geert Uytterhoeven wrote: > Hi Marek, > > On Tue, May 22, 2018 at 11:53 PM, Marek Vasut wrote: >> On 05/22/2018 08:36 PM, Geert Uytterhoeven wrote: >>> On Mon, May 21, 2018 at 3:11 PM, Marek Vasut wrote: --- a/drivers/pci/host/pcie-rcar.c +++ b/drivers/pci/host/

Re: [PATCH 4/4] PCI: rcar: Teardown MSI setup if rcar_pcie_enable() fails

2018-05-22 Thread Geert Uytterhoeven
Hi Marek, On Tue, May 22, 2018 at 11:53 PM, Marek Vasut wrote: > On 05/22/2018 08:36 PM, Geert Uytterhoeven wrote: >> On Mon, May 21, 2018 at 3:11 PM, Marek Vasut wrote: >>> --- a/drivers/pci/host/pcie-rcar.c >>> +++ b/drivers/pci/host/pcie-rcar.c >>> @@ -900,6 +900,28 @@ static int rcar_pcie_en

Re: [PATCH 4/4] PCI: rcar: Teardown MSI setup if rcar_pcie_enable() fails

2018-05-22 Thread Marek Vasut
On 05/22/2018 08:36 PM, Geert Uytterhoeven wrote: > Hi Marek, > > On Mon, May 21, 2018 at 3:11 PM, Marek Vasut wrote: >> If the rcar_pcie_enable() fails and MSIs are enabled, the setup done in >> rcar_pcie_enable_msi() is never undone. Add a function to tear down the >> MSI setup by disabling the

Re: [PATCH 4/4] PCI: rcar: Teardown MSI setup if rcar_pcie_enable() fails

2018-05-22 Thread Geert Uytterhoeven
Hi Marek, On Mon, May 21, 2018 at 3:11 PM, Marek Vasut wrote: > If the rcar_pcie_enable() fails and MSIs are enabled, the setup done in > rcar_pcie_enable_msi() is never undone. Add a function to tear down the > MSI setup by disabling the MSI handling in the PCIe block, deallocating > the pages r

Re: [PATCH 4/4] PCI: rcar: Teardown MSI setup if rcar_pcie_enable() fails

2018-05-22 Thread Simon Horman
On Mon, May 21, 2018 at 03:11:23PM +0200, Marek Vasut wrote: > If the rcar_pcie_enable() fails and MSIs are enabled, the setup done in > rcar_pcie_enable_msi() is never undone. Add a function to tear down the > MSI setup by disabling the MSI handling in the PCIe block, deallocating > the pages requ

[PATCH 4/4] PCI: rcar: Teardown MSI setup if rcar_pcie_enable() fails

2018-05-21 Thread Marek Vasut
If the rcar_pcie_enable() fails and MSIs are enabled, the setup done in rcar_pcie_enable_msi() is never undone. Add a function to tear down the MSI setup by disabling the MSI handling in the PCIe block, deallocating the pages requested for the MSIs and zapping the IRQ mapping. Signed-off-by: Marek