RE: [PATCH 4/4] serial: sh-sci: Improve support for separate TEI and DRI interrupts

2018-07-30 Thread Chris Brandt
Hi Geert, On Monday, July 30, 2018, Geert Uytterhoeven wrote: > That's not the array, but the enum. > > The array is in struct sci_port: > > int irqs[SCIx_NR_IRQS]; > > It has four entries, at indices 0..3. > irqs[SCIx_NR_IRQS] does not exist! > >

Re: [PATCH 4/4] serial: sh-sci: Improve support for separate TEI and DRI interrupts

2018-07-30 Thread Geert Uytterhoeven
Hi Chris, On Mon, Jul 30, 2018 at 2:33 PM Chris Brandt wrote: > On Monday, July 30, 2018, Geert Uytterhoeven wrote: > > > if (sci_port->irqs[0] < 0) > > > return -ENXIO; > > > > > > - if (sci_port->irqs[1] < 0) { > > > - sci_port->irqs[1] =

Re: [PATCH 4/4] serial: sh-sci: Improve support for separate TEI and DRI interrupts

2018-07-30 Thread Geert Uytterhoeven
Hi Chris, On Fri, Jul 27, 2018 at 11:09 PM Chris Brandt wrote: > Some SCIF versions mux error and break interrupts together and then provide > a separate interrupt ID for just TEI/DRI. > > Allow all 6 types of interrupts to be specified via platform data (or DT) > and for any signals that are

[PATCH 4/4] serial: sh-sci: Improve support for separate TEI and DRI interrupts

2018-07-27 Thread Chris Brandt
Some SCIF versions mux error and break interrupts together and then provide a separate interrupt ID for just TEI/DRI. Allow all 6 types of interrupts to be specified via platform data (or DT) and for any signals that are muxed together (have the same interrupt number) simply register one handler.