Re: [PATCH v2 0/4] watchdog: add driver for Renesas Gen3 WDT watchdogs

2016-05-14 Thread Wim Van Sebroeck
Hi Wolfram, > Here is V2 of this series with the following changes: > > * include bitops.h > * s/unsigned/unsigned int/ > * drop set_timeout() because core does it already > * add get_timeleft() > * don't make "nowayout" a readable parameter > * use "watchdog" instead of "wdt" in the dt bindings

Re: [PATCH v2 0/4] watchdog: add driver for Renesas Gen3 WDT watchdogs

2016-04-04 Thread Wolfram Sang
> > You mean it just hangs ? That is bad. If that is the case, it is not > > reliable > > and thus should be a low priority (or at best medium priority) restart > > handler > > (which can be replaced with a working higher priority one). > > On my Salvator-X board, it hangs. The call into PSCI d

Re: [PATCH v2 0/4] watchdog: add driver for Renesas Gen3 WDT watchdogs

2016-04-04 Thread Guenter Roeck
On Mon, Apr 04, 2016 at 08:14:02PM +0200, Geert Uytterhoeven wrote: > Hi Günter, > > On Mon, Apr 4, 2016 at 7:52 PM, Guenter Roeck wrote: > > On Mon, Apr 04, 2016 at 07:02:45PM +0200, Geert Uytterhoeven wrote: > >> On Mon, Apr 4, 2016 at 5:25 PM, Guenter Roeck wrote: > >> > On Mon, Apr 04, 2016

Re: [PATCH v2 0/4] watchdog: add driver for Renesas Gen3 WDT watchdogs

2016-04-04 Thread Geert Uytterhoeven
Hi Günter, On Mon, Apr 4, 2016 at 7:52 PM, Guenter Roeck wrote: > On Mon, Apr 04, 2016 at 07:02:45PM +0200, Geert Uytterhoeven wrote: >> On Mon, Apr 4, 2016 at 5:25 PM, Guenter Roeck wrote: >> > On Mon, Apr 04, 2016 at 05:21:44PM +0200, Geert Uytterhoeven wrote: >> >> On Mon, Apr 4, 2016 at 4:59

Re: [PATCH v2 0/4] watchdog: add driver for Renesas Gen3 WDT watchdogs

2016-04-04 Thread Guenter Roeck
On Mon, Apr 04, 2016 at 07:02:45PM +0200, Geert Uytterhoeven wrote: > Hi Günter, > > On Mon, Apr 4, 2016 at 5:25 PM, Guenter Roeck wrote: > > On Mon, Apr 04, 2016 at 05:21:44PM +0200, Geert Uytterhoeven wrote: > >> On Mon, Apr 4, 2016 at 4:59 PM, Wolfram Sang wrote: > >> >> My Salvator-X reboots

Re: [PATCH v2 0/4] watchdog: add driver for Renesas Gen3 WDT watchdogs

2016-04-04 Thread Geert Uytterhoeven
Hi Günter, On Mon, Apr 4, 2016 at 5:25 PM, Guenter Roeck wrote: > On Mon, Apr 04, 2016 at 05:21:44PM +0200, Geert Uytterhoeven wrote: >> On Mon, Apr 4, 2016 at 4:59 PM, Wolfram Sang wrote: >> >> My Salvator-X reboots after timeout from "cat > /dev/watchdog0", but >> >> it doesn't reboot through

Re: [PATCH v2 0/4] watchdog: add driver for Renesas Gen3 WDT watchdogs

2016-04-04 Thread Guenter Roeck
On Mon, Apr 04, 2016 at 05:21:44PM +0200, Geert Uytterhoeven wrote: > Hi Wolfram, > > On Mon, Apr 4, 2016 at 4:59 PM, Wolfram Sang wrote: > >> My Salvator-X reboots after timeout from "cat > /dev/watchdog0", but > >> it doesn't reboot through "reboot" or "reboot -f"? > > > > That sadly doesn't wo

Re: [PATCH v2 0/4] watchdog: add driver for Renesas Gen3 WDT watchdogs

2016-04-04 Thread Wolfram Sang
> That's indeed silly. Can't we have it as a low-priority restart handler, to > restart the system if PSCI fails to do so? +1. But my PSCI knowledge is 0. Unlike my task list :/ signature.asc Description: PGP signature

Re: [PATCH v2 0/4] watchdog: add driver for Renesas Gen3 WDT watchdogs

2016-04-04 Thread Geert Uytterhoeven
Hi Wolfram, On Mon, Apr 4, 2016 at 4:59 PM, Wolfram Sang wrote: >> My Salvator-X reboots after timeout from "cat > /dev/watchdog0", but >> it doesn't reboot through "reboot" or "reboot -f"? > > That sadly doesn't work on Gen3. From the RFC v5 cover letter: > === > > * drop restart_handler since

Re: [PATCH v2 0/4] watchdog: add driver for Renesas Gen3 WDT watchdogs

2016-04-04 Thread Wolfram Sang
> My Salvator-X reboots after timeout from "cat > /dev/watchdog0", but > it doesn't reboot through "reboot" or "reboot -f"? > That sadly doesn't work on Gen3. From the RFC v5 cover letter: === * drop restart_handler since ARM64 uses PSCI firmware resets which do not call restart handlers Th

Re: [PATCH v2 0/4] watchdog: add driver for Renesas Gen3 WDT watchdogs

2016-04-04 Thread Geert Uytterhoeven
Hi Wolfram, On Fri, Apr 1, 2016 at 1:56 PM, Wolfram Sang wrote: > Here is V2 of this series with the following changes: > > * include bitops.h > * s/unsigned/unsigned int/ > * drop set_timeout() because core does it already > * add get_timeleft() > * don't make "nowayout" a readable parameter > *

[PATCH v2 0/4] watchdog: add driver for Renesas Gen3 WDT watchdogs

2016-04-01 Thread Wolfram Sang
Here is V2 of this series with the following changes: * include bitops.h * s/unsigned/unsigned int/ * drop set_timeout() because core does it already * add get_timeleft() * don't make "nowayout" a readable parameter * use "watchdog" instead of "wdt" in the dt bindings The dts and defconfig change