Re: [PATCH v2 1/4] pinctrl: sh-pfc: Add physical pin multiplexing helper macros

2018-11-16 Thread Ulrich Hecht
> On November 16, 2018 at 9:42 AM Geert Uytterhoeven > wrote: > > > Hi Uli, > > On Fri, Nov 16, 2018 at 8:21 AM Ulrich Hecht wrote: > > Used by I2C controllers 0, 3 and 5 in R8A7795 and R8A7796 SoCs. > > > > Signed-off-by: Ulrich Hecht > > Thanks for your patch! > > Reviewed-by: Geert Uy

Re: [PATCH v2 1/4] pinctrl: sh-pfc: Add physical pin multiplexing helper macros

2018-11-16 Thread Geert Uytterhoeven
Hi Uli, On Fri, Nov 16, 2018 at 8:21 AM Ulrich Hecht wrote: > Used by I2C controllers 0, 3 and 5 in R8A7795 and R8A7796 SoCs. > > Signed-off-by: Ulrich Hecht Thanks for your patch! Reviewed-by: Geert Uytterhoeven Some bikeshedding below, which I believe would increase readability. > --- a/d

[PATCH v2 1/4] pinctrl: sh-pfc: Add physical pin multiplexing helper macros

2018-11-15 Thread Ulrich Hecht
Used by I2C controllers 0, 3 and 5 in R8A7795 and R8A7796 SoCs. Signed-off-by: Ulrich Hecht --- drivers/pinctrl/sh-pfc/sh_pfc.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h b/drivers/pinctrl/sh-pfc/sh_pfc.h index 1fc1336..6bb9c6b 100