[PATCH v2 3/3] nvram: at24c: use standard error reporting

2018-03-19 Thread Wolfram Sang
Replace the ERR macro with error_report() because fprintf is deprecated. This also fixes the prefix printed out twice. Signed-off-by: Wolfram Sang --- hw/nvram/eeprom_at24c.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/hw/nvram/eeprom_at24c.c b/hw/nvram

Re: [PATCH v2 3/3] nvram: at24c: use standard error reporting

2018-03-19 Thread Philippe Mathieu-Daudé
On 03/19/2018 10:31 PM, Wolfram Sang wrote: > Replace the ERR macro with error_report() because fprintf is deprecated. > This also fixes the prefix printed out twice. > > Signed-off-by: Wolfram Sang > --- > hw/nvram/eeprom_at24c.c | 17 ++--- > 1 file changed, 6 insertions(+), 11 del

Re: [Qemu-devel] [PATCH v2 3/3] nvram: at24c: use standard error reporting

2018-03-19 Thread Eric Blake
On 03/19/2018 04:31 PM, Wolfram Sang wrote: Replace the ERR macro with error_report() because fprintf is deprecated. This also fixes the prefix printed out twice. Signed-off-by: Wolfram Sang --- hw/nvram/eeprom_at24c.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-)

Re: [Qemu-devel] [PATCH v2 3/3] nvram: at24c: use standard error reporting

2018-03-19 Thread Wolfram Sang
> > -ERR(TYPE_AT24C_EE > > -" : failed to write backing file\n"); > > +error_report("failed to write backing file\n"); > > Drop the \n here and elsewhere in your patch; error_report() already does > that for you. Darn, I haven't installed m