Re: [PATCH v2 4/4] mmc: host: tmio: fill in response from auto cmd12

2017-02-16 Thread Ulf Hansson
On 16 February 2017 at 09:37, Wolfram Sang wrote: > Hi Ulf, > > On Thu, Feb 16, 2017 at 08:57:36AM +0100, Ulf Hansson wrote: >> On 15 February 2017 at 16:02, Wolfram Sang wrote: >> > >> >> > I see. Ulf, do you think it makes sense to extend the condition when to >> >> > call mmc_blk_cmd_recovery(

Re: [PATCH v2 4/4] mmc: host: tmio: fill in response from auto cmd12

2017-02-16 Thread Wolfram Sang
Hi Ulf, On Thu, Feb 16, 2017 at 08:57:36AM +0100, Ulf Hansson wrote: > On 15 February 2017 at 16:02, Wolfram Sang wrote: > > > >> > I see. Ulf, do you think it makes sense to extend the condition when to > >> > call mmc_blk_cmd_recovery() with checking if stop.resp[0] has one of the > >> > R1_* b

Re: [PATCH v2 4/4] mmc: host: tmio: fill in response from auto cmd12

2017-02-15 Thread Ulf Hansson
On 15 February 2017 at 16:02, Wolfram Sang wrote: > >> > I see. Ulf, do you think it makes sense to extend the condition when to >> > call mmc_blk_cmd_recovery() with checking if stop.resp[0] has one of the >> > R1_* bits set which are marked with 'ex' (and probably 'erx', too)? I >> > agree with

Re: [PATCH v2 4/4] mmc: host: tmio: fill in response from auto cmd12

2017-02-15 Thread Wolfram Sang
> > I see. Ulf, do you think it makes sense to extend the condition when to > > call mmc_blk_cmd_recovery() with checking if stop.resp[0] has one of the > > R1_* bits set which are marked with 'ex' (and probably 'erx', too)? I > > agree with Shimoda-san, that the core is a good place to do it, sin

Re: [PATCH v2 4/4] mmc: host: tmio: fill in response from auto cmd12

2017-02-15 Thread Ulf Hansson
On 14 February 2017 at 11:52, Wolfram Sang wrote: > Shimoda-san, Ulf, > > On Tue, Feb 14, 2017 at 10:06:47AM +, Yoshihiro Shimoda wrote: >> Hi, >> >> > From: Wolfram Sang [mailto:wsa+rene...@sang-engineering.com] >> > Sent: Tuesday, February 14, 2017 3:04 AM >> > >> > After we received the dat

Re: [PATCH v2 4/4] mmc: host: tmio: fill in response from auto cmd12

2017-02-14 Thread Wolfram Sang
Shimoda-san, Ulf, On Tue, Feb 14, 2017 at 10:06:47AM +, Yoshihiro Shimoda wrote: > Hi, > > > From: Wolfram Sang [mailto:wsa+rene...@sang-engineering.com] > > Sent: Tuesday, February 14, 2017 3:04 AM > > > > After we received the dataend interrupt, R1 response register carries > > the value f

RE: [PATCH v2 4/4] mmc: host: tmio: fill in response from auto cmd12

2017-02-14 Thread Yoshihiro Shimoda
Hi, > From: Wolfram Sang [mailto:wsa+rene...@sang-engineering.com] > Sent: Tuesday, February 14, 2017 3:04 AM > > After we received the dataend interrupt, R1 response register carries > the value from the automatically generated stop command. Report that > info back to the MMC block layer, so we

[PATCH v2 4/4] mmc: host: tmio: fill in response from auto cmd12

2017-02-13 Thread Wolfram Sang
After we received the dataend interrupt, R1 response register carries the value from the automatically generated stop command. Report that info back to the MMC block layer, so we will be notified in case of e.g. ECC errors which happened during the last transfer. Reviewed-by: Simon Horman Signed-