Re: [PATCH v2 7/9] mmc: sh_mobile_sdhi: Add UHS-I mode support

2016-04-04 Thread Wolfram Sang
> > Okay, so this delay can go. > > > > Thanks for the clarification. I will amend the patch, no need for you > to send a new version! Thanks a lot! signature.asc Description: PGP signature

Re: [PATCH v2 7/9] mmc: sh_mobile_sdhi: Add UHS-I mode support

2016-04-04 Thread Ulf Hansson
On 4 April 2016 at 17:17, Wolfram Sang wrote: > >> > + usleep_range(5000, 5500); >> >> Why do you need this delay/sleep? > > My datasheet says to wait at least 5ms before re-enabling the clock > after a voltage switch... > > Ah, found it in the core. It is doing it for 10ms. Maybe my search

Re: [PATCH v2 7/9] mmc: sh_mobile_sdhi: Add UHS-I mode support

2016-04-04 Thread Wolfram Sang
> > + usleep_range(5000, 5500); > > Why do you need this delay/sleep? My datasheet says to wait at least 5ms before re-enabling the clock after a voltage switch... Ah, found it in the core. It is doing it for 10ms. Maybe my search pattern was not fuzzy enough ;) Okay, so this delay can g

Re: [PATCH v2 7/9] mmc: sh_mobile_sdhi: Add UHS-I mode support

2016-04-04 Thread Ulf Hansson
On 1 April 2016 at 17:44, Wolfram Sang wrote: > From: Wolfram Sang > > Implement voltage switch, supporting modes up to SDR-50. > > Based on work by Shinobu Uehara, Rob Taylor, William Towle and Ian Molton. > > Signed-off-by: Ben Hutchings > Signed-off-by: Wolfram Sang > --- > Documentation/de

[PATCH v2 7/9] mmc: sh_mobile_sdhi: Add UHS-I mode support

2016-04-01 Thread Wolfram Sang
From: Wolfram Sang Implement voltage switch, supporting modes up to SDR-50. Based on work by Shinobu Uehara, Rob Taylor, William Towle and Ian Molton. Signed-off-by: Ben Hutchings Signed-off-by: Wolfram Sang --- Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 3 ++ drivers/mmc/host/sh_