RE: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-11-01 Thread Chris Brandt
> > I don't understand "TMIO_MMC_BIG_DATA_PORT" (How do you know 32-bit?? > How do you know 64-bit??) > > I think 16 << host->bus_shift should work; need to verify this, though. Good idea.

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-11-01 Thread Wolfram Sang
> I don't understand "TMIO_MMC_BIG_DATA_PORT" (How do you know 32-bit?? How do > you know 64-bit??) I think 16 << host->bus_shift should work; need to verify this, though. > So..maybe you can change it later and your idea will be more clear to me > then. Yes, fine with me. signature.asc

RE: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-11-01 Thread Chris Brandt
Hi Wolfram, > Okay, I have a sketch how to add this feature to R-Car SoCs at a later > stage. This patch is fine with one minor nit which can be done now or I > can do it later when I add the R-Car support. > > > + * Some controllers have a 32-bit wide data port register */ > > +#define TMIO_MM

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-11-01 Thread Wolfram Sang
Hi Chris, On Mon, Sep 12, 2016 at 10:15:06AM -0400, Chris Brandt wrote: > For the r7s72100 SOC, the DATA_PORT register was changed to 32-bits wide. > Therefore a new flag has been created that will allow 32-bit reads/writes > to the DATA_PORT register instead of 16-bit (because 16-bits accesses ar

RE: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-24 Thread Chris Brandt
> > > This SWAP register exists on R-Car as well. Out of curiosity, what > > > is the register value of 0xE804E0E4? > > > > 0xE804E0E4 = 0x0001 > > > > So...something is there! > > I am quite convinced there is this BUSWIDTH register. If you are > interested, try setting this to 0 and see if it wo

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-24 Thread Wolfram Sang
On Mon, Oct 24, 2016 at 01:06:38PM +0200, Geert Uytterhoeven wrote: > Hi Wolfram, > > On Fri, Oct 21, 2016 at 11:56 PM, Wolfram Sang wrote: > >> For the VERSION register, the low byte is the version of the IP, but > >> the upper byte is a number that the design group that made the part > > > > I

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-24 Thread Geert Uytterhoeven
Hi Wolfram, On Fri, Oct 21, 2016 at 11:56 PM, Wolfram Sang wrote: >> For the VERSION register, the low byte is the version of the IP, but >> the upper byte is a number that the design group that made the part > > I know. It is just that I haven't seen this one "in the wild" so far. I think you c

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-21 Thread Wolfram Sang
> For the VERSION register, the low byte is the version of the IP, but > the upper byte is a number that the design group that made the part I know. It is just that I haven't seen this one "in the wild" so far. > > This SWAP register exists on R-Car as well. Out of curiosity, what is the > > reg

RE: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-21 Thread Chris Brandt
> > > * Does it have a version register (CTL_VERSION)? If so, what does it > > > say? > > > > 0x820B > > Okay, this is a version I have not seen before. The SDHI IP came from the SH7269 (SH-2A device). For the VERSION register, the low byte is the version of the IP, but the upper byte is a nu

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-20 Thread Wolfram Sang
> However, for version 3.0 that will be posted shortly, it will start to > include the SDHI section. Nice. Could you ping me when this comes out? > > * Does it have a version register (CTL_VERSION)? If so, what does it > > say? > > 0x820B Okay, this is a version I have not seen before. > >

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-20 Thread Wolfram Sang
> I'll submit a v4 of this patch series tomorrow. Please wait a little. I'd like to use that feature on R-Car, too, so I wonder if the additional feature flag is the proper path. signature.asc Description: PGP signature

RE: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-20 Thread Chris Brandt
Hello Wolfram, > > > + /* if count was multiple of 4 */ > > > + if (!(count & 0x3)) > > > + return; > > > + buf8 = (u8 *)(buf + (count >> 2)); > > > + count %= 4; > > > > To skip the same operation done on 'count' twice, maybe? > > > > bu

RE: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-20 Thread Chris Brandt
On 10/20/2016, Wolfram Sang wrote: > Sadly, I don't have SDHI documentation for this SoC. In the current hardware manual on renesas.com, the SHDI section is not included. However, for version 3.0 that will be posted shortly, it will start to include the SDHI section. > * Does it have a version

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-20 Thread Wolfram Sang
On Mon, Sep 12, 2016 at 10:15:06AM -0400, Chris Brandt wrote: > For the r7s72100 SOC, the DATA_PORT register was changed to 32-bits wide. > Therefore a new flag has been created that will allow 32-bit reads/writes > to the DATA_PORT register instead of 16-bit (because 16-bits accesses are > not sup

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-17 Thread Wolfram Sang
> > Is this still waiting on an ACK from Lee Jones because it touches the > > tmio.h file under include/linux/mfd/ ? > > > > Yes, but more important is Wolfram's ack as he maintains > drivers/mmc/host/tmio_mmc* Sorry, LinuxCon and ELC Europe kept me very busy. Will do this week. signature.as

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-17 Thread Ulf Hansson
nes >> Subject: Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port >> >> + Lee >> >> On 12 September 2016 at 16:15, Chris Brandt >> wrote: >> > For the r7s72100 SOC, the DATA_PORT register was changed to 32-bits wide. >> > Th

RE: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-14 Thread Chris Brandt
On 9/22/2016, Ulf Hansson wrote: > To: Chris Brandt > Cc: Wolfram Sang ; Sergei Shtylyov > ; Geert Uytterhoeven m68k.org>; Simon Horman ; linux-mmc m...@vger.kernel.org>; Linux-Renesas ; > Lee Jones > Subject: Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data po

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-09-22 Thread Ulf Hansson
+ Lee On 12 September 2016 at 16:15, Chris Brandt wrote: > For the r7s72100 SOC, the DATA_PORT register was changed to 32-bits wide. > Therefore a new flag has been created that will allow 32-bit reads/writes > to the DATA_PORT register instead of 16-bit (because 16-bits accesses are > not suppor

[PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-09-12 Thread Chris Brandt
For the r7s72100 SOC, the DATA_PORT register was changed to 32-bits wide. Therefore a new flag has been created that will allow 32-bit reads/writes to the DATA_PORT register instead of 16-bit (because 16-bits accesses are not supported). Signed-off-by: Chris Brandt --- v3: * changed loops to memc