Re: [PATCH v4 2/4] mmc: tmio: Add tuning support

2016-09-01 Thread Simon Horman
On Thu, Sep 01, 2016 at 11:55:27AM +0200, Ulf Hansson wrote: > On 1 September 2016 at 10:37, Simon Horman wrote: > > On Thu, Sep 01, 2016 at 08:46:44AM +0200, Simon Horman wrote: > >> On Wed, Aug 31, 2016 at 09:38:40AM +0200, Ulf Hansson wrote: > >> > On 30 August 2016 at

Re: [PATCH v4 2/4] mmc: tmio: Add tuning support

2016-09-01 Thread Ulf Hansson
On 1 September 2016 at 10:37, Simon Horman wrote: > On Thu, Sep 01, 2016 at 08:46:44AM +0200, Simon Horman wrote: >> On Wed, Aug 31, 2016 at 09:38:40AM +0200, Ulf Hansson wrote: >> > On 30 August 2016 at 22:51, Simon Horman wrote: >> > > On Mon, Aug 29,

Re: [PATCH v4 2/4] mmc: tmio: Add tuning support

2016-09-01 Thread Simon Horman
On Thu, Sep 01, 2016 at 08:46:44AM +0200, Simon Horman wrote: > On Wed, Aug 31, 2016 at 09:38:40AM +0200, Ulf Hansson wrote: > > On 30 August 2016 at 22:51, Simon Horman wrote: > > > On Mon, Aug 29, 2016 at 04:05:55PM +0200, Ulf Hansson wrote: > > >> On 29 August 2016 at

Re: [PATCH v4 2/4] mmc: tmio: Add tuning support

2016-08-31 Thread Ulf Hansson
On 30 August 2016 at 22:51, Simon Horman wrote: > On Mon, Aug 29, 2016 at 04:05:55PM +0200, Ulf Hansson wrote: >> On 29 August 2016 at 14:05, Simon Horman wrote: >> > On Fri, Aug 26, 2016 at 10:01:35AM +0200, Ulf Hansson wrote: >> >> On 25 August 2016 at

Re: [PATCH v4 2/4] mmc: tmio: Add tuning support

2016-08-30 Thread Simon Horman
On Mon, Aug 29, 2016 at 04:05:55PM +0200, Ulf Hansson wrote: > On 29 August 2016 at 14:05, Simon Horman wrote: > > On Fri, Aug 26, 2016 at 10:01:35AM +0200, Ulf Hansson wrote: > >> On 25 August 2016 at 14:04, Simon Horman wrote: > >> > On Tue, Aug 23, 2016

Re: [PATCH v4 2/4] mmc: tmio: Add tuning support

2016-08-29 Thread Ulf Hansson
On 29 August 2016 at 14:05, Simon Horman wrote: > On Fri, Aug 26, 2016 at 10:01:35AM +0200, Ulf Hansson wrote: >> On 25 August 2016 at 14:04, Simon Horman wrote: >> > On Tue, Aug 23, 2016 at 05:02:56PM +0200, Ulf Hansson wrote: > > ... > >> >> >> I am

Re: [PATCH v4 2/4] mmc: tmio: Add tuning support

2016-08-29 Thread Simon Horman
On Fri, Aug 26, 2016 at 10:01:35AM +0200, Ulf Hansson wrote: > On 25 August 2016 at 14:04, Simon Horman wrote: > > On Tue, Aug 23, 2016 at 05:02:56PM +0200, Ulf Hansson wrote: ... > >> >> I am wondering whether it would it be possible to keep a cache of the > >> >> currently

Re: [PATCH v4 2/4] mmc: tmio: Add tuning support

2016-08-26 Thread Ulf Hansson
On 25 August 2016 at 14:04, Simon Horman wrote: > On Tue, Aug 23, 2016 at 05:02:56PM +0200, Ulf Hansson wrote: >> [...] >> >> >> > +static int tmio_mmc_execute_tuning(struct mmc_host *mmc, u32 opcode) >> >> > +{ >> >> > + struct tmio_mmc_host *host = mmc_priv(mmc); >> >>

Re: [PATCH v4 2/4] mmc: tmio: Add tuning support

2016-08-25 Thread Simon Horman
On Tue, Aug 23, 2016 at 05:02:56PM +0200, Ulf Hansson wrote: > [...] > > >> > +static int tmio_mmc_execute_tuning(struct mmc_host *mmc, u32 opcode) > >> > +{ > >> > + struct tmio_mmc_host *host = mmc_priv(mmc); > >> > + unsigned int num; > >> > + int i, ret = 0; > >> > +

Re: [PATCH v4 2/4] mmc: tmio: Add tuning support

2016-08-22 Thread Ulf Hansson
On 27 July 2016 at 06:13, Simon Horman wrote: > From: Ai Kyuse > > Add tuning support for use with SDR104 mode > > Signed-off-by: Ai Kyuse > Signed-off-by: Simon Horman > --- > v4 [Simon

Re: [PATCH v4 2/4] mmc: tmio: Add tuning support

2016-08-10 Thread Wolfram Sang
> +static int tmio_mmc_execute_tuning(struct mmc_host *mmc, u32 opcode) > +{ > + struct tmio_mmc_host *host = mmc_priv(mmc); > + unsigned int num; > + int i, ret = 0; > + bool *tap; > + > + if (!host->init_tuning || !host->select_tuning) Check host->prepare_tuning, too? > +

[PATCH v4 2/4] mmc: tmio: Add tuning support

2016-07-26 Thread Simon Horman
From: Ai Kyuse Add tuning support for use with SDR104 mode Signed-off-by: Ai Kyuse Signed-off-by: Simon Horman --- v4 [Simon Horman] As suggested by Wolfram Sang: - Do not perform tuning if host->select_tuning is