Re: [PATCH v5 03/11] soc: renesas: rcar-sysc: Add DT support for SYSC PM domains

2016-04-20 Thread Ulf Hansson
On 20 April 2016 at 10:24, Geert Uytterhoeven wrote: > Hi Ulf, > > On Mon, Apr 18, 2016 at 4:02 PM, Ulf Hansson wrote: >> On 18 April 2016 at 15:39, Geert Uytterhoeven wrote: >>> On Mon, Apr 18, 2016 at 2:59 PM, Geert

Re: [PATCH v5 03/11] soc: renesas: rcar-sysc: Add DT support for SYSC PM domains

2016-04-20 Thread Geert Uytterhoeven
Hi Ulf, On Mon, Apr 18, 2016 at 4:02 PM, Ulf Hansson wrote: > On 18 April 2016 at 15:39, Geert Uytterhoeven wrote: >> On Mon, Apr 18, 2016 at 2:59 PM, Geert Uytterhoeven >> wrote: >>> On Mon, Apr 18, 2016 at 2:21 PM, Ulf

Re: [PATCH v5 03/11] soc: renesas: rcar-sysc: Add DT support for SYSC PM domains

2016-04-18 Thread Ulf Hansson
On 18 April 2016 at 15:39, Geert Uytterhoeven wrote: > Hi Ulf, > > On Mon, Apr 18, 2016 at 2:59 PM, Geert Uytterhoeven > wrote: >> On Mon, Apr 18, 2016 at 2:21 PM, Ulf Hansson wrote: >>> [...] >>> + +static bool

Re: [PATCH v5 03/11] soc: renesas: rcar-sysc: Add DT support for SYSC PM domains

2016-04-18 Thread Geert Uytterhoeven
Hi Ulf, On Mon, Apr 18, 2016 at 2:21 PM, Ulf Hansson wrote: > [...] > >> + >> +static bool rcar_sysc_active_wakeup(struct device *dev) >> +{ >> + return true; > > I am interested to know why this is always returning true. Perhaps you > can elaborate a bit on that?

Re: [PATCH v5 03/11] soc: renesas: rcar-sysc: Add DT support for SYSC PM domains

2016-04-18 Thread Ulf Hansson
[...] > + > +static bool rcar_sysc_active_wakeup(struct device *dev) > +{ > + return true; I am interested to know why this is always returning true. Perhaps you can elaborate a bit on that? > +} > + > +static int rcar_sysc_pd_power_off(struct generic_pm_domain *genpd) > +{ > +