Re: [PATCH v5 2/3] mmc: sh_mobile_sdhi: explain clock bindings

2017-01-27 Thread Ulf Hansson
On 26 January 2017 at 15:39, Rob Herring wrote: > On Mon, Jan 23, 2017 at 11:56 AM, Chris Brandt > wrote: >> Hello Rob, >> >> >> On Monday, January 23, 2017, Rob Herring wrote: >>> > --- a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt >>> > +++

RE: [PATCH v5 2/3] mmc: sh_mobile_sdhi: explain clock bindings

2017-01-26 Thread Chris Brandt
On Thursday, January 26, 2017, Rob Herring wrote: > >> > + > >> > +Example showing 2 clocks: > >> > + sdhi0: sd@e804e000 { > >> > >> mmc@... > > > > I'm confused. I see that for all SDHI controllers, it either "sd@" or > "sdhci@". > > > > $ grep sdhi $(find arch/arm/boot/dts -name "*.dtsi") > >

Re: [PATCH v5 2/3] mmc: sh_mobile_sdhi: explain clock bindings

2017-01-26 Thread Rob Herring
On Mon, Jan 23, 2017 at 11:56 AM, Chris Brandt wrote: > Hello Rob, > > > On Monday, January 23, 2017, Rob Herring wrote: >> > --- a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt >> > +++ b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt >> > @@ -25,8 +25,32 @@

RE: [PATCH v5 2/3] mmc: sh_mobile_sdhi: explain clock bindings

2017-01-23 Thread Chris Brandt
Hello Rob, On Monday, January 23, 2017, Rob Herring wrote: > > --- a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt > > +++ b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt > > @@ -25,8 +25,32 @@ Required properties: > > "renesas,sdhi-r8a7795" - SDHI IP on R8A7795 SoC > >

Re: [PATCH v5 2/3] mmc: sh_mobile_sdhi: explain clock bindings

2017-01-23 Thread Rob Herring
On Fri, Jan 20, 2017 at 10:06:03PM -0500, Chris Brandt wrote: > In the case of a single clock source, you don't need names. However, > if the controller has 2 clock sources, you need to name them correctly > so the driver can find the 2nd one. The 2nd clock is for the internal > card detect logic.

Re: [PATCH v5 2/3] mmc: sh_mobile_sdhi: explain clock bindings

2017-01-21 Thread Wolfram Sang
On Fri, Jan 20, 2017 at 10:06:03PM -0500, Chris Brandt wrote: > In the case of a single clock source, you don't need names. However, > if the controller has 2 clock sources, you need to name them correctly > so the driver can find the 2nd one. The 2nd clock is for the internal > card detect logic.

[PATCH v5 2/3] mmc: sh_mobile_sdhi: explain clock bindings

2017-01-20 Thread Chris Brandt
In the case of a single clock source, you don't need names. However, if the controller has 2 clock sources, you need to name them correctly so the driver can find the 2nd one. The 2nd clock is for the internal card detect logic. Signed-off-by: Chris Brandt --- v4: *