Re: [PATCHv2] [media] rcar-vin: add Renesas R-Car VIN driver

2016-04-02 Thread Niklas Söderlund
Hi Hans, Thanks again for your review! I have addressed your comments in v3 which I just posted but there where a few things I just wanted to answer in this thread. On 2016-02-29 10:52:25 +0100, Hans Verkuil wrote: > Hi Niklas, > > Thanks for your patch! Much appreciated. > > I have more comm

Re: [PATCHv2] [media] rcar-vin: add Renesas R-Car VIN driver

2016-03-11 Thread Niklas Söderlund
On 2016-03-11 22:04:17 +0100, Hans Verkuil wrote: > On 03/11/2016 09:55 PM, Niklas Söderlund wrote: > > On 2016-03-11 12:16:30 +0100, Hans Verkuil wrote: > >> On 03/11/2016 12:03 PM, Niklas Söderlund wrote: > >>> Hi Hans, > >>> > >>> On 2016-03-11 09:26:48 +0100, Hans Verkuil wrote: > Hi Nikla

Re: [PATCHv2] [media] rcar-vin: add Renesas R-Car VIN driver

2016-03-11 Thread Hans Verkuil
On 03/11/2016 09:55 PM, Niklas Söderlund wrote: > On 2016-03-11 12:16:30 +0100, Hans Verkuil wrote: >> On 03/11/2016 12:03 PM, Niklas Söderlund wrote: >>> Hi Hans, >>> >>> On 2016-03-11 09:26:48 +0100, Hans Verkuil wrote: Hi Niklas, On 02/29/2016 10:52 AM, Hans Verkuil wrote: > H

Re: [PATCHv2] [media] rcar-vin: add Renesas R-Car VIN driver

2016-03-11 Thread Niklas Söderlund
On 2016-03-11 12:16:30 +0100, Hans Verkuil wrote: > On 03/11/2016 12:03 PM, Niklas Söderlund wrote: > > Hi Hans, > > > > On 2016-03-11 09:26:48 +0100, Hans Verkuil wrote: > >> Hi Niklas, > >> > >> On 02/29/2016 10:52 AM, Hans Verkuil wrote: > >>> Hi Niklas, > >>> > >>> Thanks for your patch! Much

Re: [PATCHv2] [media] rcar-vin: add Renesas R-Car VIN driver

2016-03-11 Thread Hans Verkuil
On 03/11/2016 12:03 PM, Niklas Söderlund wrote: > Hi Hans, > > On 2016-03-11 09:26:48 +0100, Hans Verkuil wrote: >> Hi Niklas, >> >> On 02/29/2016 10:52 AM, Hans Verkuil wrote: >>> Hi Niklas, >>> >>> Thanks for your patch! Much appreciated. >>> >>> I have more comments for the v2, but nothing real

Re: [PATCHv2] [media] rcar-vin: add Renesas R-Car VIN driver

2016-03-11 Thread Niklas Söderlund
Hi Hans, On 2016-03-11 09:26:48 +0100, Hans Verkuil wrote: > Hi Niklas, > > On 02/29/2016 10:52 AM, Hans Verkuil wrote: > > Hi Niklas, > > > > Thanks for your patch! Much appreciated. > > > > I have more comments for the v2, but nothing really big :-) > > > > Just checking, you are working on

Re: [PATCHv2] [media] rcar-vin: add Renesas R-Car VIN driver

2016-03-11 Thread Hans Verkuil
Hi Niklas, On 02/29/2016 10:52 AM, Hans Verkuil wrote: > Hi Niklas, > > Thanks for your patch! Much appreciated. > > I have more comments for the v2, but nothing really big :-) > Just checking, you are working on a v3, right? I'd really like to get this in for kernel 4.7. Regards, Ha

Re: [PATCHv2] [media] rcar-vin: add Renesas R-Car VIN driver

2016-02-29 Thread Hans Verkuil
Hi Niklas, Thanks for your patch! Much appreciated. I have more comments for the v2, but nothing really big :-) One high-level comment I have is that you should create an rcar-v4l2.c (or video.c) source where all the v4l2 ioctls and file ops reside. Most of what is in rcar-dma has nothing to d

Re: [PATCHv2] [media] rcar-vin: add Renesas R-Car VIN driver

2016-02-27 Thread Hans Verkuil
On 02/27/2016 06:21 PM, Niklas Söderlund wrote: > Hi Hans, > > On 2016-02-27 12:32:14 +0100, Hans Verkuil wrote: >> On 02/24/2016 03:58 AM, Niklas Söderlund wrote: >>> A V4L2 driver for Renesas R-Car VIN driver that do not depend on >>> soc_camera. The driver is heavily based on its predecessor an

Re: [PATCHv2] [media] rcar-vin: add Renesas R-Car VIN driver

2016-02-27 Thread Niklas Söderlund
Hi Hans, On 2016-02-27 12:32:14 +0100, Hans Verkuil wrote: > On 02/24/2016 03:58 AM, Niklas Söderlund wrote: > > A V4L2 driver for Renesas R-Car VIN driver that do not depend on > > soc_camera. The driver is heavily based on its predecessor and aims to > > replace it. > > > > Signed-off-by: Nikla

Re: [PATCHv2] [media] rcar-vin: add Renesas R-Car VIN driver

2016-02-27 Thread Hans Verkuil
On 02/24/2016 03:58 AM, Niklas Söderlund wrote: > A V4L2 driver for Renesas R-Car VIN driver that do not depend on > soc_camera. The driver is heavily based on its predecessor and aims to > replace it. > > Signed-off-by: Niklas Söderlund > --- > > The driver is tested on Koelsch and can do strea

[PATCHv2] [media] rcar-vin: add Renesas R-Car VIN driver

2016-02-23 Thread Niklas Söderlund
A V4L2 driver for Renesas R-Car VIN driver that do not depend on soc_camera. The driver is heavily based on its predecessor and aims to replace it. Signed-off-by: Niklas Söderlund --- The driver is tested on Koelsch and can do streaming using qv4l2 and grab frames using yavta. It passes a v4l2-c