Re: [PATCHv3 4/6] pinctrl: sh-pfc: r8a7795: Use lookup function for bias data

2016-11-15 Thread Geert Uytterhoeven
On Sun, Nov 13, 2016 at 2:48 AM, Laurent Pinchart wrote: > Except for the bias_info for which I trust your regexp skills, $ cat ~/.gitconfig ... [alias] wdiff = diff --color-words wshow = show --color-words and "git wshow" shows no mistakes

Re: [PATCHv3 4/6] pinctrl: sh-pfc: r8a7795: Use lookup function for bias data

2016-11-12 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Saturday 12 Nov 2016 17:04:27 Niklas Söderlund wrote: > There is a bug in the r8a7795 bias code where a WARN() is trigged > anytime a pin from PUEN0/PUD0is accessed. > > # cat /sys/kernel/debug/pinctrl/e606.pfc/pinconf-pins > > WARNING: CPU: 2 PID:

[PATCHv3 4/6] pinctrl: sh-pfc: r8a7795: Use lookup function for bias data

2016-11-12 Thread Niklas Söderlund
There is a bug in the r8a7795 bias code where a WARN() is trigged anytime a pin from PUEN0/PUD0is accessed. # cat /sys/kernel/debug/pinctrl/e606.pfc/pinconf-pins WARNING: CPU: 2 PID: 2391 at drivers/pinctrl/sh-pfc/pfc-r8a7795.c:5364 r8a7795_pinmux_get_bias+0xbc/0xc8 [..] Call trace: []