Re: [Qemu-devel] [PATCH 1/3] nvram: at24c: remove doubled prefix for ERR

2018-03-13 Thread Wolfram Sang
> > -ERR(TYPE_AT24C_EE > > -" : failed to write backing file\n"); > > +ERR("failed to write backing file\n"); > > printf/fprintf are deprecated, since you are modifying this file can you > use a newer API, "qemu/error-report.h" for example.

Re: [Qemu-devel] [PATCH 1/3] nvram: at24c: remove doubled prefix for ERR

2018-03-13 Thread Philippe Mathieu-Daudé
Hi Wolfram, On 03/12/2018 10:42 PM, Wolfram Sang wrote: > The ERR macro already has the TYPE_AT24C_EE prefix, no need to repeat in > the error message. > > Signed-off-by: Wolfram Sang > --- > hw/nvram/eeprom_at24c.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff -