RE: [RFC] watchdog: renesas_wdt: don't keep timer value during suspend/resume

2018-12-10 Thread Fabrizio Castro
> From: Wolfram Sang > Sent: 04 December 2018 12:02 > Subject: [RFC] watchdog: renesas_wdt: don't keep timer value during > suspend/resume > > After discussing this mail thread [1] again, we concluded that giving > userspace enough time to prepare is our favourite opt

RE: [RFC] watchdog: renesas_wdt: don't keep timer value during suspend/resume

2018-12-10 Thread Fabrizio Castro
Hello Guenter, > From: Guenter Roeck On Behalf Of Guenter Roeck > Sent: 10 December 2018 14:24 > Subject: Re: [RFC] watchdog: renesas_wdt: don't keep timer value during > suspend/resume > > On 12/10/18 1:37 AM, Fabrizio Castro wrote: > > Hello Guenter, > > >

Re: [RFC] watchdog: renesas_wdt: don't keep timer value during suspend/resume

2018-12-10 Thread Guenter Roeck
On 12/10/18 1:37 AM, Fabrizio Castro wrote: Hello Guenter, From: Guenter Roeck On Behalf Of Guenter Roeck Sent: 09 December 2018 18:13 Subject: Re: [RFC] watchdog: renesas_wdt: don't keep timer value during suspend/resume On 12/9/18 8:36 AM, Wolfram Sang wrote: Hi Guenter, I can r

RE: [RFC] watchdog: renesas_wdt: don't keep timer value during suspend/resume

2018-12-10 Thread Fabrizio Castro
Hello Wolfram, > From: Wolfram Sang > Sent: 07 December 2018 21:45 > Subject: Re: [RFC] watchdog: renesas_wdt: don't keep timer value during > suspend/resume > > Hi Guenter, all, > > > > After discussing this mail thread [1] again, we concluded that giving >

RE: [RFC] watchdog: renesas_wdt: don't keep timer value during suspend/resume

2018-12-10 Thread Fabrizio Castro
Hello Guenter, > From: Guenter Roeck On Behalf Of Guenter Roeck > Sent: 09 December 2018 18:13 > Subject: Re: [RFC] watchdog: renesas_wdt: don't keep timer value during > suspend/resume > > On 12/9/18 8:36 AM, Wolfram Sang wrote: > > Hi Guenter, > > > &

Re: [RFC] watchdog: renesas_wdt: don't keep timer value during suspend/resume

2018-12-09 Thread Wolfram Sang
> I understand, but what is the use case behind it ? If the watchdog I'll leave this discussion to Fabrizio... > I'd rather clarify in the documentation that watchdog drivers are expected > to ping the watchdog after resume, ie that restarting the watchdog after > resume should be handled like s

Re: [RFC] watchdog: renesas_wdt: don't keep timer value during suspend/resume

2018-12-09 Thread Guenter Roeck
On 12/9/18 8:36 AM, Wolfram Sang wrote: Hi Guenter, I can relate to the policy argument, though. Regardless of this patch, I wonder if we can make it configurable from userspace. A draft: #define WDIOF_RESUME_OPTS 0x0800 #define WDIOS_RESUME_KEEP 0x0008 #define WDIOS_RESUME_RESET

Re: [RFC] watchdog: renesas_wdt: don't keep timer value during suspend/resume

2018-12-09 Thread Wolfram Sang
Hi Guenter, > > I can relate to the policy argument, though. Regardless of this patch, I > > wonder if we can make it configurable from userspace. A draft: > > > > #define WDIOF_RESUME_OPTS 0x0800 > > > > #define WDIOS_RESUME_KEEP 0x0008 > > #define WDIOS_RESUME_RESET

Re: [RFC] watchdog: renesas_wdt: don't keep timer value during suspend/resume

2018-12-08 Thread Guenter Roeck
On 12/7/18 1:45 PM, Wolfram Sang wrote: Hi Guenter, all, After discussing this mail thread [1] again, we concluded that giving userspace enough time to prepare is our favourite option. So, do not keep the time value when suspended but reset it when resuming. [1] https://patchwork.kernel.org/pa

Re: [RFC] watchdog: renesas_wdt: don't keep timer value during suspend/resume

2018-12-07 Thread Wolfram Sang
Hi Guenter, all, > > After discussing this mail thread [1] again, we concluded that giving > > userspace enough time to prepare is our favourite option. So, do not > > keep the time value when suspended but reset it when resuming. > > > > [1] https://patchwork.kernel.org/patch/10252209/ > > > >

Re: [RFC] watchdog: renesas_wdt: don't keep timer value during suspend/resume

2018-12-04 Thread Guenter Roeck
On 12/4/18 4:01 AM, Wolfram Sang wrote: After discussing this mail thread [1] again, we concluded that giving userspace enough time to prepare is our favourite option. So, do not keep the time value when suspended but reset it when resuming. [1] https://patchwork.kernel.org/patch/10252209/ Sign

RE: [RFC] watchdog: renesas_wdt: don't keep timer value during suspend/resume

2018-12-04 Thread Fabrizio Castro
Hello Wolfram, > From: Wolfram Sang > Sent: 04 December 2018 12:02 > Subject: [RFC] watchdog: renesas_wdt: don't keep timer value during > suspend/resume > > After discussing this mail thread [1] again, we concluded that giving > userspace enough time to prepare is ou

Re: [RFC] watchdog: renesas_wdt: don't keep timer value during suspend/resume

2018-12-04 Thread Geert Uytterhoeven
On Tue, Dec 4, 2018 at 1:02 PM Wolfram Sang wrote: > After discussing this mail thread [1] again, we concluded that giving > userspace enough time to prepare is our favourite option. So, do not > keep the time value when suspended but reset it when resuming. > > [1] https://patchwork.kernel.org/pa

[RFC] watchdog: renesas_wdt: don't keep timer value during suspend/resume

2018-12-04 Thread Wolfram Sang
After discussing this mail thread [1] again, we concluded that giving userspace enough time to prepare is our favourite option. So, do not keep the time value when suspended but reset it when resuming. [1] https://patchwork.kernel.org/patch/10252209/ Signed-off-by: Wolfram Sang --- Fabrizio: ca