On Sat, Jun 16, 2018 at 09:56:36PM +0900, Wolfram Sang wrote:
> It seems that during the conversion from gpio* to gpiod*, the initial
> state of SCL was wrongly switched to LOW. Fix it to be HIGH again.
>
> Fixes: 7bb75029ef34 ("i2c: gpio: Enforce open drain through gpiolib")
> Signed-off-by:
> Looks like a mistake on my part. Mea culpa :(
No worries...
> Luckily it is functionally mostly harmless, but to
> conserve power, it is better to initialize this as high (lest
> we dissipate power throught the pull-up resistor), so please queue
> this as a fix and also tag for stable.
>
On Mon, Jun 25, 2018 at 4:30 PM Wolfram Sang wrote:
> On Sat, Jun 16, 2018 at 09:56:36PM +0900, Wolfram Sang wrote:
> > It seems that during the conversion from gpio* to gpiod*, the initial
> > state of SCL was wrongly switched to LOW. Fix it to be HIGH again.
> >
> > Fixes: 7bb75029ef34 ("i2c:
On Sat, Jun 16, 2018 at 09:56:36PM +0900, Wolfram Sang wrote:
> It seems that during the conversion from gpio* to gpiod*, the initial
> state of SCL was wrongly switched to LOW. Fix it to be HIGH again.
>
> Fixes: 7bb75029ef34 ("i2c: gpio: Enforce open drain through gpiolib")
> Signed-off-by:
Hi Wolfram,
On Sat, Jun 16, 2018 at 2:57 PM Wolfram Sang
wrote:
> It seems that during the conversion from gpio* to gpiod*, the initial
> state of SCL was wrongly switched to LOW. Fix it to be HIGH again.
>
> Fixes: 7bb75029ef34 ("i2c: gpio: Enforce open drain through gpiolib")
> Signed-off-by:
It seems that during the conversion from gpio* to gpiod*, the initial
state of SCL was wrongly switched to LOW. Fix it to be HIGH again.
Fixes: 7bb75029ef34 ("i2c: gpio: Enforce open drain through gpiolib")
Signed-off-by: Wolfram Sang
---
Linus: Or was it intentional? But then I am missing