Re: [RFC PATCH] i2c: gpio: initialize SCL to HIGH again

2018-06-29 Thread Wolfram Sang
On Sat, Jun 16, 2018 at 09:56:36PM +0900, Wolfram Sang wrote: > It seems that during the conversion from gpio* to gpiod*, the initial > state of SCL was wrongly switched to LOW. Fix it to be HIGH again. > > Fixes: 7bb75029ef34 ("i2c: gpio: Enforce open drain through gpiolib") > Signed-off-by:

Re: [RFC PATCH] i2c: gpio: initialize SCL to HIGH again

2018-06-26 Thread Wolfram Sang
> Looks like a mistake on my part. Mea culpa :( No worries... > Luckily it is functionally mostly harmless, but to > conserve power, it is better to initialize this as high (lest > we dissipate power throught the pull-up resistor), so please queue > this as a fix and also tag for stable. >

Re: [RFC PATCH] i2c: gpio: initialize SCL to HIGH again

2018-06-26 Thread Linus Walleij
On Mon, Jun 25, 2018 at 4:30 PM Wolfram Sang wrote: > On Sat, Jun 16, 2018 at 09:56:36PM +0900, Wolfram Sang wrote: > > It seems that during the conversion from gpio* to gpiod*, the initial > > state of SCL was wrongly switched to LOW. Fix it to be HIGH again. > > > > Fixes: 7bb75029ef34 ("i2c:

Re: [RFC PATCH] i2c: gpio: initialize SCL to HIGH again

2018-06-25 Thread Wolfram Sang
On Sat, Jun 16, 2018 at 09:56:36PM +0900, Wolfram Sang wrote: > It seems that during the conversion from gpio* to gpiod*, the initial > state of SCL was wrongly switched to LOW. Fix it to be HIGH again. > > Fixes: 7bb75029ef34 ("i2c: gpio: Enforce open drain through gpiolib") > Signed-off-by:

Re: [RFC PATCH] i2c: gpio: initialize SCL to HIGH again

2018-06-18 Thread Geert Uytterhoeven
Hi Wolfram, On Sat, Jun 16, 2018 at 2:57 PM Wolfram Sang wrote: > It seems that during the conversion from gpio* to gpiod*, the initial > state of SCL was wrongly switched to LOW. Fix it to be HIGH again. > > Fixes: 7bb75029ef34 ("i2c: gpio: Enforce open drain through gpiolib") > Signed-off-by:

[RFC PATCH] i2c: gpio: initialize SCL to HIGH again

2018-06-16 Thread Wolfram Sang
It seems that during the conversion from gpio* to gpiod*, the initial state of SCL was wrongly switched to LOW. Fix it to be HIGH again. Fixes: 7bb75029ef34 ("i2c: gpio: Enforce open drain through gpiolib") Signed-off-by: Wolfram Sang --- Linus: Or was it intentional? But then I am missing