RE: [RFC PATCH] mmc: renesas_sdhi_internal_dmac: fall back to PIO if scatterlist doesn't match

2018-04-06 Thread Yoshihiro Shimoda
Hi Wolfram-san, Thank you for the patch! > From: Wolfram Sang, Sent: Thursday, April 5, 2018 2:01 AM > > From: Wolfram Sang > > If we detect an incompatible scatterlist, we should fall back to PIO, > too. > > Signed-off-by: Wolfram Sang > --- > > I found this while working on the RX DMA iss

Re: [RFC PATCH] mmc: renesas_sdhi_internal_dmac: fall back to PIO if scatterlist doesn't match

2018-04-05 Thread Wolfram Sang
> > - /* This DMAC cannot handle if sg_len is not 1 */ > > - WARN_ON(host->sg_len > 1); > > - > > - /* This DMAC cannot handle if buffer is not 8-bytes alignment */ > > - if (!IS_ALIGNED(sg->offset, 8)) > > + if (WARN_ON(host->sg_len > 1) || !IS_ALIGNED(sg->offset, 8)

Re: [RFC PATCH] mmc: renesas_sdhi_internal_dmac: fall back to PIO if scatterlist doesn't match

2018-04-05 Thread Ulf Hansson
On 4 April 2018 at 19:00, Wolfram Sang wrote: > From: Wolfram Sang > > If we detect an incompatible scatterlist, we should fall back to PIO, > too. > > Signed-off-by: Wolfram Sang > --- > > I found this while working on the RX DMA issue. I don't see a reason why we > shouldn't fall back in this

[RFC PATCH] mmc: renesas_sdhi_internal_dmac: fall back to PIO if scatterlist doesn't match

2018-04-04 Thread Wolfram Sang
From: Wolfram Sang If we detect an incompatible scatterlist, we should fall back to PIO, too. Signed-off-by: Wolfram Sang --- I found this while working on the RX DMA issue. I don't see a reason why we shouldn't fall back in this case as well. But maybe I am missing something. Shimoda-san: wh