Re: [RFC PATCH] watchdog: HACK: disable bind attributes with NOWAYOUT

2018-08-28 Thread Wolfram Sang
> void watchdog_set_nowayout(struct watchdog_device *wdd, struct driver > *drv, bool nowayout) > > I'd think this would work from a layering perspective. No, this is also bogus. probe() works per device, and .suppress_bind_attrs works per driver. We need to tackle this

Re: [RFC PATCH] watchdog: HACK: disable bind attributes with NOWAYOUT

2018-08-28 Thread Wolfram Sang
Hi Guenter, > > - if (nowayout) > > + if (nowayout) { > > set_bit(WDOG_NO_WAY_OUT, >status); > > + wdd->parent->driver->suppress_bind_attrs = true; > > That makes sense to me. We can not assume that wdd->parent is set, so it > won't work as-is. Good point! > Not sure

Re: [RFC PATCH] watchdog: HACK: disable bind attributes with NOWAYOUT

2018-08-28 Thread Guenter Roeck
On 08/28/2018 03:29 AM, Wolfram Sang wrote: With NOWAYOUT, prevent bind/unbind possibilities in SYSFS. Proof-of-concept, not for upstream yet. Signed-off-by: Wolfram Sang --- So, this is really an RFC to check if something like this is considered useful or not. If so, we probably need to do

[RFC PATCH] watchdog: HACK: disable bind attributes with NOWAYOUT

2018-08-28 Thread Wolfram Sang
With NOWAYOUT, prevent bind/unbind possibilities in SYSFS. Proof-of-concept, not for upstream yet. Signed-off-by: Wolfram Sang --- So, this is really an RFC to check if something like this is considered useful or not. If so, we probably need to do it differently because modifying the parent's