Re: [RFT] mmc: tmio: fix CMD12 (STOP) handling

2017-07-11 Thread Wolfram Sang
On Tue, Jul 11, 2017 at 04:43:28PM +0200, Ulf Hansson wrote: > On 3 July 2017 at 21:28, Wolfram Sang > wrote: > > I always anticipated this code to be not correct, but now I had a test > > case to prove it. According to all documentation I have, setting the > >

Re: [RFT] mmc: tmio: fix CMD12 (STOP) handling

2017-07-11 Thread Ulf Hansson
On 3 July 2017 at 21:28, Wolfram Sang wrote: > I always anticipated this code to be not correct, but now I had a test > case to prove it. According to all documentation I have, setting the > TMIO_STOP_STP bit ever only worked during block transfers. This bit is >

Re: [RFT] mmc: tmio: fix CMD12 (STOP) handling

2017-07-07 Thread Wolfram Sang
> Tested-by: Nguyen Viet Dung Great! Thank you very much! signature.asc Description: PGP signature

RE: [RFT] mmc: tmio: fix CMD12 (STOP) handling

2017-07-06 Thread Yoshihiro Shimoda
Hi Wolfram-san, > -Original Message- > From: Wolfram Sang > Sent: Thursday, July 6, 2017 3:39 PM > > > I and Dung-san are testing this patch. > > However, this original code doesn't run by our test cases. > > Do you know how this original code runs? > > Anyway, we will try to make a test

Re: [RFT] mmc: tmio: fix CMD12 (STOP) handling

2017-07-06 Thread Wolfram Sang
> I and Dung-san are testing this patch. > However, this original code doesn't run by our test cases. > Do you know how this original code runs? > Anyway, we will try to make a test case somehow now. Thank you very much, Shimoda-san. I got it tested because a card needed re-tuning during a

RE: [RFT] mmc: tmio: fix CMD12 (STOP) handling

2017-07-05 Thread Yoshihiro Shimoda
Hi Wolfram-san, > -Original Message- > From: Wolfram Sang > Sent: Tuesday, July 4, 2017 4:28 AM > > I always anticipated this code to be not correct, but now I had a test > case to prove it. According to all documentation I have, setting the > TMIO_STOP_STP bit ever only worked during

Re: [RFT] mmc: tmio: fix CMD12 (STOP) handling

2017-07-04 Thread Geert Uytterhoeven
Hi Wolfram, On Mon, Jul 3, 2017 at 9:28 PM, Wolfram Sang wrote: > I always anticipated this code to be not correct, but now I had a test > case to prove it. According to all documentation I have, setting the > TMIO_STOP_STP bit ever only worked during block

Re: [RFT] mmc: tmio: fix CMD12 (STOP) handling

2017-07-04 Thread jan.kloet...@preh.de
On Mon, Jul 03, 2017 at 09:28:23PM +0200, Wolfram Sang wrote: > I always anticipated this code to be not correct, but now I had a test > case to prove it. According to all documentation I have, setting the > TMIO_STOP_STP bit ever only worked during block transfers. This bit is > like manually

[RFT] mmc: tmio: fix CMD12 (STOP) handling

2017-07-03 Thread Wolfram Sang
I always anticipated this code to be not correct, but now I had a test case to prove it. According to all documentation I have, setting the TMIO_STOP_STP bit ever only worked during block transfers. This bit is like manually enforcing an autocmd12 during a so far seamless transfer. It does NOT