Re: ASoC: rsnd: fix sound route path when using SRC6/SRC9

2017-05-17 Thread Kuninori Morimoto
Hi Geert > >> I guess the main question is: can src be NULL here? > >> If yes, rsnd_mod_id(src) will be -1. > > > > No. cmd itself will not be used if src was NULL on this HW. > > But gcc cannot know that, as the function is called through a function > pointer from another source file. Yes, I a

Re: ASoC: rsnd: fix sound route path when using SRC6/SRC9

2017-05-17 Thread Geert Uytterhoeven
Hi Morimoto-san, On Wed, May 17, 2017 at 9:38 AM, Kuninori Morimoto wrote: >> > Hmm >> > I tried random code/compile, but gcc behavior seems strange. >> > Fore example if I removed next line, this warning disappeard >> > >> > - data = path[rsnd_mod_id(src)] | >> > -

Re: ASoC: rsnd: fix sound route path when using SRC6/SRC9

2017-05-17 Thread Kuninori Morimoto
Hi Geert > > Hmm > > I tried random code/compile, but gcc behavior seems strange. > > Fore example if I removed next line, this warning disappeard > > > > - data = path[rsnd_mod_id(src)] | > > - cmd_case[rsnd_mod_id(src)] << 16; > > + data = p

Re: ASoC: rsnd: fix sound route path when using SRC6/SRC9

2017-05-17 Thread Geert Uytterhoeven
Hi Morimoto-san, On Wed, May 17, 2017 at 3:32 AM, Kuninori Morimoto wrote: >> > @@ -70,16 +71,19 @@ static int rsnd_cmd_init(struct rsnd_mod *mod, >> > } else { >> > struct rsnd_mod *src = rsnd_io_to_mod_src(io); >> > >> > - u32 path[] = { >> > -

Re: ASoC: rsnd: fix sound route path when using SRC6/SRC9

2017-05-16 Thread Kuninori Morimoto
Hi Geert > > @@ -70,16 +71,19 @@ static int rsnd_cmd_init(struct rsnd_mod *mod, > > } else { > > struct rsnd_mod *src = rsnd_io_to_mod_src(io); > > > > - u32 path[] = { > > - [0] = 0x3, > > - [1] = 0x30001, > >

Re: ASoC: rsnd: fix sound route path when using SRC6/SRC9

2017-05-16 Thread Geert Uytterhoeven
a8 > Refname:refs/heads/master > Author: Hiroyuki Yokoyama > AuthorDate: Wed Mar 1 03:51:00 2017 + > Committer: Mark Brown > CommitDate: Mon Mar 13 12:58:07 2017 +0000 > > ASoC: rsnd: fix sound route path when using SRC6/SRC9 > > This patch fixes th