Re: [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-19 Thread Simon Horman
On Tue, Apr 19, 2016 at 09:18:55AM +0200, Geert Uytterhoeven wrote: > On Wed, Apr 6, 2016 at 2:52 PM, Sjoerd Simons > wrote: > > clk_get on a disabled clock node will return EPROBE_DEFER, which can > > cause drivers to be deferred forever if such clocks are referenced in > > their clocks property.

Re: [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-19 Thread Geert Uytterhoeven
On Wed, Apr 6, 2016 at 2:52 PM, Sjoerd Simons wrote: > clk_get on a disabled clock node will return EPROBE_DEFER, which can > cause drivers to be deferred forever if such clocks are referenced in > their clocks property. > > Update the various disabled external clock nodes to default to a > freque

Re: [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-13 Thread Stephen Boyd
On 04/08, Sjoerd Simons wrote: > On Thu, 2016-04-07 at 16:21 -0700, Stephen Boyd wrote: > > On 04/06, Sjoerd Simons wrote: > > > > > > Though even so I'm not sure what the convention is for clocks like > > > these, the r8a7791.dtsi is inconsistent, as some are disabled while > > > others (e.g. the

RE: [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-08 Thread Phil Edworthy
Hi, On 07 April 2016 20:14, Sergei Shtylyov wrote: > On 04/07/2016 10:00 AM, Sjoerd Simons wrote: > > > Hey Sergei, > > > > Thanks for your review. > > You're welcome. :-) > > > On Thu, 2016-04-07 at 02:15 +0300, Sergei Shtylyov wrote: > >> On 04/06/2016 03:52 PM, Sjoerd Simons wrote: > >>

Re: [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-08 Thread Sjoerd Simons
On Thu, 2016-04-07 at 16:21 -0700, Stephen Boyd wrote: > On 04/06, Sjoerd Simons wrote: > > > > On Wed, 2016-04-06 at 15:11 +0200, Geert Uytterhoeven wrote: > > > > > > CC Mike, Stephen, linux-clk (this time with the new Mike) > > > > > > On Wed, Apr 6, 2016 at 2:52 PM, Sjoerd Simons > > > wrot

Re: [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-07 Thread Stephen Boyd
On 04/06, Sjoerd Simons wrote: > On Wed, 2016-04-06 at 15:11 +0200, Geert Uytterhoeven wrote: > > CC Mike, Stephen, linux-clk (this time with the new Mike) > > > > On Wed, Apr 6, 2016 at 2:52 PM, Sjoerd Simons > > wrote: > > > > > > clk_get on a disabled clock node will return EPROBE_DEFER, whic

Re: [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-07 Thread Sergei Shtylyov
Hello. On 04/07/2016 10:00 AM, Sjoerd Simons wrote: Hey Sergei, Thanks for your review. You're welcome. :-) On Thu, 2016-04-07 at 02:15 +0300, Sergei Shtylyov wrote: On 04/06/2016 03:52 PM, Sjoerd Simons wrote: clk_get on a disabled clock node will return EPROBE_DEFER, which can cau

Re: [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-07 Thread Sjoerd Simons
Hey Sergei, Thanks for your review. On Thu, 2016-04-07 at 02:15 +0300, Sergei Shtylyov wrote: > On 04/06/2016 03:52 PM, Sjoerd Simons wrote: > > > > > clk_get on a disabled clock node will return EPROBE_DEFER, which > > can > > cause drivers to be deferred forever if such clocks are referenced

Re: [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-06 Thread Sergei Shtylyov
On 04/06/2016 03:52 PM, Sjoerd Simons wrote: clk_get on a disabled clock node will return EPROBE_DEFER, which can cause drivers to be deferred forever if such clocks are referenced in their clocks property. Update the various disabled external clock nodes to default to a frequency of 0, but don

Re: [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-06 Thread Sjoerd Simons
On Wed, 2016-04-06 at 15:11 +0200, Geert Uytterhoeven wrote: > CC Mike, Stephen, linux-clk (this time with the new Mike) > > On Wed, Apr 6, 2016 at 2:52 PM, Sjoerd Simons > wrote: > > > > clk_get on a disabled clock node will return EPROBE_DEFER, which > > can > > cause drivers to be deferred fo

Re: [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-06 Thread Geert Uytterhoeven
CC Mike, Stephen, linux-clk (this time with the new Mike) On Wed, Apr 6, 2016 at 2:52 PM, Sjoerd Simons wrote: > clk_get on a disabled clock node will return EPROBE_DEFER, which can > cause drivers to be deferred forever if such clocks are referenced in > their clocks property. Is this a side ef

Re: [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks

2016-04-06 Thread Geert Uytterhoeven
CC Mike, Stephen, linux-clk On Wed, Apr 6, 2016 at 2:52 PM, Sjoerd Simons wrote: > clk_get on a disabled clock node will return EPROBE_DEFER, which can > cause drivers to be deferred forever if such clocks are referenced in > their clocks property. Is this a side effect of commit 3e5dd6f6e690048