Hi Chris,
On Thu, Sep 6, 2018 at 4:31 PM Chris Brandt wrote:
> > What about other clocks: BSCCLK, OCTCLK, HYPCLK, and SPICLK?
>
> At this time, I'm considering them 'out of scope' from this driver as
> they really need to be set up early in device boot (ie, u-boot).
> Unless you were just thinkin
Hi Geert,
Thanks for your review.
On Thursday, September 06, 2018, Geert Uytterhoeven wrote:
> > +#define CPG_FRQCR 0x00
> > +#define CPG_CKIOSEL0xF0
> > +#define CPG_SCLKSEL0xF4
>
> The last two are unused?
In this driver they are not. I can remove them.
> > +
> > +#define PORTL
Hi Chris,
On Wed, Aug 29, 2018 at 3:29 PM Chris Brandt wrote:
> Add support for the R7S9210 (RZ/A2) Clock Pulse Generator and Module
> Standby.
Thanks for your patch!
> The Module Standby HW in the RZ/A series is very close to R-Car HW, except
> for how the registers are laid out.
> The MSTP re
Hi Geert,
On Wednesday, September 05, 2018 1, Geert Uytterhoeven wrote:
> > SoI guess I didn't really have an issue after all.
>
> You do want to:
> 1. Document the two register ranges in the DT bindings,
> 2. Update the driver to map both ranges on RZ/A2.
The driver does not need to be
Hi Chris,
On Wed, Sep 5, 2018 at 5:02 PM Chris Brandt wrote:
> On Wednesday, September 05, 2018 1, Geert Uytterhoeven wrote:
> > > So, I think I need to rework this driver to add the ability to add
> > > multiple address regions.
> >
> > Your main driver for this block (clock?) can register the w
Hi Geert,
On Wednesday, September 05, 2018 1, Geert Uytterhoeven wrote:
> > So, I think I need to rework this driver to add the ability to add
> > multiple address regions.
>
> Your main driver for this block (clock?) can register the watchdog.
> Either directly with the watchdog subsystem, or by
Hi Chris,
On Wed, Sep 5, 2018 at 4:12 PM Chris Brandt wrote:
> On Wednesday, August 29, 2018, Chris Brandt wrote:
> > Add support for the R7S9210 (RZ/A2) Clock Pulse Generator and Module
> > Standby.
>
> I ran into an issue with this driver.
>
> The issue is that the registers needed for this dri
Hi Geert,
On Wednesday, August 29, 2018, Chris Brandt wrote:
>
> Add support for the R7S9210 (RZ/A2) Clock Pulse Generator and Module
> Standby.
I ran into an issue with this driver.
The issue is that the registers needed for this driver are scattered
throughout the address space.
I can't jus
