Re: [PATCH v3 2/3] mmc: renesas_sdhi_internal_dmac: Add R7S9210 support

2018-10-12 Thread Wolfram Sang
> Even after you pointed that out...I had to stare real hard to see it. I > guess the brain corrects what you see. Yes. c57d3e7a9391 ("i2c-dev: Fix typo in ioctl name reference") fixed something in 2015 which was around forever. I had to look twice at this patch as well. > I was getting informa

RE: [PATCH v3 2/3] mmc: renesas_sdhi_internal_dmac: Add R7S9210 support

2018-10-12 Thread Chris Brandt
Hi Wolfram, On Friday, October 12, 2018, Wolfram Sang wrote: > > +/* RZ/A2 does not have the ADRR_MODE bit */ > > +#define SDHI_INTERNAL_DMAC_ADRR_MODE_FIXED 2 > > First, there is a typo: s/ADRR/ADDR/g Thanks! Even after you pointed that out...I had to stare real hard to see it. I guess the br

Re: [PATCH v3 2/3] mmc: renesas_sdhi_internal_dmac: Add R7S9210 support

2018-10-12 Thread Wolfram Sang
Hi Chris, > +/* RZ/A2 does not have the ADRR_MODE bit */ > +#define SDHI_INTERNAL_DMAC_ADRR_MODE_FIXED 2 First, there is a typo: s/ADRR/ADDR/g Also, I think it would make the code much more comprehensible if this macro was named SDHI_INTERNAL_DMAC_ADDR_MODE_BROKEN. Or maybe SDHI_INTERNAL_DMAC_FI