RE: [PATCH v4 2/6] pinctrl: sh-pfc: r8a77470: Add SDHI support

2018-10-17 Thread Fabrizio Castro
Hello Simon, Thank you for your feedback. > > > > +static int r8a77470_pin_to_pocctrl(struct sh_pfc *pfc, unsigned int pin, > > + u32 *pocctrl) > > +{ > > +int bit = -EINVAL; > > + > > +*pocctrl = 0xe60600b0; > > + > > +if (pin >= RCAR_GP_PIN(0, 5) && pin <= RCAR_GP_PIN(0, 10)) > > +bit = 0; >

Re: [PATCH v4 2/6] pinctrl: sh-pfc: r8a77470: Add SDHI support

2018-10-17 Thread Simon Horman
On Tue, Oct 16, 2018 at 11:33:43AM +0100, Fabrizio Castro wrote: > Add SH_PFC_PIN_CFG_IO_VOLTAGE definition for the SDHI pins > capable of switching voltage, also add pin groups and functions > for SDHI0 and SDHI1. Please note that with the RZ/G1C only 1 > bit of the POC Control Register is used