On Mon, Apr 03, 2017 at 10:37:42AM +0200, Takashi Iwai wrote:
> Ah, I see that snd_soc_unregister_card() has the check of
> card->instantiated, so it should be fine to call multiple times.
Yeah, we'd run into that often enough that it's worth handling nicely.
signature.asc
Description: PGP sign
On Fri, Mar 31, 2017 at 09:48:02AM +0200, Takashi Iwai wrote:
> Mark Brown wrote:
> > flag directly when we see a problem call a function to do it. That way
> > if we want to improve things in the future we can do that without having
> > to update the callers again.
> BTW, ALSA core has snd_card
On Mon, 03 Apr 2017 10:26:05 +0200,
Kuninori Morimoto wrote:
>
>
> Hi Takashi-san
>
> > > So, we can call snd_soc_unregister_card() whenever CPU/Codec/Platform
> > > were unregsiterd.
> >
> > In theory yes, but you should be careful to do so, e.g. make sure that
> > it won't be called again by
Hi Takashi-san
> > So, we can call snd_soc_unregister_card() whenever CPU/Codec/Platform
> > were unregsiterd.
>
> In theory yes, but you should be careful to do so, e.g. make sure that
> it won't be called again by the removal/unbind of other components /
> drivers.
>
> I suggested snd_card_di
On Mon, 03 Apr 2017 08:29:34 +0200,
Kuninori Morimoto wrote:
>
>
> Hi Takashi-san
>
> > > I think this is a good direction to at least start to mitigate these
> > > problems (which we really should be doing) and hopefully make it easier
> > > to do further improvements in future. There's obviou
Hi Takashi-san
> > I think this is a good direction to at least start to mitigate these
> > problems (which we really should be doing) and hopefully make it easier
> > to do further improvements in future. There's obviously more places
> > where we should be checking the flag (controls for examp
On Thu, 30 Mar 2017 23:53:34 +0200,
Mark Brown wrote:
>
> On Wed, Mar 29, 2017 at 02:45:37AM +, Kuninori Morimoto wrote:
>
> > To avoid Sound Card crash in (2) case, what we can do now is, add dirty
> > flag on Sound Card, and avoid to open Sound Card.
> > This patch solved this issue.
>
> I