Hi Hans,
On 03/07/17 15:45, Kieran Bingham wrote:
> Hi Hans,
>
> Thanks for your review,
>
> On 03/07/17 14:51, Hans Verkuil wrote:
>> On 06/27/2017 05:03 PM, Kieran Bingham wrote:
>>> From: Kieran Bingham
>>>
>>
On 05/07/17 10:43, Geert Uytterhoeven wrote:
> On Tue, Jun 27, 2017 at 5:15 PM, Kieran Bingham wrote:
>> From: Kieran Bingham
>>
>> The Salvator boards use an ADV7482 receiver for HDMI and CVBS inputs.
>>
>> Provide ADV7482 node on the i2c4 bus, along with co
From: Kieran Bingham
This is a driver for the Analog Devices ADV748x device, and follows on from a
previous posting by Niklas Söderlund [0] of an earlier incarnation of this
driver, and earlier versions posted by myself.
ADV748x
===
The ADV7481 and ADV7482 support two video pipelines which
From: Kieran Bingham
Create device tree bindings documentation for the ADV748x.
The ADV748x supports both the ADV7481 and ADV7482 chips which
provide analogue decoding and HDMI receiving capabilities
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
v6:
- Clean up description
From: Kieran Bingham
Provide support for the ADV7481 and ADV7482.
The driver is modelled with 4 subdevices to allow simultaneous streaming
from the AFE (Analog front end) and HDMI inputs though two CSI TX
entities.
The HDMI entity is linked to the TXA CSI bus, whilst the AFE is linked
to the
From: Kieran Bingham
The ADV7481 is an integrated video decoder and combined HDMI/MHL
receiver.
Signed-off-by: Kieran Bingham
Acked-by: Laurent Pinchart
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index c4be6d4af7d2..741da59b133a 100644
@@
> e.ops = &i@p;
>
> @bad@
> position p != {r.p,ok.p};
> identifier r.i;
> struct vb2_ops e;
> @@
> e@i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
> struct vb2_ops i = { ... };
>
> Signed-o
r vertical blanking when stopping a
> CRTC, as there's no need to reconfigure plane assignment at that point.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Kieran Bingham
> ---
> drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 31 ---
>
by two. Fix it by moving back to the VBK interrupt.
>
> Fixes: 906eff7fcada ("drm: rcar-du: Implement support for interlaced modes")
> Signed-off-by: Laurent Pinchart
Of course, this looks much more correct than the patch I submitted :-)
Reviewed-by: Kieran Bingham
&
p the boards the same but is not connected in the chip.
Anyway, that's irrelevant to this patch so ...
On 21/06/17 10:04, Laurent Pinchart wrote:
> Update the device description with the HDMI output.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Kieran Bingham
> ---
>
Hi Geert,
> Indeed.
>
> BTW, the M3-W version also has unconnected USB3 and SATA connectors.
Thanks for the heads up :) - I've just put a post it note over those, +HDMI1-OUT
(or rather the text on the top lid) to prevent any confusion for me down the
line.
--
Kieran
- so either with or
without those changes, feel free to add my:
Reviewed-by: Kieran Bingham
> ---
> drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 66
> --
> drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 4 +--
> drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2
with the
> kernel coding style are introduced, fix all multiline comments in one
> go.
>
> Signed-off-by: Laurent Pinchart
Acked-by: Kieran Bingham
> ---
> drivers/gpu/drm/rcar-du/rcar_du_crtc.c| 24 --
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 21 ++
Hi Laurent,
Thankyou for these patches, bringing life to the outputs of my ES2.0 target
board.
I have tested them on my board, and including the VSP unit test suite, and
kmscube utilities.
Feel free to add a Tested-by: Kieran Bingham
to all of the patches if you desire,
and I'm wo
t; the headers without holding the lock.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Kieran Bingham
> ---
> drivers/media/platform/vsp1/vsp1_dl.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/vsp1/vsp1_dl
tion code already handles this correctly without
> referring to the sink pointer, which thus doesn't need to be set.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Kieran Bingham
> ---
> drivers/media/platform/vsp1/vsp1_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
p1_entity instances, we can store the
> vsp1_entity pointers directly.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by: Kieran Bingham
> ---
> drivers/media/platform/vsp1/vsp1_drm.c| 4 ++--
> drivers/media/platform/vsp1/vsp1_drv.c| 2 +-
> drivers/media/pl
pointers through the link setup handler.
>
> Instead of going through this complex procedure, remove link creation
> and set the sink pointers directly.
>
> Signed-off-by: Laurent Pinchart
A whole function removed ... always love code removal...
Reviewed-by: Kieran Bingham
>
> Signed-off-by: Laurent Pinchart
A bit of comment merge between this and the next patch but it's minor and not
worth the effort to change that ... so I'll happily ignore it if you do :)
Reviewed-by: Kieran Bingham
> ---
> drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 12 ++---
new entity type, but reuse
s/modeling/modelling/
> the vsp1_bru object underneath. Chaining the BRU and BRS entities seems
> to be supported by the hardware but isn't implemented yet as it isn't
> the primary use case for the BRS.
>
> Signed-off-by: Lauren
Hi Laurent,
I've just seen Maxime's latest series "[PATCH 0/4] drm/sun4i: Fix a register
access bug" and it relates directly to a comment I had in this patch:
On 12/07/17 17:35, Kieran Bingham wrote:
> Hi Laurent,
>
> On 28/06/17 19:50, Laurent Pinchart wrote:
>&
On 13/07/17 16:51, Kieran Bingham wrote:
> Hi Laurent,
>
> I've just seen Maxime's latest series "[PATCH 0/4] drm/sun4i: Fix a register
> access bug" and it relates directly to a comment I had in this patch:
>
> On 12/07/17 17:35, Kieran Bingham wrote:
process the display start interrupt anymore.
>
> Signed-off-by: Laurent Pinchart
Ok, I had skipped this one as I was concerned about its effects in relation to
11/14 but I see how that's working now.
Reviewed-by: Kieran Bingham
> ---
> drivers/media/platform/vsp1/vsp1_
t that's
not a blocker to adding in the initial devices at all.
Therefore:
Reviewed-by: Kieran Bingham
> ---
> drivers/media/platform/vsp1/vsp1_drv.c | 24
> drivers/media/platform/vsp1/vsp1_regs.h | 15 +--
> 2 files changed, 37 inser
ned-off-by: Laurent Pinchart
This looks good.
Reviewed-by: Kieran Bingham
> ---
> drivers/media/platform/vsp1/vsp1.h| 5 ++--
> drivers/media/platform/vsp1/vsp1_drm.c| 8 ++---
> drivers/media/platform/vsp1/vsp1_drv.c| 49
> +++---
On 14/07/17 00:31, Laurent Pinchart wrote:
> Hi Kieran,
>
> On Thursday 13 Jul 2017 18:49:19 Kieran Bingham wrote:
>> On 26/06/17 19:12, Laurent Pinchart wrote:
>>> New Gen3 SoCs come with two new VSP2 variants names VSP2-BS and VSP2-DL,
>>> as well as a new V
function without any code change.
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_video.c | 73 -
1 file changed, 36 insertions(+), 37 deletions(-)
diff --git a/drivers/media/platform/vsp1/vsp1_video.c
b/drivers/media/platform
indow. This system allows the
entity objects to specify what they need to fulfil the output for the next
entity in the pipeline.
v2:
- Rebased to v4.12-rc1
- Partition tables dynamically allocated
- review fixups
Kieran Bingham (6):
v4l: vsp1: Move vsp1_video_pipeline_setup_partitions() fun
-calculate the partition sizes into this table.
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
v2:
- Partition table allocated dynamically as required.
- loop uses unsigned int
- rebase on top of suspend-resume fix commits
---
drivers/media/platform/vsp1/vsp1_pipe.h | 3
the partition
struct rather than copying and duplicating the processed data
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_pipe.h | 12 +-
drivers/media/platform/vsp1/vsp1_rpf.c | 4 +-
drivers/media/platform/vsp1/vsp1_uds.c | 8
.
Utilise local variables for the processing as required.
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
v2:
- s/current_partition/partition/
- s/partition_number/partition/
---
drivers/media/platform/vsp1/vsp1_pipe.h | 4
drivers/media/platform/vsp1/vsp1_video.c | 22
e required
output to its predecessor in the pipeline.
Signed-off-by: Kieran Bingham
---
v2:
- vsp1_partition_rect renamed as vsp1_partition_window
- destination vsp1_partition_window made const to prevent change
- (currently) unused 'offset' removed.
- partition functions made stati
Provide register definitions required for UDS phase and partition
algorithm support.
These registers are applicable to Gen3 hardware only.
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_regs.h | 14 ++
1 file changed, 14 insertions
Fragments are no longer 'freed' in interrupt context, but instead released back
to their respective pools.
This allows us to remove the garbage collector in the DLM.
Signed-off-by: Kieran Bingham
---
drivers/media/platform/vsp1/vsp1_dl.c | 151 ++-
1 file c
multiple display list
bodies in a single allocation, and providing these to the display list
through a 'fragment pool'. A pool can be allocated by the display list
manager or entities which require their own body allocations.
Signed-off-by: Kieran Bingham
---
drivers/media/platform/vsp1
Adapt the dl->body0 object to use an object from the fragment pool.
This greatly reduces the pressure on the TLB for IPMMU use cases, as
all of the lists use a single allocation for the main body
Signed-off-by: Kieran Bingham
---
drivers/media/platform/vsp1/vsp1_dl.c |
catch any
buffer overflows
Signed-off-by: Kieran Bingham
---
drivers/media/platform/vsp1/vsp1_dl.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/media/platform/vsp1/vsp1_dl.c
b/drivers/media/platform/vsp1/vsp1_dl.c
index 8b5cbb6b7a70..1311e7cf2733 100644
--- a/drivers/media
Adapt the LUT to allocate a fragment pool for passing the table updates
to hardware.
Two bodies are pre-allocated in the pool to manage a userspace update
before the hardware has taken a previous set of tables.
Signed-off-by: Kieran Bingham
---
drivers/media/platform/vsp1/vsp1_lut.c | 23
Adapt the CLU to allocate a fragment pool for passing the table updates
to hardware.
Two bodies are pre-allocated in the pool to manage a userspace update
before the hardware has taken a previous set of tables.
Signed-off-by: Kieran Bingham
---
drivers/media/platform/vsp1/vsp1_clu.c | 18
has been tested and based on top of Laurent's recent ES2.0 patch
set at git://linuxtv.org/pinchartl/media.git drm/next/h3-es2/merged
Kieran Bingham (6):
v4l: vsp1: Protect fragments against overflow
v4l: vsp1: Provide a fragment pool
v4l: vsp1: Convert display lists to use new fragment
Hi Maxime,
On 17/07/17 07:32, Maxime Ripard wrote:
> On Thu, Jul 13, 2017 at 05:25:08PM +0100, Kieran Bingham wrote:
>>>>> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
>>>>> b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
>>>>> index 82b978a5dae6.
entities to participate in the partition algorithm
(2017-07-17 09:53:18 +0100)
Kieran Bingham (6):
v4l: vsp1: Move vsp1_video_pipeline_setup_partitions() function
v4l: vsp1: Calculate partition sizes at stream start
Hi Niklas,
Small spelling error discovered in here:
On 15/06/17 10:17, Niklas Söderlund wrote:
> This is a wrapper around the media entity get_fwnode_pad operation.
>
> Signed-off-by: Niklas Söderlund
> Acked-by: Sakari Ailus
> ---
> drivers/media/media-entity.c | 36 +
Use a container_of macro to obtain the graph entity object from the ASD
This removes the error conditions, and reduces the lock contention.
(The locking may even be potentially removed)
Signed-off-by: Kieran Bingham
---
Hi Niklas,
While working through the Multi camera setup, we came across
Hi Laurent,
Thankyou for the patch,
On 26/06/17 19:12, Laurent Pinchart wrote:
> On Gen3 SoCs DPAD0 routing is configured through the last CRTC group,
> unlike on Gen2 where it is configured through the first CRTC group. Fix
> the driver accordingly.
>
> Fixes: 2427b3037710 ("drm: rcar-du: Add R
; rcar_du_group_write(rcrtc->group, DPLLCR,
> dpllcr);
> -
> - escr = ESCR_DCLKSEL_DCLKIN | 1;
> - } else {
> -
can be called with the DU
> + * channels of the corresponding CRTCs disabled, we need to enable the
> + * group clock before accessing the register.
>*/
> - ret = clk_prepare_enable(rcdu->crtcs[0].clock);
> + index = rcdu->info->gen < 3 ? 0 :
WPF outputs that don't support headerless mode.
>
> Signed-off-by: Laurent Pinchart
Except for future discussion points, I can't see anything wrong here so:
Reviewed-by: Kieran Bingham
> ---
> drivers/media/platform/vsp1/vsp1_dl.c | 195
> +-
ored. Mostly just me thinking outload.
Reviewed-by: Kieran Bingham
> ---
> drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 2 +-
> drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 3 ++
> drivers/gpu/drm/rcar-du/rcar_du_kms.c | 91
> ++
> drivers/gpu/d
e. Refactor the VSP DRM code to
> support that by introducing a vsp_drm_pipeline object that models one
> display pipeline.
>
> Signed-off-by: Laurent Pinchart
I can't see anything wrong here, so maybe my eyes are going fuzzy from all the
blue text in my mail client :-)
On 01/08/17 19:47, Laurent Pinchart wrote:
> Hi Kieran,
>
> On Tuesday 01 Aug 2017 18:35:48 Kieran Bingham wrote:
>> On 26/06/17 19:12, Laurent Pinchart wrote:
>>> The VSP supports both header and headerless display lists. The latter is
>>> easier to use when the
enables(dev, old_state);
>
> drm_atomic_helper_commit_hw_done(old_state);
> - drm_atomic_helper_wait_for_vblanks(dev, old_state);
> + drm_atomic_helper_wait_for_flip_done(dev, old_state);
Ahh yes, that makes sense!
Reviewed-by: Kieran Bingham
> drm_atomic_helper_cleanup_planes(dev, old_state);
> }
>
od to me.
> Signed-off-by: Laurent Pinchart
Reviewed-by: Kieran Bingham
> ---
> drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 58
> ++
> drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 8 +
> 2 files changed, 60 insertions(+), 6 deletions(-)
>
> d
From: Kieran Bingham
The current implementation has to search the list of controls for the
pixel rate control, each time it is set. This can be optimised easily
by storing the ctrl pointer in the CSI/TX object, and referencing that
directly.
While at it, fix up a missing blank line also
cated
- review fixups
v3:
- Review fixes and changes from Laurent
- v4l: vsp1: Release buffers in start_streaming error path
Kieran Bingham (7):
v4l: vsp1: Release buffers in start_streaming error path
v4l: vsp1: Move vsp1_video_pipeline_setup_partitions() function
v4l: vsp1: Calculate part
event duplication
and call from both vsp1_video_stop_streaming() and the error path in
vsp1_video_start_streaming()
Signed-off-by: Kieran Bingham
---
drivers/media/platform/vsp1/vsp1_video.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/drivers/media/pla
function without any code change.
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_video.c | 74 -
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/drivers/media/platform/vsp1/vsp1_video.c
b/drivers/media/platform
left and width values only.
When generating the partition windows, operate directly on the partition
struct rather than copying and duplicating the processed data
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_pipe.h | 15 +++--
drivers/media
Provide register definitions required for UDS phase and partition
algorithm support. The registers and bits defined here are available on
Gen3 hardware only.
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_regs.h | 14 ++
1 file
.
Utilise local variables for the processing as required.
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_pipe.h | 4
drivers/media/platform/vsp1/vsp1_video.c | 21 +++--
2 files changed, 7 insertions(+), 18 deletions(-)
diff --git
-calculate the partition sizes into this table.
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_pipe.h | 3 ++-
drivers/media/platform/vsp1/vsp1_video.c | 48 +
2 files changed, 36 insertions(+), 15 deletions(-)
diff --git a
required
output to its predecessor in the pipeline.
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_entity.h | 7 -
drivers/media/platform/vsp1/vsp1_pipe.c | 22 +-
drivers/media/platform/vsp1/vsp1_pipe.h | 30
Hi Laurent,
Thankyou for the speedy review.
On 04/08/17 17:03, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Friday 04 Aug 2017 16:57:05 Kieran Bingham wrote:
>> Presently any received buffers are only released back to vb2 if
>> vsp1_video
Hi Laurent,
On 04/08/17 17:13, Laurent Pinchart wrote:
> On Friday 04 Aug 2017 17:08:34 Kieran Bingham wrote:
>> On 04/08/17 17:03, Laurent Pinchart wrote:
>>> On Friday 04 Aug 2017 16:57:05 Kieran Bingham wrote:
>>>> Presently any received buffers ar
ed-by tags.
Kieran Bingham (7):
v4l: vsp1: Release buffers in start_streaming error path
v4l: vsp1: Move vsp1_video_pipeline_setup_partitions() function
v4l: vsp1: Calculate partition sizes at stream start
v4l: vsp1: Remove redundant context variables
v4l: vsp1: Move partition rectangles to
duplication
and call from both vsp1_video_stop_streaming() and the error path in
vsp1_video_start_streaming().
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_video.c | 24
1 file changed, 16 insertions(+), 8 deletions(-)
diff
function without any code change.
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_video.c | 74 -
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/drivers/media/platform/vsp1/vsp1_video.c
b/drivers/media/platform
left and width values only.
When generating the partition windows, operate directly on the partition
struct rather than copying and duplicating the processed data
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_pipe.h | 15 +++--
drivers/media
Provide register definitions required for UDS phase and partition
algorithm support. The registers and bits defined here are available on
Gen3 hardware only.
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_regs.h | 14 ++
1 file
required
output to its predecessor in the pipeline.
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_entity.h | 7 -
drivers/media/platform/vsp1/vsp1_pipe.c | 22 +-
drivers/media/platform/vsp1/vsp1_pipe.h | 30
.
Utilise local variables for the processing as required.
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_pipe.h | 4
drivers/media/platform/vsp1/vsp1_video.c | 21 +++--
2 files changed, 7 insertions(+), 18 deletions(-)
diff --git
-calculate the partition sizes into this table.
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_pipe.h | 3 ++-
drivers/media/platform/vsp1/vsp1_video.c | 44 +
2 files changed, 34 insertions(+), 13 deletions(-)
diff --git a
ate before the hardware has committed a previous
set of tables.
Fragments are no longer 'freed' in interrupt context, but instead
released back to their respective pools. This allows us to remove the
garbage collector in the DLM.
Signed-off-by: Kieran Bingham
---
v2:
- Use dl->body0
catch any
buffer overflows.
Signed-off-by: Kieran Bingham
---
drivers/media/platform/vsp1/vsp1_dl.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/media/platform/vsp1/vsp1_dl.c
b/drivers/media/platform/vsp1/vsp1_dl.c
index 8b5cbb6b7a70..cb4625ae13c2 100644
--- a/drivers/media
vidual partitions is handled by
passing the partition number to the configure call, and processing any
runtime stage actions on the first partition only.
Signed-off-by: Kieran Bingham
---
drivers/media/platform/vsp1/vsp1_bru.c| 12 +-
drivers/media/platform/vsp1/vsp1_clu.c| 43 +--
drivers
frame, for both DRM and Video API pipelines thus a
rounded 64 entries provides a suitable allocation.
Signed-off-by: Kieran Bingham
---
drivers/media/platform/vsp1/vsp1_dl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/vsp1/vsp1_dl.c
b/drivers/media
Extend the display list body with a reference count, allowing bodies to
be kept as long as a reference is maintained. This provides the ability
to keep a cached copy of bodies which will not change, so that they can
be re-applied to multiple display lists.
Signed-off-by: Kieran Bingham
---
This
helper, vsp1_dl_list_body() is provided to access the internal body0
from the display list.
Signed-off-by: Kieran Bingham
---
drivers/media/platform/vsp1/vsp1_bru.c| 22 ++--
drivers/media/platform/vsp1/vsp1_clu.c| 22 ++--
drivers/media/platform/vsp1/vsp1_dl.c | 12
is reset - our cached
configuration will be re-attached to the next committed DL.
Signed-off-by: Kieran Bingham
---
Our video DL usage now looks like the below output:
dl->body0 contains our disposable runtime configuration. Max 41.
dl_child->body0 is our partition specific configurat
for
expansion this is set to 128 for now to prevent unexpected overflows.
Kieran Bingham (8):
v4l: vsp1: Protect fragments against overflow
v4l: vsp1: Provide a fragment pool
v4l: vsp1: Convert display lists to use new fragment pool
v4l: vsp1: Use reference counting for fragments
v4l: v
multiple display list
bodies in a single allocation, and providing these to the display list
through a 'fragment pool'. A pool can be allocated by the display list
manager or entities which require their own body allocations.
Signed-off-by: Kieran Bingham
---
v2:
- assign dlb->
From: Kieran Bingham
Hi Geert,
Please consider pulling the following changes into renesas-drivers.
This series is based upon a merge of my previous pa-improvements/v4 and
airlied-drm/drm-next to base on top of all pending VSP1 changes.
The following changes since commit
Hi Geert,
>>
>> This series is based upon a merge of my previous pa-improvements/v4 and
>> airlied-drm/drm-next to base on top of all pending VSP1 changes.
>
> OK, so I'll drop your vsp1/pa-improvements/v2.
That sounds reasonable :D
>> git://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rc
Hi Laurent,
Thanks for your review,
On 16/08/17 22:53, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
> How about
>
> if (WARN_ONCE(dlb->num_entries >= dlb->max_entries,
> "DLB size exceeded (max %u)", dlb->max_entries))
> return;
>
>
From: Kieran Bingham
The killall command is provided by the psmisc package on debian based systems.
On other systems it should be built or added to the filesystem as appropriate.
Also remove unnecessary blank line.
Signed-off-by: Kieran Bingham
---
README | 2 +-
1 file changed, 1 insertion
From: Kieran Bingham
Update the vsp-tests to source the vsp-lib.sh with an explicit path, and
use the POSIX compliant '.' rather than 'source'.
Also update the README to document new requirements.
Kieran Bingham (2):
tests: Use POSIX '.' as 'source&#
From: Kieran Bingham
On posix shells, only the '.' command is supported.
Even when running on a full bash shell, the file to source must be
either fully or locally qualified.
Fix both issues by swapping to the posix standard
Signed-off-by: Kieran Bingham
---
tests/vsp-unit-test-0
Hi Laurent,
On 24/08/17 10:36, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Thursday, 24 August 2017 01:41:04 EEST Kieran Bingham wrote:
>> From: Kieran Bingham
>>
>> The killall command is provided by the psmisc package on debian b
Hi Laurent,
On 24/08/17 10:23, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Thursday, 24 August 2017 01:41:03 EEST Kieran Bingham wrote:
>> From: Kieran Bingham
>>
>> On posix shells, only the '.' command is supported.
>
Hi Laurent,
Thanks for the patch.
On 24/08/17 10:30, Laurent Pinchart wrote:
> Use the media device under test, not the default media0.
>
> Signed-off-by: Laurent Pinchart
Looks good, and looks like this is the only use of media-ctl directly.
Reviewed-by: Kieran Bingham
> --
Hi Laurent,
Thankyou for the patch
On 24/08/17 10:30, Laurent Pinchart wrote:
> Reuse the BRU code, using the brx generic name to cover both BRU and
> BRS.
>
> Signed-off-by: Laurent Pinchart
This looks good to me:
Reviewed-by: Kieran Bingham
> ---
> scrip
Hi Laurent,
On 24/08/17 10:30, Laurent Pinchart wrote:
> Signed-off-by: Laurent Pinchart
Nothing scary in here. Just pending testing the other patchset/issues, then I
can run this through as well for a tested-by.
Meanwhile:
Reviewed-by: Kieran Bingham
> ---
> tests/vsp-unit-tes
Hi Laurent,
Clearly I hit send too early :-D
On 30/08/17 15:16, Kieran Bingham wrote:
> Hi Laurent,
>
> On 24/08/17 10:30, Laurent Pinchart wrote:
>> Signed-off-by: Laurent Pinchart
>
> Nothing scary in here. Just pending testing the other patchset/issues, then I
>
with 2 inputs: pass
root@Ubuntu-ARM64:~/vsp-tests#
Tested-by: Kieran Bingham
--
Regards
Kieran
Interestingly as a side note, while on the Salvator-XS, I ran test-0003 and it
went straight through 4 times consecutively!
root@Ubuntu-ARM64:~/vsp-tests# ./vsp-unit-test-0003.sh
Testing scaling from
Hi Simon,
On 11/09/17 05:30, Simon Yuan wrote:
> Hi Niklas,
>
> How are you doing? I've picked you as my contact since I met you earlier this
> year at ELC2017. Not sure if you still remember, but we had a very brief chat
> about the status of the adv748x driver.
I'll let Niklas reply to this bit
Hi Laurent,
Thanks for the review
On 17/08/17 13:13, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Monday 14 Aug 2017 16:13:26 Kieran Bingham wrote:
>> Adapt the dl->body0 object to use an object from the fragment pool.
>> This greatly r
Hi Laurent,
Thanks for your review,
On 17/08/17 13:13, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Monday 14 Aug 2017 16:13:25 Kieran Bingham wrote:
>> Each display list allocates a body to store register values in a dma
>> accessible
On 17/08/17 17:11, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Monday 14 Aug 2017 16:13:31 Kieran Bingham wrote:
>> The display list originally allocated a body of 256 entries to store all
>> of the register lists required for each fra
Hi Laurent,
On 17/08/17 19:13, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Monday 14 Aug 2017 16:13:28 Kieran Bingham wrote:
>> The entities provide a single .configure operation which configures the
>> object into the target
Hi Laurent,
On 17/08/17 18:58, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Monday 14 Aug 2017 16:13:29 Kieran Bingham wrote:
>> Currently the entities store their configurations into a display list.
>> Adapt this such that the code ca
801 - 900 of 1058 matches
Mail list logo
